September 2016 - Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-setup[master]: virt: adding a graphic device
by stirabos＠redhat.com 12 Sep '16

12 Sep '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: virt: adding a graphic device ...................................................................... virt: adding a graphic device VDSM from master requires also a graphic device, adding it. Change-Id: I00fcda8779fcc70e650438ea659c3b0a82685bb2 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/mixins.py M templates/vm.conf.in 2 files changed, 5 insertions(+), 0 deletions(-) Approvals: Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Rafael Martins: Looks good to me, but someone else must approve Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/63697 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00fcda8779fcc70e650438ea659c3b0a82685bb2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Use try-with-resource
by amureini＠redhat.com 12 Sep '16

12 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Use try-with-resource ...................................................................... core: Use try-with-resource Wherever possible, use try-with-resource to reduce code bloating. Change-Id: I7c2352779afac23dbc97b0f37137b45fc61d20ba Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/GetoVirtISOsQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/OpenStackImageProviderProxy.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDaoTestCase.java M backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/Configuration.java M backend/manager/modules/extensions-manager/src/test/java/org/ovirt/engine/core/extensions/mgr/ConfigurationTest.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/db/StandaloneDataSource.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/ServletUtils.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/archivers/tar/TarTest.java 9 files changed, 28 insertions(+), 146 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/63693 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c2352779afac23dbc97b0f37137b45fc61d20ba Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: BaseDaoTestCase exceptions
by amureini＠redhat.com 12 Sep '16

12 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: BaseDaoTestCase exceptions ...................................................................... core: BaseDaoTestCase exceptions If a datasource cannot be loaded, allow the exception to be thrown all the way up so JUnit can handle the proper printing of the stacktrace instead of reinventing the wheel. Change-Id: Ie01c2191c3ba6608507edad430f4c751d05e2dda Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDaoTestCase.java 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/63692 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie01c2191c3ba6608507edad430f4c751d05e2dda Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove DbUtils
by amureini＠redhat.com 12 Sep '16

12 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove DbUtils ...................................................................... core: Remove DbUtils DbUtils' closeQuietly methods were just a nicety to avoid boiler-plated code in the finally block of a try block handling JDBC resources. Since Java 7, all JDBC resources are autoclosable, so there's a much cleaner way of handling these issues - with a try-with-resource block. This patch converts all the usages of DbUtils to standard Java try-with-resource blocks and removes this now-useless class completely. Change-Id: I6620228031c9f723b350e10820c5a8035fef241f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/db/DbUtils.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/EngineMonitorService.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/dao/EventsManager.java 3 files changed, 26 insertions(+), 136 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/63691 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6620228031c9f723b350e10820c5a8035fef241f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: services: Inject Backend directly into Servlets
by mperina＠redhat.com 12 Sep '16

12 Sep '16

Martin Peřina has submitted this change and it was merged. Change subject: services: Inject Backend directly into Servlets ...................................................................... services: Inject Backend directly into Servlets Replaced manual EJB JNDI lookup with direct CDI injection. Change-Id: If8ca3b748ad78b66b15cf5309f4b1011c1fb0f6d Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/GetSessionUser.java M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/HealthStatus.java M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/RegisterServlet.java M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/SsoCallbackServlet.java 4 files changed, 17 insertions(+), 20 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Alexander Wels: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Martin Betak: Verified -- To view, visit https://gerrit.ovirt.org/63623 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8ca3b748ad78b66b15cf5309f4b1011c1fb0f6d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Fix repositories for 4.0 aaa-jdbc build
by sbonazzo＠redhat.com 12 Sep '16

12 Sep '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Fix repositories for 4.0 aaa-jdbc build ...................................................................... Fix repositories for 4.0 aaa-jdbc build Change-Id: Idcc9d43697a2356c441ba13ed9a5192cddb66488 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-extension-aaa-jdbc/ovirt-engine-extension-aaa-jdbc_create-rpms.yaml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63668 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idcc9d43697a2356c441ba13ed9a5192cddb66488 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Add example of changing VM CD
by omachace＠redhat.com 12 Sep '16

12 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: Add example of changing VM CD ...................................................................... Add example of changing VM CD This patch adds example of changing VM CD. Change-Id: I957ed6b34f489ba4cc7c231c40a5cc1a9051e1f8 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- A sdk/examples/change_vm_cd.py 1 file changed, 75 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63503 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I957ed6b34f489ba4cc7c231c40a5cc1a9051e1f8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add example of how to add a MAC address pool
by juan.hernandez＠redhat.com 12 Sep '16

12 Sep '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add example of how to add a MAC address pool ...................................................................... Add example of how to add a MAC address pool This patch adds an example that shows how to add a new MAC address pool to the system, and how to assign it to an existing cluster. Change-Id: Ided50d3c16b47e37a4453c6537568c22dbf507c3 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A sdk/examples/add_mac_pool.rb 1 file changed, 72 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/63674 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ided50d3c16b47e37a4453c6537568c22dbf507c3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Add example of how to add a MAC address pool
by omachace＠redhat.com 12 Sep '16

12 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: Add example of how to add a MAC address pool ...................................................................... Add example of how to add a MAC address pool This patch adds an example that shows how to add a new MAC address pool to the system, and how to assign it to an existing cluster. Change-Id: I8914e774433e171058a5e75976d20a95ca6cda62 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A sdk/examples/add_mac_pool.py 1 file changed, 77 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63666 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8914e774433e171058a5e75976d20a95ca6cda62 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Add generic writer
by juan.hernandez＠redhat.com 12 Sep '16

12 Sep '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add generic writer ...................................................................... Add generic writer Currently the SDK doesn't have any mechanism to generate an XML document from an object whose type isn't known. This patch adds a new 'Writer.write' method that decides what is the specific writer to use based on the type of the object, so that the caller doesn't need to explicitly select it. Change-Id: I0f6f8af923253707e55b98f04f3407105dc529b4 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 66eddb23bd35b73201f6d2414f7aa127d4b7a12c) --- M generator/src/main/java/org/ovirt/sdk/ruby/WritersGenerator.java M sdk/lib/ovirtsdk4/writer.rb M sdk/spec/writer_spec.rb 3 files changed, 149 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63672 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f6f8af923253707e55b98f04f3407105dc529b4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0