September 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-ruby[master]: Add generic writer
by juan.hernandez＠redhat.com 12 Sep '16

12 Sep '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add generic writer ...................................................................... Add generic writer Currently the SDK doesn't have any mechanism to generate an XML document from an object whose type isn't known. This patch adds a new 'Writer.write' method that decides what is the specific writer to use based on the type of the object, so that the caller doesn't need to explicitly select it. Change-Id: I0f6f8af923253707e55b98f04f3407105dc529b4 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/ruby/WritersGenerator.java M sdk/lib/ovirtsdk4/writer.rb M sdk/spec/writer_spec.rb 3 files changed, 149 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63131 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f6f8af923253707e55b98f04f3407105dc529b4 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Add example of changing VM CD
by juan.hernandez＠redhat.com 12 Sep '16

12 Sep '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add example of changing VM CD ...................................................................... Add example of changing VM CD This patch adds example of changing VM CD. Change-Id: If907ba7c28dc0177eda8b7669c221ef8054cdc11 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit 4ef20ab98bdd61abc2018bdc9a8c2af59379c696) --- A sdk/examples/change_vm_cd.rb 1 file changed, 69 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/63670 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If907ba7c28dc0177eda8b7669c221ef8054cdc11 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Add optional paramater to update method
by juan.hernandez＠redhat.com 12 Sep '16

12 Sep '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add optional paramater to update method ...................................................................... Add optional paramater to update method Since update method can send query parameters, this patch adds optional parameter to update method, so user is able to send query parameters. Change-Id: Ie5bef7fa51d5567d51c7ffee469830ac57a597f6 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit 1bb53ec6d4dc06bc9a5d3fa1f32d099e1f440dda) --- M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java M sdk/spec/spec_helper.rb M sdk/spec/vm_service_spec.rb 3 files changed, 35 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63669 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5bef7fa51d5567d51c7ffee469830ac57a597f6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add example of changing VM CD
by juan.hernandez＠redhat.com 12 Sep '16

12 Sep '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add example of changing VM CD ...................................................................... Add example of changing VM CD This patch adds example of changing VM CD. Change-Id: If907ba7c28dc0177eda8b7669c221ef8054cdc11 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- A sdk/examples/change_vm_cd.rb 1 file changed, 69 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified Juan Hernandez: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/63559 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If907ba7c28dc0177eda8b7669c221ef8054cdc11 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add optional paramater to update method
by juan.hernandez＠redhat.com 12 Sep '16

12 Sep '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add optional paramater to update method ...................................................................... Add optional paramater to update method Since update method can send query parameters, this patch adds optional parameter to update method, so user is able to send query parameters. Change-Id: Ie5bef7fa51d5567d51c7ffee469830ac57a597f6 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java M sdk/spec/spec_helper.rb M sdk/spec/vm_service_spec.rb 3 files changed, 35 insertions(+), 1 deletion(-) Approvals: Ondra Machacek: Verified Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63558 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5bef7fa51d5567d51c7ffee469830ac57a597f6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: tests: remove assertFailsWithValidateMessage occurrences.
by amureini＠redhat.com 12 Sep '16

12 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: tests: remove assertFailsWithValidateMessage occurrences. ...................................................................... tests: remove assertFailsWithValidateMessage occurrences. assertFailsWithValidateMessage is currently duplicated in two test classes, while ValidateTestUtils already supplies its functionallity in runAndAssertValidateFailure(..). Replace assertFailsWithValidateMessage with runAndAssertValidateFailure. Change-Id: I0203ddfeef989674af8152b2725a83266183e29b Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/hostdeploy/InstallVdsInternalCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/hostdeploy/UpgradeOvirtNodeInternalCommandTest.java 2 files changed, 7 insertions(+), 19 deletions(-) Approvals: Amit Aviram: Verified Allon Mureinik: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/63252 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0203ddfeef989674af8152b2725a83266183e29b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: complement I61c2e5ae
by ahadas＠redhat.com 12 Sep '16

12 Sep '16

Arik Hadas has submitted this change and it was merged. Change subject: core: complement I61c2e5ae ...................................................................... core: complement I61c2e5ae I61c2e5ae removed numa node related code. This patch removes additional code that is unused in light of this removal. Change-Id: I5baf1fd9e7889837ec59438a3d795892b3ccacfe Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzerFactory.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzerTest.java 4 files changed, 2 insertions(+), 52 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Andrej Krejcir: Looks good to me, but someone else must approve Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/63651 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5baf1fd9e7889837ec59438a3d795892b3ccacfe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Validate 'nfs_timeo' and 'nfs_retrans' range
by juan.hernandez＠redhat.com 12 Sep '16

12 Sep '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Validate 'nfs_timeo' and 'nfs_retrans' range ...................................................................... restapi: Validate 'nfs_timeo' and 'nfs_retrans' range Current the 'nfs_timeo' and 'nfs_retrans' values used when adding NFS storage aren't validated, their values are just truncated and passed to the backend. That is wrong. As the backend receives a 'short' and the API uses an 'integer' it isn't possible to do the validation in the backend, thus it needs to be done in the API. This patch changes the API so that it performs explicitly this check before trying to do anything with the storage. If the check fails, for example if the value of 'nfs_timeo' is 131077, the operation will fail with error code 400 (Bad Request) and the following response body will be returned: <fault> <reason>Value out of range</reason> <detail>The value 131077 of attribute 'nfs_timeio' is outside of range 0 to 65535.</detail> </fault> Change-Id: I3e26b58879b2a3e0ed54fbdb9a1c70aa4efcc73c Bug-Url: https://bugzilla.redhat.com/1373581 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/logging/Messages.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BaseBackendResource.java M backend/manager/modules/restapi/jaxrs/src/main/resources/org/ovirt/engine/api/restapi/logging/Messages.properties 4 files changed, 28 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Daniel Erez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/63537 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e26b58879b2a3e0ed54fbdb9a1c70aa4efcc73c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: QuotaManagerTest Mockito verifications
by amureini＠redhat.com 11 Sep '16

11 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: QuotaManagerTest Mockito verifications ...................................................................... core: QuotaManagerTest Mockito verifications Use Mockito#verify to verify mock interactions instead of reimplementing that logic inside the test. Change-Id: I17a64ce73b69f5b38b1079ef509458d46ce9278d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/quota/QuotaManagerTest.java 1 file changed, 6 insertions(+), 15 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63574 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17a64ce73b69f5b38b1079ef509458d46ce9278d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: VersionTest#compare
by amureini＠redhat.com 11 Sep '16

11 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: VersionTest#compare ...................................................................... core: VersionTest#compare Fix the test to test the CONTRACT of compareTo instead of the specific implementation. The implementation can change to return 100 and -100 instead of 1 and -1 and still be completely correct, but fail the older test. Change-Id: I216941556b1223962a4bb80299435f6d3137289e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/VersionTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/63569 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I216941556b1223962a4bb80299435f6d3137289e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0