September 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: rename QuotaManagerTest#testSetup to setUp
by amureini＠redhat.com 11 Sep '16

11 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: rename QuotaManagerTest#testSetup to setUp ...................................................................... core: rename QuotaManagerTest#testSetup to setUp The method testSetup() looks like an old JUnit 3 style test although it's actually a setup method annotated with @Before. This patch renames the method to remove some potential confusion. Change-Id: I8dd0278b15ac04f97103250d19436d88e1bb053a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/quota/QuotaManagerTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63571 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8dd0278b15ac04f97103250d19436d88e1bb053a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: AbstractBackendResourceLoggingTest exceptions
by amureini＠redhat.com 11 Sep '16

11 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: restapi: AbstractBackendResourceLoggingTest exceptions ...................................................................... restapi: AbstractBackendResourceLoggingTest exceptions Throw the exception if setting up the test doesn't succeed instead of swallowing it and having the test fail later in an unpredictable way. Change-Id: I4ad32ed81d9c068b85906b7f54ee3cfa1853c709 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendResourceLoggingTest.java 1 file changed, 5 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/63614 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ad32ed81d9c068b85906b7f54ee3cfa1853c709 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: minor refactoring in VmStatsRefresher
by ahadas＠redhat.com 11 Sep '16

11 Sep '16

Arik Hadas has submitted this change and it was merged. Change subject: core: minor refactoring in VmStatsRefresher ...................................................................... core: minor refactoring in VmStatsRefresher Change VmStatsRefresher#processDevices to receive a stream of VdsmVm instead of a stream of VmDynamic. Change-Id: I5808b21b8593f5c2ea5eff4715176e6cf7ac65b3 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/EventVmStatsRefresher.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/PollVmStatsRefresher.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VdsmVm.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmStatsRefresher.java 4 files changed, 11 insertions(+), 8 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/63494 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5808b21b8593f5c2ea5eff4715176e6cf7ac65b3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fix detection of external VMs
by ahadas＠redhat.com 11 Sep '16

11 Sep '16

Arik Hadas has submitted this change and it was merged. Change subject: core: fix detection of external VMs ...................................................................... core: fix detection of external VMs The recently added cache of static VM data lead of NPE when externally managed VMs are detected. This patch solves it by adding protection for the NPE and update the cache data in VmManager when adding externally managed VMs. Change-Id: I6a2af4f5cf3068d19a268239911f086d096b6281 Bug-Url: https://bugzilla.redhat.com/1368817 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUnmanagedVmsCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmManager.java 2 files changed, 11 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/63639 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a2af4f5cf3068d19a268239911f086d096b6281 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Fix error message for storage not found
by tnisan＠redhat.com 11 Sep '16

11 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix error message for storage not found ...................................................................... core: Fix error message for storage not found Syntax for storage domain not found error message fixed to interpret the storage domain id correctly. Change-Id: I5d2c77bdfae2cc4e35aba292b40e1f217ed055c4 Bug-Url: https://bugzilla.redhat.com/1361838 Signed-off-by: Yanir Quinn <yquinn(a)redhat.com> (cherry picked from commit cd9233b) Signed-off-by: Yanir Quinn <yquinn(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Yanir Quinn: Verified -- To view, visit https://gerrit.ovirt.org/63632 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d2c77bdfae2cc4e35aba292b40e1f217ed055c4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix error message for storage not found
by rgolan＠redhat.com 11 Sep '16

11 Sep '16

Roy Golan has submitted this change and it was merged. Change subject: core: Fix error message for storage not found ...................................................................... core: Fix error message for storage not found Syntax for storage domain not found error message fixed to interpret the storage domain id correctly. Change-Id: I5d2c77bdfae2cc4e35aba292b40e1f217ed055c4 Bug-Url: https://bugzilla.redhat.com/1361838 Signed-off-by: Yanir Quinn <yquinn(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Yanir Quinn: Verified -- To view, visit https://gerrit.ovirt.org/63631 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d2c77bdfae2cc4e35aba292b40e1f217ed055c4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.4]: core: delete audit log records of reverted audit log type
by tnisan＠redhat.com 11 Sep '16

11 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: core: delete audit log records of reverted audit log type ...................................................................... core: delete audit log records of reverted audit log type Audit log type reverted by https://gerrit.ovirt.org/#/q/Icd2ce5534b8f227b9a13c70d79418d21dd5da764 but log entries using it may still exist in users' databases. Change-Id: I5e0af3b39ba6551c3e7c31a8a244f15ce051dad6 Bug-Url: https://bugzilla.redhat.com/1374475 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- A packaging/dbscripts/upgrade/04_00_0900_delete_audit_log_records_of_reverted_audit_log_type.sql 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Martin Mucha: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63619 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e0af3b39ba6551c3e7c31a8a244f15ce051dad6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.4 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: delete audit log records of reverted audit log type
by tnisan＠redhat.com 11 Sep '16

11 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: core: delete audit log records of reverted audit log type ...................................................................... core: delete audit log records of reverted audit log type Audit log type reverted by https://gerrit.ovirt.org/#/q/Icd2ce5534b8f227b9a13c70d79418d21dd5da764 but log entries using it may still exist in users' databases. Change-Id: I5e0af3b39ba6551c3e7c31a8a244f15ce051dad6 Bug-Url: https://bugzilla.redhat.com/1374475 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- A packaging/dbscripts/upgrade/04_00_0900_delete_audit_log_records_of_reverted_audit_log_type.sql 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Martin Mucha: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63618 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e0af3b39ba6551c3e7c31a8a244f15ce051dad6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: delete audit log records of reverted audit log type
by emesika＠redhat.com 11 Sep '16

11 Sep '16

Eli Mesika has submitted this change and it was merged. Change subject: core: delete audit log records of reverted audit log type ...................................................................... core: delete audit log records of reverted audit log type Audit log type reverted by https://gerrit.ovirt.org/#/q/Icd2ce5534b8f227b9a13c70d79418d21dd5da764 but log entries using it may still exist in users' databases. Change-Id: I5e0af3b39ba6551c3e7c31a8a244f15ce051dad6 Bug-Url: https://bugzilla.redhat.com/1374475 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- A packaging/dbscripts/upgrade/04_01_0290_delete_audit_log_records_of_reverted_audit_log_type.sql 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Martin Mucha: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63617 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e0af3b39ba6551c3e7c31a8a244f15ce051dad6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: OsRepositoryImplTest printing
by mbetak＠redhat.com 10 Sep '16

10 Sep '16

Martin Betak has submitted this change and it was merged. Change subject: core: OsRepositoryImplTest printing ...................................................................... core: OsRepositoryImplTest printing Removed a useless printing to System.out. Change-Id: I6315d1e3978b49eec3be02d284758f8eec09e2db Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/OsRepositoryImplTest.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/63563 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6315d1e3978b49eec3be02d284758f8eec09e2db Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0