Change in ovirt-engine[master]: core: config mocking in SysprepHandlerTest
by mbetak＠redhat.com
Martin Betak has submitted this change and it was merged.
Change subject: core: config mocking in SysprepHandlerTest
......................................................................
core: config mocking in SysprepHandlerTest
Remove the redundant config mocking from SysprepHandlerTest.
Change-Id: I5c56000137490ba18d6f21d5daea1b205648c3f2
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandlerTest.java
1 file changed, 0 insertions(+), 11 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, but someone else must approve
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/63562
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5c56000137490ba18d6f21d5daea1b205648c3f2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: core: MTUValidator: Clean generics specification
by mbetak＠redhat.com
Martin Betak has submitted this change and it was merged.
Change subject: core: MTUValidator: Clean generics specification
......................................................................
core: MTUValidator: Clean generics specification
Remove the redundant "extends Object" from the generic specification.
There is literally no way T can not extend Object.
Change-Id: I8b8c9942318b8b0ee82e1604f728de8e2bb7e1b8
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/MTUValidatorTest.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/63561
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b8c9942318b8b0ee82e1604f728de8e2bb7e1b8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: core: Remove StandaloneDataSourceTest
by mbetak＠redhat.com
Martin Betak has submitted this change and it was merged.
Change subject: core: Remove StandaloneDataSourceTest
......................................................................
core: Remove StandaloneDataSourceTest
Removed an @Ignored, useless test.
Change-Id: Ia7f099a2dd55cd397f9e872884a8980a4a0ffd98
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
D backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/db/StandaloneDataSourceTest.java
1 file changed, 0 insertions(+), 30 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/63560
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7f099a2dd55cd397f9e872884a8980a4a0ffd98
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: webadmin: Remove unused NumberRangeValidation
by mbetak＠redhat.com
Martin Betak has submitted this change and it was merged.
Change subject: webadmin: Remove unused NumberRangeValidation
......................................................................
webadmin: Remove unused NumberRangeValidation
Commit cd3f88a02851b7b46d07a712a69ec8843099c0f7 removed all the usages
of NumberRangeValidation, except for the ones in
NumberRangeValidationTestUtils (which was unused on its own right).
This commit finishes the job and completely removes these two unused
classes.
Change-Id: Iea7a00d41a22c87dc68d1bd9541e23aa3e00065c
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/NumberRangeValidation.java
D frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/NumberRangeValidationTestUtils.java
2 files changed, 0 insertions(+), 187 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/63565
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iea7a00d41a22c87dc68d1bd9541e23aa3e00065c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: core: VdsCommandTypeTest @Theories
by mbetak＠redhat.com
Martin Betak has submitted this change and it was merged.
Change subject: core: VdsCommandTypeTest @Theories
......................................................................
core: VdsCommandTypeTest @Theories
Use @Theories to clean up the test's code instead of reimplementing
the same logic.
Change-Id: Id345f0b76bc87f85bfac49a4e73ea55a6b4ae00a
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/common/vdscommands/VdsCommandTypeTest.java
1 file changed, 10 insertions(+), 15 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/63564
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id345f0b76bc87f85bfac49a4e73ea55a6b4ae00a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-iso-uploader[ovirt-iso-uploader-4.0]: Spec file: Add nfs-util dependency
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Spec file: Add nfs-util dependency
......................................................................
Spec file: Add nfs-util dependency
Change-Id: I8c3d7965a9a58de987520f04433151069a165049
Signed-off-by: Ido Rosenzwig <irosenzw(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1335170
---
M ovirt-iso-uploader.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Ido Rosenzwig: Verified
Jenkins CI: Passed CI tests
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/63232
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c3d7965a9a58de987520f04433151069a165049
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-iso-uploader
Gerrit-Branch: ovirt-iso-uploader-4.0
Gerrit-Owner: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-iso-uploader[master]: Spec file: Add nfs-util dependency
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Spec file: Add nfs-util dependency
......................................................................
Spec file: Add nfs-util dependency
Change-Id: I8c3d7965a9a58de987520f04433151069a165049
Signed-off-by: Ido Rosenzwig <irosenzw(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1335170
---
M ovirt-iso-uploader.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Ido Rosenzwig: Verified
Jenkins CI: Passed CI tests
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/63231
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c3d7965a9a58de987520f04433151069a165049
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-iso-uploader
Gerrit-Branch: master
Gerrit-Owner: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in jenkins[master]: Enable imageio-proxy in engine setup
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Enable imageio-proxy in engine setup
......................................................................
Enable imageio-proxy in engine setup
Change-Id: Idf8401d25d5c8aab201a6728f0434f6664298021
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M jobs/ovirt-engine_upgrade_to_4.0/setup.file.otopi
M jobs/ovirt-engine_upgrade_to_master/setup.file.otopi
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me; Passed CI tests; Ready for merge
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/62370
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idf8401d25d5c8aab201a6728f0434f6664298021
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-live[ovirt-live-4.0]: build: oVirt Live 4.0.4 RC2.1
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: build: oVirt Live 4.0.4 RC2.1
......................................................................
build: oVirt Live 4.0.4 RC2.1
Change-Id: I4f988928a26222ba29ba26b0ca2d647b849681f2
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M centos-7/Makefile
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified; Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63605
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4f988928a26222ba29ba26b0ca2d647b849681f2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: ovirt-live-4.0
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: core : Upgrade manager: log for failure is not well phrased
by mperina＠redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: core : Upgrade manager: log for failure is not well phrased
......................................................................
core : Upgrade manager: log for failure is not well phrased
Add better log messages when upgrade
manager fails with exception.
Change-Id: I6c55bb3ab8127fb38ca94488e94837b0f51e5a9c
Bug-Url: https://bugzilla.redhat.com/1368030
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Martin Peřina: Looks good to me, approved
Ravi Nori: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/63546
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c55bb3ab8127fb38ca94488e94837b0f51e5a9c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years