Change in ovirt-engine[master]: core: DBConfigUtilsTest type inference
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: DBConfigUtilsTest type inference
......................................................................
core: DBConfigUtilsTest type inference
Change-Id: If8e6e0d19c346088d10090204744d91c2fe68001
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtilsTest.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63171
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If8e6e0d19c346088d10090204744d91c2fe68001
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[master]: core: Fix DAO javadocs
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Fix DAO javadocs
......................................................................
core: Fix DAO javadocs
- Fix broken links
- Change inline HTML to javadoc tags where possible
- Remove uninteresting references to 3.0 DbFacade
- Remove empty javadoc blocks
Change-Id: Ibfafbc07b6246fa26e49008a927b95a627ea6eb3
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/SimpleJdbcCallsHandler.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ActionGroupDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ActionGroupDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AuditLogDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AuditLogDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BaseDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BookmarkDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BookmarkDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BusinessEntitySnapshotDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/CheckedUpdate.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ClusterDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ClusterDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/Dao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbGroupDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbGroupDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDynamicDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EngineSessionDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EngineSessionDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EventDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EventDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ImageDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ImageStorageDomainMapDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ImageTransferDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/JobSubjectEntityDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/JobSubjectEntityDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/LabelDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/LibvirtSecretDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/LibvirtSecretDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/LunDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/LunDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ModificationDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/PermissionDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/PermissionDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/QuotaDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/QuotaDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ReadDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RepoFileMetaDataDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RepoFileMetaDataDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RoleDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RoleDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RoleGroupMapDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RoleGroupMapDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SnapshotDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolIsoMapDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageServerConnectionDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageServerConnectionDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageServerConnectionLunMapDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageServerConnectionLunMapDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/TagDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/TagDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/UnregisteredDisksDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/UnregisteredOVFDataDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/UserProfileDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdcOptionDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdcOptionDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsCpuStatisticsDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsSpmIdMapDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsSpmIdMapDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStatisticsDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStatisticsDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/HostNicVfsConfigDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkClusterDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/provider/ProviderDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/scheduling/ClusterPolicyDao.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/job/ExecutionMessageDirectorTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AsyncTaskDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AuditLogDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDaoTestCase.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BookmarkDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/EngineSessionDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/HostDeviceDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ImageDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/PermissionDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/QuotaDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StoragePoolDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/TagDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsCpuStatisticsDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsNumaNodeDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDynamicDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmNumaNodeDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStatisticsDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/HostNicVfsConfigDaoTest.java
109 files changed, 194 insertions(+), 329 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63170
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibfafbc07b6246fa26e49008a927b95a627ea6eb3
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[master]: core: Remove org.ovirt.engine.core.dao.PostgresDataTypeFactory
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove org.ovirt.engine.core.dao.PostgresDataTypeFactory
......................................................................
core: Remove org.ovirt.engine.core.dao.PostgresDataTypeFactory
Removed this redundant class which is just copy-pasted from DBUnit's
implementation and use the original class.
Change-Id: I194256c4b0c31949ddcf7997febe239391b10cac
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/test/filters/pgsql.properties
D backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/PostgresDataTypeFactory.java
2 files changed, 1 insertion(+), 70 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63248
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I194256c4b0c31949ddcf7997febe239391b10cac
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[master]: core: VmNumaNodeDaoImpl type inference
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: VmNumaNodeDaoImpl type inference
......................................................................
core: VmNumaNodeDaoImpl type inference
Change-Id: I2b9059fe37ce053f957ba8a3ca839cec5496e77e
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmNumaNodeDaoImpl.java
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63169
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2b9059fe37ce053f957ba8a3ca839cec5496e77e
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[master]: core: Remove unused UniqueIdentifierType
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove unused UniqueIdentifierType
......................................................................
core: Remove unused UniqueIdentifierType
Change-Id: Id6ac08e5b80909fa16ea038d85f57595334a3eea
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
D backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/UniqueIdentifierType.java
1 file changed, 0 insertions(+), 36 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63188
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id6ac08e5b80909fa16ea038d85f57595334a3eea
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[master]: core: Use SingleColumnRowMapper
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Use SingleColumnRowMapper
......................................................................
core: Use SingleColumnRowMapper
Reuse org.springframework.jdbc.core.SingleColumnRowMapper instead of
reinventing the wheel.
Change-Id: Ia6954a70cd39b8f0f552e2bd3fdf398121053016
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BaseDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ClusterDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/HostDeviceDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/IscsiBondDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/JobDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/MacPoolDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/QuotaDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SnapshotDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmAndTemplatesGenerationsImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmIconDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterHooksDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/VmNicDaoImpl.java
18 files changed, 50 insertions(+), 113 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63112
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6954a70cd39b8f0f552e2bd3fdf398121053016
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[master]: core: StepSubjectEntityDaoTest String.format
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: StepSubjectEntityDaoTest String.format
......................................................................
core: StepSubjectEntityDaoTest String.format
Remove a useless String.format call.
Change-Id: If4e63f956f2c30b0c9c8c1d9f3c3d463efe4d793
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StepSubjectEntityDaoTest.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63187
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If4e63f956f2c30b0c9c8c1d9f3c3d463efe4d793
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[master]: core: DAO test members
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: DAO test members
......................................................................
core: DAO test members
Reduced scope of unneeded members and convert them to local
variables, or remove them completely where possible.
Change-Id: Ib402393c12d8effd162514bc19b6710f1c5240be
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AsyncTaskDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ClusterDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsCpuStatisticsDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsNumaNodeDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsSpmIdMapDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmNumaNodeDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStaticDaoTest.java
9 files changed, 25 insertions(+), 62 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63180
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib402393c12d8effd162514bc19b6710f1c5240be
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[master]: core: RepoFileMetaDataDaoTest duplicate key insert
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: RepoFileMetaDataDaoTest duplicate key insert
......................................................................
core: RepoFileMetaDataDaoTest duplicate key insert
Use the ExpectedException @Rule to fail testPrimaryKeyValidation() if
the first insert throws an exception and ONLY pass if the second insert
throws this exception.
Change-Id: I1df18ad9e320895e745b4dbd3eafe6eee86f79d0
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/RepoFileMetaDataDaoTest.java
1 file changed, 8 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63186
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1df18ad9e320895e745b4dbd3eafe6eee86f79d0
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[master]: core: DAO tests static method access
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: DAO tests static method access
......................................................................
core: DAO tests static method access
Clean up code to correctly access static test methods.
Change-Id: Ia40fe2ee529718952ffbba5902f052ed298cc86c
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDynamicDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDaoTest.java
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63184
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia40fe2ee529718952ffbba5902f052ed298cc86c
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months