Change in ovirt-engine[master]: core: DAO tests collections
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: DAO tests collections
......................................................................
core: DAO tests collections
Use Collections.singletonList instead of Arrays.asList for single-item
lists to improve performance.
Change-Id: Id148cff67353b0cdadb156f3e8c2ed8d682d8be9
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbUserDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/EngineSessionDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/JobDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageServerConnectionDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmAndTemplatesGenerationsDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStaticDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmTemplateDaoTest.java
10 files changed, 24 insertions(+), 26 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63183
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id148cff67353b0cdadb156f3e8c2ed8d682d8be9
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[master]: core: DbUserDaoTest TODO
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: DbUserDaoTest TODO
......................................................................
core: DbUserDaoTest TODO
Remove a useless TODO comment
Change-Id: Id54f0b7537c5ec3cc278af59505b7716024730d6
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbUserDaoTest.java
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63182
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id54f0b7537c5ec3cc278af59505b7716024730d6
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[master]: core: BaseDao method modifiers
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: BaseDao method modifiers
......................................................................
core: BaseDao method modifiers
Removed the pointless final modifiers from the class' static methods.
Change-Id: I94c99c82462904c0a977b3db0fcf46499d3405b3
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BaseDao.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63160
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I94c99c82462904c0a977b3db0fcf46499d3405b3
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[master]: core: DaoCdiIntegrationTest raw types
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: DaoCdiIntegrationTest raw types
......................................................................
core: DaoCdiIntegrationTest raw types
Solve annoying raw types warnings.
Change-Id: Icf0419813b06f33899e534f898e2c3ebbbcdb5b3
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DaoCdiIntegrationTest.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63181
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icf0419813b06f33899e534f898e2c3ebbbcdb5b3
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in jenkins[master]: Add recipients list to failure email in check closure jobs
by eedri＠redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: Add recipients list to failure email in check closure jobs
......................................................................
Add recipients list to failure email in check closure jobs
Change-Id: I3413b1ddf43f27eece642ca9cdab01fa089342e4
Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com>
---
M jobs/confs/yaml/templates/repos-check-closure.yaml
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Sharon Naftaly: Verified; Ready for review
Eyal Edri: Looks good to me; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63245
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3413b1ddf43f27eece642ca9cdab01fa089342e4
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[ovirt-engine-4.0]: restapi: Add API for import of VMs from external providers
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Add API for import of VMs from external providers
......................................................................
restapi: Add API for import of VMs from external providers
Added /externalvmimports endpoint that can be used to import VMs from external
providers, such as XEN, KVM or VMware.
Change-Id: I1569faab4c52268f2405f49edea51dbe721adb7c
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1346847
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandBase.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmFromExternalUrlCommand.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImportVmFromExternalUrlParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendExternalVmImportsResource.java
A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendExternalVmImportsResourceTest.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
11 files changed, 710 insertions(+), 6 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Martin Betak: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/63145
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1569faab4c52268f2405f49edea51dbe721adb7c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[ovirt-engine-4.0.4]: core: Always fix VMs status during fencing if host if off
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Always fix VMs status during fencing if host if off
......................................................................
core: Always fix VMs status during fencing if host if off
Always fix VMs status during fencing flow when host is off (detected by
power management status command) and don't rely on successful execution
of power management start of the host.
Change-Id: I439d5a323092978a6cd58ceef93aa7f340e6dcf6
Bug-Url: https://bugzilla.redhat.com/1367557
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/RestartVdsCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Martin Peřina: Verified
Eli Mesika: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/63227
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I439d5a323092978a6cd58ceef93aa7f340e6dcf6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.4
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[ovirt-engine-4.0.4]: core: Fix upgrade issue
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix upgrade issue
......................................................................
core: Fix upgrade issue
Fixes upgrade issue by copying original
03_06_1790_add_vm_auto_login_column_to_user_profiles_table.sql (which
was by mistake not backported into ovirt-engine-3.6 branch during 3.6
version development) into
04_00_0880_add_vm_auto_login_column_to_user_profiles_table.sql. This
will fix the issue for upgrade from 3.6 to 4.0.
Change-Id: I2e7f13a7a30aefde903c30ad5453201e53fe80e9
Bug-Url: https://bugzilla.redhat.com/1371515
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
A packaging/dbscripts/upgrade/04_00_0880_add_vm_auto_login_column_to_user_profiles_table.sql
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Martin Peřina: Verified
Eli Mesika: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/63202
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e7f13a7a30aefde903c30ad5453201e53fe80e9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.4
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[ovirt-engine-4.0]: core: Fix upgrade issue
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix upgrade issue
......................................................................
core: Fix upgrade issue
Fixes upgrade issue by copying original
03_06_1790_add_vm_auto_login_column_to_user_profiles_table.sql (which
was by mistake not backported into ovirt-engine-3.6 branch during 3.6
version development) into
04_00_0880_add_vm_auto_login_column_to_user_profiles_table.sql. This
will fix the issue for upgrade from 3.6 to 4.0.
Change-Id: I2e7f13a7a30aefde903c30ad5453201e53fe80e9
Bug-Url: https://bugzilla.redhat.com/1371515
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
A packaging/dbscripts/upgrade/04_00_0880_add_vm_auto_login_column_to_user_profiles_table.sql
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Martin Peřina: Verified
Eli Mesika: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/63201
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e7f13a7a30aefde903c30ad5453201e53fe80e9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[ovirt-engine-4.0]: core: Always fix VMs status during fencing if host if off
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Always fix VMs status during fencing if host if off
......................................................................
core: Always fix VMs status during fencing if host if off
Always fix VMs status during fencing flow when host is off (detected by
power management status command) and don't rely on successful execution
of power management start of the host.
Change-Id: I439d5a323092978a6cd58ceef93aa7f340e6dcf6
Bug-Url: https://bugzilla.redhat.com/1367557
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/RestartVdsCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Martin Peřina: Verified
Eli Mesika: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/63226
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I439d5a323092978a6cd58ceef93aa7f340e6dcf6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months