Change in ovirt-hosted-engine-ha[v2.0.z]: jsonrpc: safely parsing empty responses
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: jsonrpc: safely parsing empty responses
......................................................................
jsonrpc: safely parsing empty responses
jsonrpc responces dictionary doesn't contain the 'items'
key if there is no value to pass.
Correctly handling it.
Change-Id: I135b20ab22f2ffd55059f6992f27dc75e64a2501
Bug-Url: https://bugzilla.redhat.com/1365242
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
(cherry picked from commit 20e60aaa8ecf32736cebddc99d1294d33aafd55c)
---
M ovirt_hosted_engine_ha/lib/image.py
M ovirt_hosted_engine_ha/lib/ovf/ovf_store.py
M ovirt_hosted_engine_ha/lib/storage_server.py
M ovirt_hosted_engine_ha/lib/upgrade.py
4 files changed, 26 insertions(+), 18 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63001
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I135b20ab22f2ffd55059f6992f27dc75e64a2501
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: v2.0.z
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-hosted-engine-setup[master]: console: use virsh with SASL auth
by stirabos＠redhat.com
Simone Tiraboschi has submitted this change and it was merged.
Change subject: console: use virsh with SASL auth
......................................................................
console: use virsh with SASL auth
Using virsh with SASL auth instead of TLS one
since it was causing auth issues on redeployment
on dirty hosts.
Change-Id: I73340250134bd24672cc91362d25cc3605b111ba
Bug-Url: https://bugzilla.redhat.com/1333449
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M ovirt-hosted-engine-setup.spec.in
M src/bin/hosted-engine.in
2 files changed, 21 insertions(+), 6 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Simone Tiraboschi: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Rafael Martins: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/63091
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I73340250134bd24672cc91362d25cc3605b111ba
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-hosted-engine-setup[master]: packaging: bumping requirements
by stirabos＠redhat.com
Simone Tiraboschi has submitted this change and it was merged.
Change subject: packaging: bumping requirements
......................................................................
packaging: bumping requirements
Change-Id: If71afa9357c79d70526737a01d46b25fc55f9a5e
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M ovirt-hosted-engine-setup.spec.in
1 file changed, 8 insertions(+), 8 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
Rafael Martins: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/63134
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If71afa9357c79d70526737a01d46b25fc55f9a5e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-hosted-engine-setup[master]: console: avoid assuming remote-viewer in instructions
by stirabos＠redhat.com
Simone Tiraboschi has submitted this change and it was merged.
Change subject: console: avoid assuming remote-viewer in instructions
......................................................................
console: avoid assuming remote-viewer in instructions
Provide console connection instructions not based on a local
remote-viewer.
Bug-Url: https://bugzilla.redhat.com/1333449
Depends-On: https://gerrit.ovirt.org/61697/
Change-Id: I3eca5eaaf6d4fe3021462ff45b152cd21741c110
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/ovirt_hosted_engine_setup/mixins.py
M src/plugins/gr-he-setup/vm/runvm.py
2 files changed, 26 insertions(+), 29 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Simone Tiraboschi: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63036
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3eca5eaaf6d4fe3021462ff45b152cd21741c110
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: restapi: remove fop dependency
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: remove fop dependency
......................................................................
restapi: remove fop dependency
remove requirement for fop, as removed the save as
pdf option for gluster profile statistics.
Change-Id: I30777af707928bc6261733dd37de084661fcbaae
Bug-Url: https://bugzilla.redhat.com/1362472
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M backend/manager/dependencies/common/pom.xml
D backend/manager/dependencies/common/src/main/modules/org/apache/avalon/framework/main/module.xml
D backend/manager/dependencies/common/src/main/modules/org/apache/xmlgraphics/batik/main/module.xml
D backend/manager/dependencies/common/src/main/modules/org/apache/xmlgraphics/commons/main/module.xml
D backend/manager/dependencies/common/src/main/modules/org/apache/xmlgraphics/fop/main/module.xml
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/ApiMediaType.java
M backend/manager/modules/restapi/jaxrs/pom.xml
D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/pdf/FOPMessageBodyWriter.java
M backend/manager/modules/restapi/jaxrs/src/main/modules/org/ovirt/engine/api/restapi-jaxrs/main/module.xml
M backend/manager/modules/restapi/jaxrs/src/main/resources/META-INF/services/javax.ws.rs.ext.Providers
D backend/manager/modules/restapi/jaxrs/src/main/resources/pdf/GlusterVolumeProfileDetails.xsl
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeProfileStatisticsModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeProfileStatisticsPopupView.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties
M ovirt-engine.spec.in
M pom.xml
17 files changed, 4 insertions(+), 749 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Peřina: Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Sahina Bose: Verified
--
To view, visit https://gerrit.ovirt.org/62589
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I30777af707928bc6261733dd37de084661fcbaae
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-hosted-engine-ha[v2.0.z]: automation: add Virt SIG ovirt repos
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: automation: add Virt SIG ovirt repos
......................................................................
automation: add Virt SIG ovirt repos
Added CentOS Virt SIG repos to all EL7 jobs.
This includes an updated python-pep8 that should solve
the pep8 error reported by check jobs.
Change-Id: I29df18abd4d8a6338857c3b545b25d157e68368d
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
(cherry picked from commit 8ed244f648054c5d1f84e545660e5d916800a2ff)
---
M automation/build-artifacts.repos.el7
D automation/check-merged.repos.el7
A automation/check-merged.repos.el7
D automation/check-patch.repos.el7
A automation/check-patch.repos.el7
5 files changed, 6 insertions(+), 12 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63199
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I29df18abd4d8a6338857c3b545b25d157e68368d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: v2.0.z
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-hosted-engine-ha[master]: automation: add Virt SIG ovirt repos
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: automation: add Virt SIG ovirt repos
......................................................................
automation: add Virt SIG ovirt repos
Added CentOS Virt SIG repos to all EL7 jobs.
This includes an updated python-pep8 that should solve
the pep8 error reported by check jobs.
Change-Id: I29df18abd4d8a6338857c3b545b25d157e68368d
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M automation/build-artifacts.repos.el7
A automation/check-merged.repos.el7
A automation/check-patch.repos.el7
3 files changed, 3 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63196
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I29df18abd4d8a6338857c3b545b25d157e68368d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine-sdk[sdk_4.0]: Fix tag names of action parameters
by omachace＠redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Fix tag names of action parameters
......................................................................
Fix tag names of action parameters
Currently when the SDK generates the XML document to invoke an action
method it assumes that the names of the elements inside the 'action'
match the names of the types of the parameters. This isn't correct, they
should match the names of the parameters, not the names of the types.
For example, the 'Host.iscsi_discover' action method has a parameter of
type 'IscsiDetails' and name 'iscsi', so the tag should be 'iscsi', not
'iscsi_details'. To solve this issue this patch chages the SDK so that
the implementation of action methods create an instance of the 'Action'
type, and render it uusing the 'ActionWriter' class, which knows how to
write it correctly.
Change-Id: Icc05fc5791d6d8ecd2e6c22a6c1aaab96a843b98
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 549d654c91f468adda70640301dd1372e0ce9eab)
---
M generator/src/main/java/org/ovirt/sdk/python/ServicesGenerator.java
1 file changed, 11 insertions(+), 52 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63191
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc05fc5791d6d8ecd2e6c22a6c1aaab96a843b98
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine-sdk[master]: Fix tag names of action parameters
by omachace＠redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Fix tag names of action parameters
......................................................................
Fix tag names of action parameters
Currently when the SDK generates the XML document to invoke an action
method it assumes that the names of the elements inside the 'action'
match the names of the types of the parameters. This isn't correct, they
should match the names of the parameters, not the names of the types.
For example, the 'Host.iscsi_discover' action method has a parameter of
type 'IscsiDetails' and name 'iscsi', so the tag should be 'iscsi', not
'iscsi_details'. To solve this issue this patch chages the SDK so that
the implementation of action methods create an instance of the 'Action'
type, and render it uusing the 'ActionWriter' class, which knows how to
write it correctly.
Change-Id: Icc05fc5791d6d8ecd2e6c22a6c1aaab96a843b98
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M generator/src/main/java/org/ovirt/sdk/python/ServicesGenerator.java
1 file changed, 11 insertions(+), 52 deletions(-)
Approvals:
Ondra Machacek: Looks good to me, approved
Juan Hernandez: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63189
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc05fc5791d6d8ecd2e6c22a6c1aaab96a843b98
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in jenkins[master]: splitting mom created and merged projects in yaml
by eedri＠redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: splitting mom created and merged projects in yaml
......................................................................
splitting mom created and merged projects in yaml
Until recently there was no reason
to split the created and merged jobs
for mom since they share the same values.
Recently we introduced the deploy to
experimental job which takes rpms and
deploys it to a test repo.
This should only take merged rpms
and not run on created jobs.
This patch splits between created
and merged jobs so only merged
will be deployed.
Note about std ci: I didn't invest
in making a common project for both
since this code is due to be replaced
with standard ci soon.
Change-Id: Ia8050dc82e8be0ccf347a0d733178bf165439f6a
Signed-off-by: Eyal Edri <eedri(a)redhat.com>
---
M jobs/confs/projects/mom/mom_create-rpms.yaml
1 file changed, 33 insertions(+), 2 deletions(-)
Approvals:
Eyal Edri: Verified; Looks good to me; Passed CI tests; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63152
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia8050dc82e8be0ccf347a0d733178bf165439f6a
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months