January 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Remove unused UpdateVmCommandTest members
by Code Review 22 Jan '17

22 Jan '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused UpdateVmCommandTest members ...................................................................... core: Remove unused UpdateVmCommandTest members Change-Id: I898574e849916c511f3549d501283f5c23773c7d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java 1 file changed, 0 insertions(+), 25 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/70261 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I898574e849916c511f3549d501283f5c23773c7d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: UpdateVmCommandTest#assertValidateMessage
by Code Review 22 Jan '17

22 Jan '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: UpdateVmCommandTest#assertValidateMessage ...................................................................... core: UpdateVmCommandTest#assertValidateMessage Use ValidateTestUtils instead of reimplementing its logic. Change-Id: I147bf685e2d8363de7f16e710888e6a4f1bcaf12 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java 1 file changed, 8 insertions(+), 25 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/70260 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I147bf685e2d8363de7f16e710888e6a4f1bcaf12 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CommonVmPoolCommandTestAbstract domain mocks
by Code Review 22 Jan '17

22 Jan '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: CommonVmPoolCommandTestAbstract domain mocks ...................................................................... core: CommonVmPoolCommandTestAbstract domain mocks The mockFirstStorageDomain and mockSecondStorageDomain methods differ only by the storage domain's ID. This patch consolidates both methods and converts the storage domain ID to a parameter. Change-Id: Ic17c2bdf68ef050bb505953478e51bfcf7605a73 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommonVmPoolCommandTestAbstract.java 1 file changed, 5 insertions(+), 13 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/70259 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic17c2bdf68ef050bb505953478e51bfcf7605a73 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AbstractGetStorageDomainsWithAttachedStoragePoolGuidQu...
by Code Review 22 Jan '17

22 Jan '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: AbstractGetStorageDomainsWithAttachedStoragePoolGuidQueryTestCase ...................................................................... core: AbstractGetStorageDomainsWithAttachedStoragePoolGuidQueryTestCase Extract a common base class, AbstractGetStorageDomainsWithAttachedStoragePoolGuidQueryTestCase to hold the shared logic from GetBlockStorageDomainsWithAttachedStoragePoolGuidQueryTest, GetFileStorageDomainsWithAttachedStoragePoolGuidQueryTest and GetStorageDomainsWithAttachedStoragePoolGuidQueryTest. Change-Id: I7cbdb468229c284e498b8c790683ee0f10548c2d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/AbstractGetStorageDomainsWithAttachedStoragePoolGuidQueryTestCase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/GetBlockStorageDomainsWithAttachedStoragePoolGuidQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/GetFileStorageDomainsWithAttachedStoragePoolGuidQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/GetStorageDomainsWithAttachedStoragePoolGuidQueryTest.java 4 files changed, 172 insertions(+), 375 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/70251 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7cbdb468229c284e498b8c790683ee0f10548c2d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: FrontendActionTest generics
by Code Review 22 Jan '17

22 Jan '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: FrontendActionTest generics ...................................................................... webadmin: FrontendActionTest generics Change-Id: I404576ad39753665e507a7ba39d7acf35ef24f4c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/FrontendActionTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Vojtech Szocs: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/70285 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I404576ad39753665e507a7ba39d7acf35ef24f4c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Remove FrontendActionTest unused mocks
by Code Review 22 Jan '17

22 Jan '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Remove FrontendActionTest unused mocks ...................................................................... webadmin: Remove FrontendActionTest unused mocks Change-Id: I2b3b564a715a5c06bc4bdc5b873ed852082e3952 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/FrontendActionTest.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Vojtech Szocs: Looks good to me, but someone else must approve Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/70283 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b3b564a715a5c06bc4bdc5b873ed852082e3952 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: FrontendActionTest constants
by Code Review 22 Jan '17

22 Jan '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: FrontendActionTest constants ...................................................................... webadmin: FrontendActionTest constants Make constants private static final, as per Java's coding conventions. Change-Id: Iedf4644883279282fa697034725a3f65836599c8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/FrontendActionTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Vojtech Szocs: Looks good to me, but someone else must approve Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/70284 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iedf4644883279282fa697034725a3f65836599c8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: RestoreAllSnapshotCommandTest collections
by Code Review 22 Jan '17

22 Jan '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: RestoreAllSnapshotCommandTest collections ...................................................................... core: RestoreAllSnapshotCommandTest collections Use the more efficient Collections.singletonList instead of the general purpose ArrayList. Change-Id: I7ea9d54174eea3d96bffb9246e0a452e17ac906d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/RestoreAllSnapshotsCommandTest.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/70255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ea9d54174eea3d96bffb9246e0a452e17ac906d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Removed CidrValidationTest unused mockings
by Code Review 22 Jan '17

22 Jan '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Removed CidrValidationTest unused mockings ...................................................................... webadmin: Removed CidrValidationTest unused mockings Change-Id: Ia2c946ddcdc36da332a5a6ffdb36c8d95e6af4d7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/CidrValidationTest.java 1 file changed, 0 insertions(+), 10 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Vojtech Szocs: Looks good to me, but someone else must approve Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/70286 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia2c946ddcdc36da332a5a6ffdb36c8d95e6af4d7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: AbstractGwtDynamicHostPageServletTest mocking
by Code Review 22 Jan '17

22 Jan '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: AbstractGwtDynamicHostPageServletTest mocking ...................................................................... webadmin: AbstractGwtDynamicHostPageServletTest mocking Removed redundant mockings that do not affect the test, and just make it harder to read or understand. Change-Id: I23e36dfe6d216332fb0eb35fbe3cad0185fac662 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/AbstractGwtDynamicHostPageServletTest.java 1 file changed, 0 insertions(+), 18 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/70282 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I23e36dfe6d216332fb0eb35fbe3cad0185fac662 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0