Change in ovirt-engine[master]: webadmin: Remove unused ClientStorageImplTest mockings
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: webadmin: Remove unused ClientStorageImplTest mockings
......................................................................
webadmin: Remove unused ClientStorageImplTest mockings
Change-Id: I49485e7a8918ede07a9f502f8cc022b475d2c659
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/test/java/org/ovirt/engine/ui/common/system/ClientStorageImplTest.java
1 file changed, 0 insertions(+), 3 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
Vojtech Szocs: Looks good to me, but someone else must approve
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/70287
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I49485e7a8918ede07a9f502f8cc022b475d2c659
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[ovirt-engine-4.1]: core: UpdateVmTemplate doesn't load disks
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: UpdateVmTemplate doesn't load disks
......................................................................
core: UpdateVmTemplate doesn't load disks
UpdateVmTemplate command doesn't load disks of old template.
This patch fixes problem of failing validation caused by
`vmTemplateHandler.isUpdateValid()` returning false since
VmTemplate#actualDiskSize seemed to be changed (greater than zero for
old template with loaded disks and zero for new template) and missing
annotation allowing the change.
Change-Id: Ib1f32fe2fc61a425313a331849854ae9feaecf64
Bug-Url: https://bugzilla.redhat.com/1409579
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java
1 file changed, 0 insertions(+), 4 deletions(-)
Approvals:
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/70784
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1f32fe2fc61a425313a331849854ae9feaecf64
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: core: Max memory validation in import commands
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: Max memory validation in import commands
......................................................................
core: Max memory validation in import commands
VmBase#maxMemorySizeMb is validated in import commands since
VMs/Templates may come from unreliable source and the value may be
invalid/missing.
Change-Id: I22fa4b0252e8bed8eb88e87a54903af25ce2e28c
Bug-Url: https://bugzilla.redhat.com/1410606
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmFromExternalProviderCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommand.java
3 files changed, 12 insertions(+), 0 deletions(-)
Approvals:
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/69741
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I22fa4b0252e8bed8eb88e87a54903af25ce2e28c
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: core: UpdateVmTemplate doesn't load disks
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: UpdateVmTemplate doesn't load disks
......................................................................
core: UpdateVmTemplate doesn't load disks
UpdateVmTemplate command doesn't load disks of old template.
This patch fixes problem of failing validation caused by
`vmTemplateHandler.isUpdateValid()` returning false since
VmTemplate#actualDiskSize seemed to be changed (greater than zero for
old template with loaded disks and zero for new template) and missing
annotation allowing the change.
Change-Id: Ib1f32fe2fc61a425313a331849854ae9feaecf64
Bug-Url: https://bugzilla.redhat.com/1409579
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java
1 file changed, 0 insertions(+), 4 deletions(-)
Approvals:
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/70785
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1f32fe2fc61a425313a331849854ae9feaecf64
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: core: Handling of missing maxMemory unified
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: Handling of missing maxMemory unified
......................................................................
core: Handling of missing maxMemory unified
VmHandler#updateMaxMemorySize handles all settings of potentially
missing value of VmBase#maxMemorySizeMb at following places:
* ImportVmCommand (newly added)
* ImportVmFromExternalProviderCommand
* ImportVmTemplateCommand
* SnapshotsManager
Change-Id: Ic884a696f1b7e44b43286f2f6871d2803ae8c362
Bug-Url: https://bugzilla.redhat.com/1410606
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportUtils.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmFromExternalProviderCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommandTest.java
8 files changed, 44 insertions(+), 25 deletions(-)
Approvals:
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/69742
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic884a696f1b7e44b43286f2f6871d2803ae8c362
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: webadmin: Highlight path input in new domain popup when conn...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Highlight path input in new domain popup when connection exists
......................................................................
webadmin: Highlight path input in new domain popup when connection exists
When attempting to create a new file domain and the connection exists as
a part of an existing storage domain an error message appears, in that
case the path input should be highlighted as well to let the user know
which input needs to be fixed
Change-Id: I3b5258255b28ef5b7a8195664d1b66f409749ccf
Bug-Url: https://bugzilla.redhat.com/1414984
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Verified
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/70967
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3b5258255b28ef5b7a8195664d1b66f409749ccf
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: webadmin: Extract messages section from expander in new NFS ...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Extract messages section from expander in new NFS domain popup
......................................................................
webadmin: Extract messages section from expander in new NFS domain popup
The messages section was inside of the 'Custom Connection Parameters'
expander which was closed by default resulting in error messages not to be
shown unless the expander was open.
The section was moved out of the expander.
Change-Id: Ica61a3bf9eb540971ec74721038e59a26bd828f4
Bug-Url: https://bugzilla.redhat.com/1414984
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.ui.xml
1 file changed, 5 insertions(+), 5 deletions(-)
Approvals:
Tal Nisan: Verified
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/70957
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ica61a3bf9eb540971ec74721038e59a26bd828f4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in jenkins[master]: ovirt-wgt: Require newer nsis-simple-service-plugin
by Code Review
>From Barak Korren <bkorren(a)redhat.com>:
Barak Korren has submitted this change and it was merged.
Change subject: ovirt-wgt: Require newer nsis-simple-service-plugin
......................................................................
ovirt-wgt: Require newer nsis-simple-service-plugin
Which is required for nsis-3.01.
See also: https://gerrit.ovirt.org/70955
Change-Id: I104821ced16d17a355cb9d00f417b6e9f883d3b4
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M jobs/confs/projects/ovirt-wgt/ovirt-wgt_create-rpms.yaml
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Barak Korren: Verified; Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/70961
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I104821ced16d17a355cb9d00f417b6e9f883d3b4
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[ovirt-engine-4.1]: core: Set the qcow compat value on upload.
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Set the qcow compat value on upload.
......................................................................
core: Set the qcow compat value on upload.
Since the upload image runs over the qcow2 header, after the upload is
finished the compat should be updated.
Change-Id: Ib2375ac85cbdf1ef605e109e6aab10b84ad40fd0
Bug-Url: https://bugzilla.redhat.com/1413983
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferImageCommand.java
1 file changed, 19 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Maor Lipchuk: Verified
Liron Aravot: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/70822
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2375ac85cbdf1ef605e109e6aab10b84ad40fd0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-live[ovirt-live-4.1]: build: ovirt-live-4.1.0_rc2
by Code Review
>From Lev Veyde <lveyde(a)redhat.com>:
Lev Veyde has submitted this change and it was merged.
Change subject: build: ovirt-live-4.1.0_rc2
......................................................................
build: ovirt-live-4.1.0_rc2
Change-Id: Ia6f4bf5703412a891ea586a11dc2048d1667555d
Signed-off-by: Lev Veyde <lveyde(a)redhat.com>
---
M centos-7/Makefile
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Lev Veyde: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/70952
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6f4bf5703412a891ea586a11dc2048d1667555d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-live
Gerrit-Branch: ovirt-live-4.1
Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months