Change in jenkins[master]: experimental: append distro to repo path
by Code Review
>From Eyal Edri <eedri(a)redhat.com>:
Eyal Edri has submitted this change and it was merged.
Change subject: experimental: append distro to repo path
......................................................................
experimental: append distro to repo path
Currently we download all distros, this is unneeded.
This patch 'hijacks' the 'distro' parameter, which it seems was intended
to be used for defining the 'chroot' distro. This should work because
we use el7 chroot, which happens to be what the VMs inside OST use.
However, if in the future we will decide to use fc* VMs inside OST,
we'd probably need to define another distro parameter, in order not to
restrict ourselves to running in fc* chroots too.
Fixes: https://ovirt-jira.atlassian.net/browse/OST-17
Change-Id: Id5e2e59da10b48c7b38598605fb0e6c7648f691b
Signed-off-by: Nadav Goldin <ngoldin(a)redhat.com>
---
M jobs/confs/groovy-scripts/test-ovirt-repo.groovy
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Nadav Goldin: Verified
Eyal Edri: Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/70705
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id5e2e59da10b48c7b38598605fb0e6c7648f691b
Gerrit-PatchSet: 3
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gal Ben Haim <galbh2(a)gmail.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in jenkins[master]: enable repo closure for experimental by default
by Code Review
>From Eyal Edri <eedri(a)redhat.com>:
Eyal Edri has submitted this change and it was merged.
Change subject: enable repo closure for experimental by default
......................................................................
enable repo closure for experimental by default
Change-Id: Ic15707d736195a8df7f5cd11e382766a82d0e78b
Signed-off-by: Eyal Edri <eedri(a)redhat.com>
---
M jobs/confs/yaml/templates/repos-check-closure.yaml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Eyal Edri: Verified; Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/70100
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic15707d736195a8df7f5cd11e382766a82d0e78b
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[ovirt-engine-4.1]: gluster: fix option listing issue in set options
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: gluster: fix option listing issue in set options
......................................................................
gluster: fix option listing issue in set options
We were using a Combo box but it is not working
as expected. Instead of Combo box, I moved this to
ListModelTypeAheadChangeableListBoxEditor
Change-Id: I09314f09096fb4be9cd81f63a456d1f1b0a45fdf
Bug-Url: https://bugzilla.redhat.com/1408803
Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com>
(cherry picked from commit f12f8509c639fb88836188630ad1071b5cf9a7b4)
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeParameterListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeParameterModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeParameterPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeParameterPopupView.ui.xml
4 files changed, 102 insertions(+), 121 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Sahina Bose: Looks good to me, approved
Ramesh N: Verified
--
To view, visit https://gerrit.ovirt.org/70720
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I09314f09096fb4be9cd81f63a456d1f1b0a45fdf
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in jenkins[master]: ovirt-engine-nodejs: add build jobs for 4.1
by Code Review
>From Eyal Edri <eedri(a)redhat.com>:
Eyal Edri has submitted this change and it was merged.
Change subject: ovirt-engine-nodejs: add build jobs for 4.1
......................................................................
ovirt-engine-nodejs: add build jobs for 4.1
Change-Id: Iccad6967ffea3dc0f868be131079e16e597a2068
Signed-off-by: Daniel Belenky <dbelenky(a)redhat.com>
---
M jobs/confs/projects/ovirt-engine-nodejs/ovirt-engine-nodejs.yaml
1 file changed, 7 insertions(+), 0 deletions(-)
Approvals:
Eyal Edri: Looks good to me, approved; Ready for merge
Daniel Belenky: Verified; Ready for review
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/70798
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iccad6967ffea3dc0f868be131079e16e597a2068
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: core: Set the qcow compat value on upload.
by Code Review
>From Maor Lipchuk <mlipchuk(a)redhat.com>:
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Set the qcow compat value on upload.
......................................................................
core: Set the qcow compat value on upload.
Since the upload image runs over the qcow2 header, after the upload is
finished the compat should be updated.
Change-Id: Ib2375ac85cbdf1ef605e109e6aab10b84ad40fd0
Bug-Url: https://bugzilla.redhat.com/1413983
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferImageCommand.java
1 file changed, 19 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Maor Lipchuk: Verified
Liron Aravot: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/70751
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2375ac85cbdf1ef605e109e6aab10b84ad40fd0
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[ovirt-engine-4.1]: packaging: Configure hosts for metrics: cleanups
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: packaging: Configure hosts for metrics: cleanups
......................................................................
packaging: Configure hosts for metrics: cleanups
Remove some unneeded vars
Remove netlink plugin, we use interface instead
Replace hard-coded ovirt_collectd in fluentd with a parameter
Put write_http after read and conf
Remove order from templates, it matters only on dest host
Fix order of conf files in fluentd
Change-Id: Ib03386b8f2bbffa57afcd5fd98d9a99ca9784941
Bug-Url: https://bugzilla.redhat.com/1405813
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/ansible/group_vars/all.yml
M packaging/setup/ansible/roles/fluentd/defaults/main.yml
M packaging/setup/ansible/roles/ovirt_collectd/ovirt_host/tasks/main.yml
R packaging/setup/ansible/roles/ovirt_collectd/ovirt_host/templates/builtins-conf-for-ovirt.conf.j2
M packaging/setup/ansible/roles/ovirt_collectd/read_statsd/tasks/main.yml
R packaging/setup/ansible/roles/ovirt_collectd/read_statsd/templates/read-statsd.conf.j2
M packaging/setup/ansible/roles/ovirt_collectd/write_http/defaults/main.yml
M packaging/setup/ansible/roles/ovirt_collectd/write_http/tasks/main.yml
R packaging/setup/ansible/roles/ovirt_collectd/write_http/templates/write-http.conf.j2
M packaging/setup/ansible/roles/ovirt_fluentd/client/tasks/main.yml
M packaging/setup/ansible/roles/ovirt_fluentd/http_input/tasks/main.yml
M packaging/setup/ansible/roles/ovirt_fluentd/ovirt_host/tasks/main.yml
M packaging/setup/ansible/roles/ovirt_fluentd/ovirt_host/templates/ovirt-processing.conf
13 files changed, 34 insertions(+), 53 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/70812
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib03386b8f2bbffa57afcd5fd98d9a99ca9784941
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
7 years, 11 months
Change in ovirt-engine[master]: webadmin: make the storage target to LUN table sortable
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: make the storage target to LUN table sortable
......................................................................
webadmin: make the storage target to LUN table sortable
Make the Product ID column sortable by using the makeSortable()
and moving the ListModel items to a SortedListModel so it can
be used by the EntityModelCellTable#initModelSortHandler()
Change-Id: I921f3dcf8568ce3461702edd9aed00d72c88d464
Bug-Url: https://bugzilla.redhat.com/1305011
Signed-off-by: Benny Zlotnik <bzlotnik(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java
1 file changed, 37 insertions(+), 18 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Benny Zlotnik: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/70404
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I921f3dcf8568ce3461702edd9aed00d72c88d464
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[ovirt-engine-4.1]: core: StorageJobCallback - prevent NPE when there is no exec...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: StorageJobCallback - prevent NPE when there is no executing host
......................................................................
core: StorageJobCallback - prevent NPE when there is no executing host
When there is no executing host (may happen when hosts go no responsive
during the command execution for example), the StorageJobCallback may fail
with NPE when attempting to check the host status.
This patch prevents it, if there is no executing host the job status can
be considered as failed.
Change-Id: I394c6b6a88bee9ef58d25b4e7bd3e880685b9100
Bug-Url: https://bugzilla.redhat.com/1414675
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StorageJobCallback.java
1 file changed, 50 insertions(+), 43 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Freddy Rolland: Looks good to me, but someone else must approve
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/70806
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I394c6b6a88bee9ef58d25b4e7bd3e880685b9100
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: packaging: Configure hosts for metrics: cleanups
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: Configure hosts for metrics: cleanups
......................................................................
packaging: Configure hosts for metrics: cleanups
Remove some unneeded vars
Remove netlink plugin, we use interface instead
Replace hard-coded ovirt_collectd in fluentd with a parameter
Put write_http after read and conf
Remove order from templates, it matters only on dest host
Fix order of conf files in fluentd
Change-Id: Ib03386b8f2bbffa57afcd5fd98d9a99ca9784941
Bug-Url: https://bugzilla.redhat.com/1405813
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/ansible/group_vars/all.yml
M packaging/setup/ansible/roles/fluentd/defaults/main.yml
M packaging/setup/ansible/roles/ovirt_collectd/ovirt_host/tasks/main.yml
R packaging/setup/ansible/roles/ovirt_collectd/ovirt_host/templates/builtins-conf-for-ovirt.conf.j2
M packaging/setup/ansible/roles/ovirt_collectd/read_statsd/tasks/main.yml
R packaging/setup/ansible/roles/ovirt_collectd/read_statsd/templates/read-statsd.conf.j2
M packaging/setup/ansible/roles/ovirt_collectd/write_http/defaults/main.yml
M packaging/setup/ansible/roles/ovirt_collectd/write_http/tasks/main.yml
R packaging/setup/ansible/roles/ovirt_collectd/write_http/templates/write-http.conf.j2
M packaging/setup/ansible/roles/ovirt_fluentd/client/tasks/main.yml
M packaging/setup/ansible/roles/ovirt_fluentd/http_input/tasks/main.yml
M packaging/setup/ansible/roles/ovirt_fluentd/ovirt_host/tasks/main.yml
M packaging/setup/ansible/roles/ovirt_fluentd/ovirt_host/templates/ovirt-processing.conf
13 files changed, 34 insertions(+), 53 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/70799
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib03386b8f2bbffa57afcd5fd98d9a99ca9784941
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[ovirt-engine-4.1]: webadmin, userportal: Add makeSortable() to LUN columns
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin,userportal: Add makeSortable() to LUN columns
......................................................................
webadmin,userportal: Add makeSortable() to LUN columns
Just like in other Column classes, the no-arg makeSortable()
method is a convenience so that devs don't have to provide
Comparator each time they want to mark a column as sortable.
Change-Id: I7206969dc9d2d056fab8ef7db69e3a5563e6c928
Bug-Url: https://bugzilla.redhat.com/1305011
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractLunAvailableSizeColumn.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractLunTextColumn.java
2 files changed, 29 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/70815
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7206969dc9d2d056fab8ef7db69e3a5563e6c928
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
7 years, 11 months