January 2017 - Engine-commits - oVirt List Archives

Change in ovirt-release[ovirt-4.1]: node: add libvirt-tls to the firewalld config
by Code Review 18 Jan '17

18 Jan '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: node: add libvirt-tls to the firewalld config ...................................................................... node: add libvirt-tls to the firewalld config TLS is used for migration. We need to enable libvirt-tls in order for this to work Change-Id: I435f74a2364dd357fa360b90715c6851b1e71585 Signed-off-by: Ryan Barry <rbarry(a)redhat.com> (cherry picked from commit e2d493a5f5e3be5e9446c6d04ccdad4c45e319d7) --- M ovirt-release41.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70749 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I435f74a2364dd357fa360b90715c6851b1e71585 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-4.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-4.1]: node: Add IQN randomization
by Code Review 18 Jan '17

18 Jan '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: node: Add IQN randomization ...................................................................... node: Add IQN randomization Enable the new imgbsae-generate-iqn.service to generate a random IQN name if none is defined. Change-Id: I92a7e586de5bbd02a722ea8da4ef1aac330b490b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1393661 Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org> (cherry picked from commit 359e996461de915d5fa2aefaabf52fb02327ba03) --- M ovirt-release41.spec.in 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Ryan Barry: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/70748 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92a7e586de5bbd02a722ea8da4ef1aac330b490b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-4.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-4.1]: automation: fix repos for fedora consumption
by Code Review 18 Jan '17

18 Jan '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: automation: fix repos for fedora consumption ...................................................................... automation: fix repos for fedora consumption recent changes in jenkins now run check-patch on both fedora and centos. Added diffrentiated repos for the 2 distributions. Change-Id: Ic23b046f2a4b5eb1a3e8652e7d74d403ee7bda8c Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit bbaee6ae92024e73ddab3a7e8619babd77500028) --- M automation/check-patch.repos.fc24 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70747 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic23b046f2a4b5eb1a3e8652e7d74d403ee7bda8c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-4.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in gerrit-admin[master]: Fix get_maj_version function
by Code Review 18 Jan '17

18 Jan '17

>From Shlomo Ben David <sbendavi(a)redhat.com>: Shlomo Ben David has submitted this change and it was merged. Change subject: Fix get_maj_version function ...................................................................... Fix get_maj_version function The current function handled only target milestones with the following convention: ovirt-<version> Added a fix to handle target milestone with the following convention as well: ovirt-<version>-[beta|alpha|rc] Example: ovirt-4.1.0-beta Change-Id: Ic505dddb756e3c18797cc6ed38be87dbdd7f1a47 Fixes: OVIRT-1046 Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com> --- M hooks/custom_hooks/check_target_milestone 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Shlomo Ben David: Verified; Looks good to me, approved Gil Shinar: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70752 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic505dddb756e3c18797cc6ed38be87dbdd7f1a47 Gerrit-PatchSet: 1 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in ovirt-engine[master]: backend: log VDS command's name on failure
by Code Review 18 Jan '17

18 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: backend: log VDS command's name on failure ...................................................................... backend: log VDS command's name on failure The audit logs VDS_BROKER_COMMAND_FAILURE and IRS_BROKER_COMMAND_FAILURE don't include the failing command's name. This patch adds this name so that the logs will be more informative. Change-Id: Ie57912b295675810cc63f979f07634bde20c69bc Bug-Url: https://bugzilla.redhat.com/1345787 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerCommand.java 3 files changed, 4 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/70736 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie57912b295675810cc63f979f07634bde20c69bc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: engine: avoid PollVDSCommand to fail upon VDSNetworkException
by Code Review 18 Jan '17

18 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: engine: avoid PollVDSCommand to fail upon VDSNetworkException ...................................................................... engine: avoid PollVDSCommand to fail upon VDSNetworkException Change-Id: Ib2053529c995dac712f89bd1fb45c912b9cc35f3 Bug-Url: https://bugzilla.redhat.com/1408175 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> (cherry picked from commit 24d1bc97fffe6b853e3264f1363af4f93898d885) --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/PollVDSCommand.java 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, approved Jenkins CI: Passed CI tests Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/70737 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2053529c995dac712f89bd1fb45c912b9cc35f3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: engine: for bonds mode=4 setting default xmit_hash_policy
by Code Review 18 Jan '17

18 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: engine: for bonds mode=4 setting default xmit_hash_policy ...................................................................... engine: for bonds mode=4 setting default xmit_hash_policy On creating new bonds with mode=4 (Dynamic link aggregation (802.3ad)) trough the web UI, the xmit_hash_policy is set explicitly to the numeric value 2 (layer2+3). The value is set numerically to be consistent to vdsm, which reports values of bonding options numerically, instead of textual. Already available bonds with mode=4 without xmit_hash_policy=2 are not changed and reported as "custom" options in the web UI. The previously used default xmit_hash_policy=layer2 uses just hardware MAC addresses of source and destination to decide which slave of the bond is used to transmit. The new default xmit_hash_policy=layer2+3 additionally considers the layer 3 addresses, if available, and is still 802.3ad compliant. This policy is intended to provide a more balanced distribution of traffic than layer2 alone, especially in environments where a layer3 routing is required to reach most destinations. Change-Id: I5b6cb2dfe8f0b60a1e81aa4832bc8c10672f6bb8 Bug-Url: https://bugzilla.redhat.com/1397490 Signed-off-by: Dominik Holler <dholler(a)redhat.com> (cherry picked from commit fa2421f05a318c7667838280c5e29d39b823380d) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/BondMode.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java 4 files changed, 19 insertions(+), 2 deletions(-) Approvals: Marcin Mirecki: Looks good to me, but someone else must approve Dominik Holler: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/70723 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b6cb2dfe8f0b60a1e81aa4832bc8c10672f6bb8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Create default ctor for HttpLocationInfo
by Code Review 18 Jan '17

18 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Create default ctor for HttpLocationInfo ...................................................................... core: Create default ctor for HttpLocationInfo Create default ctor for HttpLocationInfo to allow json serialization and storage of the command in DB Bug-Url: https://bugzilla.redhat.com/1414288 Change-Id: I95a7647db9971b3b8a2a68db152994be50998c0d Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/HttpLocationInfo.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Piotr Kliczewski: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70746 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95a7647db9971b3b8a2a68db152994be50998c0d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Added CentOS-6 mirrors
by Code Review 18 Jan '17

18 Jan '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: Added CentOS-6 mirrors ...................................................................... Added CentOS-6 mirrors Also made GPG keys be auto imported for other distros Change-Id: I80dfe2c34315a642bc8a96049ed5f99786a67070 Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-575 Signed-off-by: Barak Korren <bkorren(a)redhat.com> --- M data/mirrors-reposync.conf M jobs/confs/projects/system/sync_mirrors.yaml M scripts/mirror_mgr.sh 3 files changed, 50 insertions(+), 0 deletions(-) Approvals: Eyal Edri: Looks good to me, approved; Ready for merge Barak Korren: Verified; Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/69431 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80dfe2c34315a642bc8a96049ed5f99786a67070 Gerrit-PatchSet: 6 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <david(a)dcaro.es> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Pavel Zhukov <pavel(a)zhukoff.net> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: improve the robusness of vm devices monitoring
by Code Review 18 Jan '17

18 Jan '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: improve the robusness of vm devices monitoring ...................................................................... core: improve the robusness of vm devices monitoring We should not add a device with no general type or device type. Before this patch, we generated a log but then a NPE occurred and the whole devices monitoring cycle was terminated - none of the devices was updated. This patch changes this so we will actually skip the invalid device and continue to process the valid devices. Change-Id: I74349fa53b9a23661924a66d4c20056e41cb3d08 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoring.java 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/70728 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74349fa53b9a23661924a66d4c20056e41cb3d08 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0