January 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core : Search based on negated fields with null values doesn...
by Code Review 17 Jan '17

17 Jan '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: core : Search based on negated fields with null values doesn't work properly ...................................................................... core : Search based on negated fields with null values doesn't work properly Search Queries with null values in columns do not work properly. Need to check for IS Null for the nullable column. Change-Id: Iae05bb8307f668c01242ff609d330195d5b9a22d Bug-Url: https://bugzilla.redhat.com/1252906 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java 2 files changed, 31 insertions(+), 25 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Ravi Nori: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/69945 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae05bb8307f668c01242ff609d330195d5b9a22d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[master]: build: moved java code version to 4.2.0
by Code Review 17 Jan '17

17 Jan '17

>From Shirly Radco <sradco(a)redhat.com>: Shirly Radco has submitted this change and it was merged. Change subject: build: moved java code version to 4.2.0 ...................................................................... build: moved java code version to 4.2.0 Change-Id: Id7267909e0a41c0fcf0bd495c52983107a31f361 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M etl_export/src/main/java/ovirt_engine_dwh/aggregationtodaily_4_2/AggregationToDaily.java M etl_export/src/main/java/ovirt_engine_dwh/aggregationtohourly_4_2/AggregationToHourly.java M etl_export/src/main/java/ovirt_engine_dwh/configurationsync_4_2/ConfigurationSync.java M etl_export/src/main/java/ovirt_engine_dwh/dailytimekeepingjob_4_2/DailyTimeKeepingJob.java M etl_export/src/main/java/ovirt_engine_dwh/deletetimekeepingjob_4_2/DeleteTimeKeepingJob.java M etl_export/src/main/java/ovirt_engine_dwh/historydelete_4_2/HistoryDelete.java M etl_export/src/main/java/ovirt_engine_dwh/historyetl_4_2/HistoryETL.java M etl_export/src/main/java/ovirt_engine_dwh/hostconfigcheck_4_2/HostConfigCheck.java M etl_export/src/main/java/ovirt_engine_dwh/hourlytimekeepingjob_4_2/HourlyTimeKeepingJob.java M etl_export/src/main/java/ovirt_engine_dwh/minimalversioncheck_4_2/MinimalVersionCheck.java M etl_export/src/main/java/ovirt_engine_dwh/osenumupdate_4_2/OsEnumUpdate.java M etl_export/src/main/java/ovirt_engine_dwh/parallelrun_4_2/ParallelRun.java M etl_export/src/main/java/ovirt_engine_dwh/samplerunjobs_4_2/SampleRunJobs.java M etl_export/src/main/java/ovirt_engine_dwh/sampletimekeepingjob_4_2/SampleTimeKeepingJob.java M etl_export/src/main/java/ovirt_engine_dwh/statisticssync_4_2/StatisticsSync.java M etl_export/src/main/java/ovirt_engine_dwh/validateinstallation_4_2/ValidateInstallation.java 16 files changed, 81 insertions(+), 81 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70658 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7267909e0a41c0fcf0bd495c52983107a31f361 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: engine: move assign new MAC to VmInterfaceManager.add method
by Code Review 17 Jan '17

17 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: engine: move assign new MAC to VmInterfaceManager.add method ...................................................................... engine: move assign new MAC to VmInterfaceManager.add method Change-Id: Icc8622850f56034437647d82b89285f0977af166 Bug-Url: https://bugzilla.redhat.com/1411780 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmFromConfigurationCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/VmInterfaceManagerTest.java 5 files changed, 22 insertions(+), 14 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/70644 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc8622850f56034437647d82b89285f0977af166 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: restapi: Update to model 4.1.28
by Code Review 17 Jan '17

17 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: restapi: Update to model 4.1.28 ...................................................................... restapi: Update to model 4.1.28 The only relevant change in this new version of the model is the following: * Add new `lease` attribute to virtual machines and templates. Change-Id: Ic6f38475b8b39e8143a908f25a96c3b68d037aab Related-To: https://bugzilla.redhat.com/1412230 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70649 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6f38475b8b39e8143a908f25a96c3b68d037aab Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Update to model 4.2.3
by Code Review 17 Jan '17

17 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: restapi: Update to model 4.2.3 ...................................................................... restapi: Update to model 4.2.3 The only relevant change in this new version of the model is the following: * Add new `lease` attribute to virtual machines and templates. Change-Id: Ic6f38475b8b39e8143a908f25a96c3b68d037aab Related-To: https://bugzilla.redhat.com/1412230 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70647 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6f38475b8b39e8143a908f25a96c3b68d037aab Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: default storage domain on VM import
by Code Review 17 Jan '17

17 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: default storage domain on VM import ...................................................................... webadmin: default storage domain on VM import When importing a VM from an export domain, each disk's destination storage domain is selected by default to be the first one that shows in the list. This patch changes this default selection to be the storage domain with the most free space of all the domains in the list, making a scenario where the default selection is a storage domain that has not enough space less possible. Change-Id: Iea988fea5de32b44353c526d2bfe119d3e13ab9c Bug-Url: https://bugzilla.redhat.com/1279407 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportDiskData.java 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/70641 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea988fea5de32b44353c526d2bfe119d3e13ab9c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Log when importing a VM with lease to DC with version ...
by Code Review 17 Jan '17

17 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Log when importing a VM with lease to DC with version lower than 4.1 ...................................................................... core: Log when importing a VM with lease to DC with version lower than 4.1 When importing a VM with an VM lease to a data center with compatibility version that does not support VM leases the VM will be imported without the lease and an audit log warning will be issued Change-Id: I00cbf7472c654150ce9e0b060c24c67b4ef8d901 Bug-Url: https://bugzilla.redhat.com/1413397 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 3 files changed, 14 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/70643 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00cbf7472c654150ce9e0b060c24c67b4ef8d901 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Block creation of VM leases in versions lower than 4.1
by Code Review 17 Jan '17

17 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Block creation of VM leases in versions lower than 4.1 ...................................................................... core: Block creation of VM leases in versions lower than 4.1 Change-Id: If6dcf925c9f2ff09c0300acc599059a218c030e5 Bug-Url: https://bugzilla.redhat.com/1413397 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 20 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/70642 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6dcf925c9f2ff09c0300acc599059a218c030e5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: dwh: Move to 4.1 branch
by Code Review 17 Jan '17

17 Jan '17

>From Anton Marchukov <amarchuk(a)redhat.com>: Anton Marchukov has submitted this change and it was merged. Change subject: dwh: Move to 4.1 branch ...................................................................... dwh: Move to 4.1 branch Change-Id: I4e5fe748cbb8f16cc2133d2d9c594e9d0047d9d3 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M jobs/confs/projects/ovirt-dwh/ovirt-dwh_standard.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-4.1.yaml 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Anton Marchukov: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70653 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e5fe748cbb8f16cc2133d2d9c594e9d0047d9d3 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Log when importing a VM with lease to DC with version ...
by Code Review 17 Jan '17

17 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Log when importing a VM with lease to DC with version lower than 4.1 ...................................................................... core: Log when importing a VM with lease to DC with version lower than 4.1 When importing a VM with an VM lease to a data center with compatibility version that does not support VM leases the VM will be imported without the lease and an audit log warning will be issued Change-Id: I00cbf7472c654150ce9e0b060c24c67b4ef8d901 Bug-Url: https://bugzilla.redhat.com/1413397 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 3 files changed, 14 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70592 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00cbf7472c654150ce9e0b060c24c67b4ef8d901 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0