January 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.1]: core: storage job - undetermined status failure
by Code Review 17 Jan '17

17 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: storage job - undetermined status failure ...................................................................... core: storage job - undetermined status failure This patch adds support to let the command immediately fail when the job status is unknown or couldn't be determined. That's useful in cases in which we can fail the operation safely without any risk. Change-Id: Ib8e710b3bbd5ce44e5fc2baa6c326adf70eaf827 Bug-Url: http://bugzilla.redhat.com/1409125 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StorageJobCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageJobCommand.java 2 files changed, 20 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/70549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8e710b3bbd5ce44e5fc2baa6c326adf70eaf827 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: StorageJobCallback - adding support for child commands
by Code Review 17 Jan '17

17 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: StorageJobCallback - adding support for child commands ...................................................................... core: StorageJobCallback - adding support for child commands This patch adds support to the StorageJobCallback for executing and monitoring child commands. In order to do so, the StorageJobCallback was modified to extend ChildCommandsCallbackBase (which provides the child commands monitoring support). This change is needed in order to add support for storage job fencing, which is supposed to be performed by child commands while polling storage job. Change-Id: I8fa37385bad0322de5ad07623e951be28284045a Bug-Url: http://bugzilla.redhat.com/1409125 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StorageJobCallback.java 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/70550 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8fa37385bad0322de5ad07623e951be28284045a Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: vdsbroker: adding UpdateVolumeVDSCommand
by Code Review 17 Jan '17

17 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: vdsbroker: adding UpdateVolumeVDSCommand ...................................................................... vdsbroker: adding UpdateVolumeVDSCommand Note that using this verb for setting the volume status to ILLEGAL should be performed with change I9794cb7ba1259791ed4c7d699fabdeae88b21cbf Change-Id: I8b580a4ece900a10451b2908251a95d2377f0993 Bug-Url: http://bugzilla.redhat.com/1409125 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/UpdateVolumeVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/UpdateVolumeVDSCommand.java 5 files changed, 135 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/70548 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b580a4ece900a10451b2908251a95d2377f0993 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: api: StepMapper - executionHost mapping
by Code Review 17 Jan '17

17 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: api: StepMapper - executionHost mapping ...................................................................... api: StepMapper - executionHost mapping This patch adds support to the StepMapper to map the Step executionHost property from the subject entity with the EXECUTION_HOST entity type (if present). Change-Id: I102c3cde11dbeb91772e99d1a3e26c1e30c5492b Bug-Url: https://bugzilla.redhat.com/1408841 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StepMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/StepMapperTest.java 2 files changed, 50 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/70546 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I102c3cde11dbeb91772e99d1a3e26c1e30c5492b Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: StorageJobs - adding support for job fencing
by Code Review 17 Jan '17

17 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: StorageJobs - adding support for job fencing ...................................................................... core: StorageJobs - adding support for job fencing This patch adds support for storage job fencing for entity polling commands in the StorageJobCallback. When a job possibly hasn't started yet, we can attempt to fence the job using the entity that may be used to poll the job status. Fencing the job means that the host that recieved it will fail when attempting to execute it. Fencing the jobb would usually be performed by executing an asynchronous fencing command on the entity the job is supposed to be performed on. Once the job was fenced, the entity poller in use should be able to determine the job status as failed. Change-Id: Iaf318884f0d9667d80eaff7f31bf4fdd39a6afb1 Bug-Url: http://bugzilla.redhat.com/1409125 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StorageJobCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/EntityPollingCommand.java 2 files changed, 23 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/70552 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf318884f0d9667d80eaff7f31bf4fdd39a6afb1 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: StorageJobs - persist whether the job started
by Code Review 17 Jan '17

17 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: StorageJobs - persist whether the job started ...................................................................... core: StorageJobs - persist whether the job started This patch modifies the StorageJobCallback to persist whether the storage job execution has started. This change is needed in order to determine whether it may be possible to fence the job or not (we can fence only jobs that didn't start). Change-Id: Iaa605e189e2e9597cdbca9e51940050b228451fc Bug-Url: http://bugzilla.redhat.com/1409125 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StorageJobCallback.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StorageJobCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/HostJobInfo.java 3 files changed, 27 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/70551 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa605e189e2e9597cdbca9e51940050b228451fc Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: adding support for fencing storage volume job
by Code Review 17 Jan '17

17 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: adding support for fencing storage volume job ...................................................................... core: adding support for fencing storage volume job This patch adds the infrastracture required to fence volume related jobs. In case the host the job was sent to becomes non responsive before the job was started, the engine may attempt to fence the operation using the volume the job was supposed was performed on. Fencing a volume job is done by incrementing the volume generation by a predefined interval using the FenceVolumeJob command. If the fencing operation succeeded, it'll be detect by the VdsmImagePoller on the next polling attempt of the StorageJobCallback. The next patch in the series adds use of the added infrastructure in the CopyData command. Change-Id: Ib51944d0ab3e16c837bb117589e8e22f9756b219 Bug-Url: http://bugzilla.redhat.com/1409125 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/FenceVolumeJobCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/VdsmImagePoller.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/FenceVolumeJobCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/StorageConstants.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 6 files changed, 82 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/70553 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib51944d0ab3e16c837bb117589e8e22f9756b219 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[ovirt-engine-dwh-4.1]: build: after build dwh for 4.1
by Code Review 17 Jan '17

17 Jan '17

>From Shirly Radco <sradco(a)redhat.com>: Shirly Radco has submitted this change and it was merged. Change subject: build: after build dwh for 4.1 ...................................................................... build: after build dwh for 4.1 Change-Id: Iad2c837dc1f51b379419fce60e729755fd42e09e Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70661 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad2c837dc1f51b379419fce60e729755fd42e09e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-4.1 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[ovirt-engine-dwh-4.1]: build: dwh build for 4.1
by Code Review 17 Jan '17

17 Jan '17

>From Shirly Radco <sradco(a)redhat.com>: Shirly Radco has submitted this change and it was merged. Change subject: build: dwh build for 4.1 ...................................................................... build: dwh build for 4.1 Added release notes. Change-Id: I2561e4e0b7de0bbaac63e14b6815358c9ffdec97 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M ovirt-engine-dwh.spec.in M version.mak 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70660 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2561e4e0b7de0bbaac63e14b6815358c9ffdec97 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-4.1 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ioprocess: add builds for 4.1 branch
by Code Review 17 Jan '17

17 Jan '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: ioprocess: add builds for 4.1 branch ...................................................................... ioprocess: add builds for 4.1 branch Change-Id: Ife71d40bf67c5731c9603175b84af4a9e012b30d Signed-off-by: Daniel Belenky <dbelenky(a)redhat.com> --- M jobs/confs/projects/ioprocess/ioprocess.yaml 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70563 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife71d40bf67c5731c9603175b84af4a9e012b30d Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gal Ben Haim <galbh2(a)gmail.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0