January 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: CopyData - use volume job fencing
by Code Review 17 Jan '17

17 Jan '17

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: core: CopyData - use volume job fencing ...................................................................... core: CopyData - use volume job fencing This patch adds usage of volume job fencing to the copy data command. In a case of lost communication with the host the copy_data job was sent to the engine will be able to fence the job using the destination volume it was supposed to be performed on. Change-Id: Icb3dc503db7116fa6269cbb3b368bbcba088ff84 Bug-Url: http://bugzilla.redhat.com/1409125 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyDataCommand.java 1 file changed, 20 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/69391 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb3dc503db7116fa6269cbb3b368bbcba088ff84 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: storage job - undetermined status failure
by Code Review 17 Jan '17

17 Jan '17

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: core: storage job - undetermined status failure ...................................................................... core: storage job - undetermined status failure This patch adds support to let the command immediately fail when the job status is unknown or couldn't be determined. That's useful in cases in which we can fail the operation safely without any risk. Change-Id: Ib8e710b3bbd5ce44e5fc2baa6c326adf70eaf827 Bug-Url: http://bugzilla.redhat.com/1409125 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StorageJobCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageJobCommand.java 2 files changed, 20 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/69386 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8e710b3bbd5ce44e5fc2baa6c326adf70eaf827 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: StorageJobCallback - adding support for child commands
by Code Review 17 Jan '17

17 Jan '17

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: core: StorageJobCallback - adding support for child commands ...................................................................... core: StorageJobCallback - adding support for child commands This patch adds support to the StorageJobCallback for executing and monitoring child commands. In order to do so, the StorageJobCallback was modified to extend ChildCommandsCallbackBase (which provides the child commands monitoring support). This change is needed in order to add support for storage job fencing, which is supposed to be performed by child commands while polling storage job. Change-Id: I8fa37385bad0322de5ad07623e951be28284045a Bug-Url: http://bugzilla.redhat.com/1409125 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StorageJobCallback.java 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/69387 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8fa37385bad0322de5ad07623e951be28284045a Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: vdsbroker: adding UpdateVolumeVDSCommand
by Code Review 17 Jan '17

17 Jan '17

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: vdsbroker: adding UpdateVolumeVDSCommand ...................................................................... vdsbroker: adding UpdateVolumeVDSCommand Note that using this verb for setting the volume status to ILLEGAL should be performed with change I9794cb7ba1259791ed4c7d699fabdeae88b21cbf Change-Id: I8b580a4ece900a10451b2908251a95d2377f0993 Bug-Url: http://bugzilla.redhat.com/1409125 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/UpdateVolumeVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/UpdateVolumeVDSCommand.java 5 files changed, 135 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/69384 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b580a4ece900a10451b2908251a95d2377f0993 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: VdsmImagePoller - ILLEGAL status consideration
by Code Review 17 Jan '17

17 Jan '17

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: core: VdsmImagePoller - ILLEGAL status consideration ...................................................................... core: VdsmImagePoller - ILLEGAL status consideration This patch modifies the VdsmImagePoller to not consider the ILLEGAL status for determining the result of a volume job. As the SDM.update_volume verb was added, the rule of thumb that if a volume is ILLEGAL the operation has failed was changed. That verb allows changing the volume status to ILLEGAL, which means that on that case this status doesn't indicate on failure. This patch changes the VdsmImagePoller to fit to that new case, when the lease is FREE the poller will check the volume generation - a. if the generation equals to the execution generation + 1 the job succeeded. b. if the generation equals to the execution generation + the fencing diff the operation can be considered as failed. c. on any other case, the job status can't be determined by the poller. when the generation equals to the execution generation - the job may be pending or it may never start if the host was shut down. The poller will wait till the volume job fencing will succeed or until the operation will end) and then will end the job according to checks a/b. Change-Id: I9794cb7ba1259791ed4c7d699fabdeae88b21cbf Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/VdsmImagePoller.java 1 file changed, 4 insertions(+), 13 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/69415 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9794cb7ba1259791ed4c7d699fabdeae88b21cbf Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: StorageJobs - adding support for job fencing
by Code Review 17 Jan '17

17 Jan '17

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: core: StorageJobs - adding support for job fencing ...................................................................... core: StorageJobs - adding support for job fencing This patch adds support for storage job fencing for entity polling commands in the StorageJobCallback. When a job possibly hasn't started yet, we can attempt to fence the job using the entity that may be used to poll the job status. Fencing the job means that the host that recieved it will fail when attempting to execute it. Fencing the jobb would usually be performed by executing an asynchronous fencing command on the entity the job is supposed to be performed on. Once the job was fenced, the entity poller in use should be able to determine the job status as failed. Change-Id: Iaf318884f0d9667d80eaff7f31bf4fdd39a6afb1 Bug-Url: http://bugzilla.redhat.com/1409125 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StorageJobCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/EntityPollingCommand.java 2 files changed, 23 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/69389 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf318884f0d9667d80eaff7f31bf4fdd39a6afb1 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: StorageJobs - persist whether the job started
by Code Review 17 Jan '17

17 Jan '17

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: core: StorageJobs - persist whether the job started ...................................................................... core: StorageJobs - persist whether the job started This patch modifies the StorageJobCallback to persist whether the storage job execution has started. This change is needed in order to determine whether it may be possible to fence the job or not (we can fence only jobs that didn't start). Change-Id: Iaa605e189e2e9597cdbca9e51940050b228451fc Bug-Url: http://bugzilla.redhat.com/1409125 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StorageJobCallback.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StorageJobCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/HostJobInfo.java 3 files changed, 27 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/69388 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa605e189e2e9597cdbca9e51940050b228451fc Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: Bootstrap layout storage popup
by Code Review 17 Jan '17

17 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Bootstrap layout storage popup ...................................................................... webadmin: Bootstrap layout storage popup - Used bootstrap grid for laying out the new/import storage domain popup. - Fixed issue with host select not highlighting when an error occured. - Updated managed gluster checkbox layout. Change-Id: I917c8788dad1f88dd6cfba303440942180977e88 Bug-Url: https://bugzilla.redhat.com/1404674 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/FcpStorageView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/FcpStorageView.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/GlusterStorageView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/GlusterStorageView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/LocalStorageView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/LocalStorageView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/PosixStorageView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/PosixStorageView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.ui.xml 14 files changed, 385 insertions(+), 631 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/70581 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I917c8788dad1f88dd6cfba303440942180977e88 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: renaming system tests to reflect real repos
by Code Review 17 Jan '17

17 Jan '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: renaming system tests to reflect real repos ...................................................................... renaming system tests to reflect real repos We recently changed the nightly system tests 4.1 to run on pre releases version (ovirt-4.1-pre) so we can catch errors also on official releases, while the experimental flows already cover testing all CI pkgs. Changes done: - 4.0: Moved to use latest released repo (4.0.Z) - 4.1: Stayed the same, using 'pre' repo for now. - master: Dropped since there is no "master-pre" or stable. This should wait for the relevant OST patch to update the repos : https://gerrit.ovirt.org/#/c/70425/ Change-Id: I6b67c7d4ebcbd75eea5cc47b90e6c9385aedcdd3 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/ovirt/system-tests.yaml M jobs/confs/yaml/templates/system_tests_templates.yaml 2 files changed, 24 insertions(+), 17 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70424 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b67c7d4ebcbd75eea5cc47b90e6c9385aedcdd3 Gerrit-PatchSet: 9 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: David Caro <david(a)dcaro.es> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Pavel Zhukov <pavel(a)zhukoff.net> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: order nics by their number in the name
by Code Review 16 Jan '17

16 Jan '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: order nics by their number in the name ...................................................................... engine: order nics by their number in the name 'nic2' should come before 'nic10'. Change-Id: I71812cc849be2ec3df1c27af68651226d1c218d1 Bug-Url: https://bugzilla.redhat.com/1315878 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/common/comparator/NumericSuffixNameableComparator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ReorderVmNicsCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/common/comparator/NumericSuffixNameableComparatorTest.java 3 files changed, 119 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/69534 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71812cc849be2ec3df1c27af68651226d1c218d1 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0