January 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: VdcObjectType - adding the EXECUTION_HOST type
by Code Review 16 Jan '17

16 Jan '17

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: core: VdcObjectType - adding the EXECUTION_HOST type ...................................................................... core: VdcObjectType - adding the EXECUTION_HOST type This patch adds the EXECUTION_HOST type that may be used by internal flows to specify which host is used for the execution of Step (by adding a StepSubjectEntity with that type). Change-Id: I1426575071d70d7cbdb5189e6695c46957e15d7d Bug-Url: https://bugzilla.redhat.com/1408841 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcObjectType.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/70091 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1426575071d70d7cbdb5189e6695c46957e15d7d Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GetStepByStepIdQuery - subject entities loading
by Code Review 16 Jan '17

16 Jan '17

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: core: GetStepByStepIdQuery - subject entities loading ...................................................................... core: GetStepByStepIdQuery - subject entities loading This patch changes the GetStepByStepIdQuery to return the step subject entities as well and renames it to GetStepWithSubjectEntitiesByStepIdQuery Change-Id: I2e655a2579f9d06c0dff5a2aaf3fccd9c904976c Bug-Url: https://bugzilla.redhat.com/1408841 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetStepWithSubjectEntitiesByStepIdQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStepResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStepsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStepResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStepsResourceTest.java 6 files changed, 10 insertions(+), 10 deletions(-) Approvals: Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/70089 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e655a2579f9d06c0dff5a2aaf3fccd9c904976c Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: JobRepository - getStep() support for loading subject ...
by Code Review 16 Jan '17

16 Jan '17

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: core: JobRepository - getStep() support for loading subject entities ...................................................................... core: JobRepository - getStep() support for loading subject entities This patch adds support to the getStep() method to load the step subject entity list. Change-Id: I45b2d56998ac6c4f8fc331ada413df0c9f97d582 Bug-Url: https://bugzilla.redhat.com/1408841 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetStepByStepIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepository.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandContextsCacheImpl.java 5 files changed, 15 insertions(+), 9 deletions(-) Approvals: Jenkins CI: Passed CI tests Liron Aravot: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/70088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45b2d56998ac6c4f8fc331ada413df0c9f97d582 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: VdsCommandsHelper - set the step executing host
by Code Review 16 Jan '17

16 Jan '17

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: core: VdsCommandsHelper - set the step executing host ...................................................................... core: VdsCommandsHelper - set the step executing host This patch modifies the VdsCommandsHelper to set the execution host when a command with command step is executing a vds command using the helper. Change-Id: Id555ffc44b5c8a116695ca0a0501bb93669cbf7b Bug-Url: https://bugzilla.redhat.com/1408841 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/AmendVolumeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ColdMergeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyDataCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/RemoveDeviceFromSANStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/utils/VdsCommandsHelper.java 6 files changed, 23 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Liron Aravot: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/70093 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id555ffc44b5c8a116695ca0a0501bb93669cbf7b Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GetStepsByJobIdQuery - subject entities loading
by Code Review 16 Jan '17

16 Jan '17

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: core: GetStepsByJobIdQuery - subject entities loading ...................................................................... core: GetStepsByJobIdQuery - subject entities loading This patch changes the GetStepsByJobIdQuery to return the step subject entities as well and renames it to GetStepsWithSubjectEntitiesByJobId. Change-Id: I74fef04299f8e789807edde1e7f2465db8eea0e9 Bug-Url: https://bugzilla.redhat.com/1408841 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetStepsByJobIdQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetStepsWithSubjectEntitiesByJobIdQuery.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetStepsWithSubjectEntitiesByJobIdQueryParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStepsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStepsResourceTest.java 6 files changed, 39 insertions(+), 30 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/70090 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74fef04299f8e789807edde1e7f2465db8eea0e9 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: StepSubjectEntityDao - adding remove()
by Code Review 16 Jan '17

16 Jan '17

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: core: StepSubjectEntityDao - adding remove() ...................................................................... core: StepSubjectEntityDao - adding remove() This patch adds the remove() method to the StepSubjectEntityDao. Change-Id: Iddec46b5850a6405895175882fece9774df4b946 Bug-Url: https://bugzilla.redhat.com/1408841 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StepSubjectEntityDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StepSubjectEntityDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StepSubjectEntityDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/job_sp.sql 5 files changed, 52 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/70086 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iddec46b5850a6405895175882fece9774df4b946 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: api: StepMapper - executionHost mapping
by Code Review 16 Jan '17

16 Jan '17

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: api: StepMapper - executionHost mapping ...................................................................... api: StepMapper - executionHost mapping This patch adds support to the StepMapper to map the Step executionHost property from the subject entity with the EXECUTION_HOST entity type (if present). Change-Id: I102c3cde11dbeb91772e99d1a3e26c1e30c5492b Bug-Url: https://bugzilla.redhat.com/1408841 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StepMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/StepMapperTest.java 2 files changed, 50 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/70092 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I102c3cde11dbeb91772e99d1a3e26c1e30c5492b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: introduce NumericSuffixNormalizer
by Code Review 16 Jan '17

16 Jan '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: introduce NumericSuffixNormalizer ...................................................................... engine: introduce NumericSuffixNormalizer Change-Id: I6131855ae153b28482d1f29410f629759de538bb Bug-Url: https://bugzilla.redhat.com/1315878 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/common/NumericSuffixNormalizer.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/common/comparator/NumericSuffixNormalizerTest.java 2 files changed, 158 insertions(+), 0 deletions(-) Approvals: Dominik Holler: Looks good to me, but someone else must approve Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/69533 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6131855ae153b28482d1f29410f629759de538bb Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: restapi: Add 'succeeded' parameter to Job.end
by Code Review 16 Jan '17

16 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: restapi: Add 'succeeded' parameter to Job.end ...................................................................... restapi: Add 'succeeded' parameter to Job.end This patch adds a new 'succeeded' parameter to the operation that ends an external job. Change-Id: I9a8ec88d0ea7ee52ab02ea8ef5e261ffe8c0dd56 Bug-Url: https://bugzilla.redhat.com/1404051 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit c5590efeaeeadc6a6b0433617b50c8b01b4d8565) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EndExternalJobCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/EndExternalJobCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/EndExternalJobParameters.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendJobResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStepResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendJobResourceTest.java 6 files changed, 19 insertions(+), 24 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70474 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a8ec88d0ea7ee52ab02ea8ef5e261ffe8c0dd56 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Move CORS filter from API to utils
by Code Review 16 Jan '17

16 Jan '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: core: Move CORS filter from API to utils ...................................................................... core: Move CORS filter from API to utils This patch moves the CORS filter used by the API to the 'utils' module, so that can be used by other web applications, in particular by the SSO web application. Change-Id: I50b49e5e9b08b71887838e303d7d0682e9645e3b Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/web.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/jaxrs/src/main/modules/org/ovirt/engine/api/restapi-jaxrs/main/module.xml M backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/jboss-deployment-structure.xml M backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml M backend/manager/modules/utils/pom.xml R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/CORSSupportFilter.java M backend/manager/modules/utils/src/main/modules/org/ovirt/engine/core/utils/main/module.xml 8 files changed, 22 insertions(+), 10 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Marek Libra: Verified -- To view, visit https://gerrit.ovirt.org/68062 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50b49e5e9b08b71887838e303d7d0682e9645e3b Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0