Change in ovirt-engine-cli[master]: cli: Fix SDK dependency
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: cli: Fix SDK dependency
......................................................................
cli: Fix SDK dependency
The CLI needs version 3 of the SDK, and can't work with version 4, but
the dependencies inside the 'setup.py' file don't force that. This patch
addresses that issue.
Change-Id: I68b8653f318d0e78056001ca9ae51525d4774e61
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M setup.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/69264
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I68b8653f318d0e78056001ca9ae51525d4774e61
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[ovirt-engine-4.1]: core: Remove unused field in VmTemplate
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Remove unused field in VmTemplate
......................................................................
core: Remove unused field in VmTemplate
Bug-Url: https://bugzilla.redhat.com/1409579
Change-Id: If6daf148c45f4eccb471e0e6eb9f694847846335
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java
3 files changed, 0 insertions(+), 13 deletions(-)
Approvals:
Jakub Niedermertl: Verified; Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/69498
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If6daf148c45f4eccb471e0e6eb9f694847846335
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in jenkins[master]: Add 4.1 to vmconsole
by Code Review
>From Gil Shinar <gshinar(a)redhat.com>:
Gil Shinar has submitted this change and it was merged.
Change subject: Add 4.1 to vmconsole
......................................................................
Add 4.1 to vmconsole
Change-Id: I0aab09f5a293d9c663c86e742edd991a91341be8
Signed-off-by: Gil Shinar <gshinar(a)redhat.com>
---
M jobs/confs/projects/ovirt-vmconsole/ovirt-vmconsole_standard.yaml
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Gil Shinar: Verified; Looks good to me, approved; Passed CI tests; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/69500
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0aab09f5a293d9c663c86e742edd991a91341be8
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[master]: core: Remove unused field in VmTemplate
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Remove unused field in VmTemplate
......................................................................
core: Remove unused field in VmTemplate
Bug-Url: https://bugzilla.redhat.com/1409579
Change-Id: If6daf148c45f4eccb471e0e6eb9f694847846335
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java
3 files changed, 0 insertions(+), 13 deletions(-)
Approvals:
Jakub Niedermertl: Verified; Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/69446
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If6daf148c45f4eccb471e0e6eb9f694847846335
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[master]: webadmin: fixed 'Add iSCSI' dialog help
by Code Review
>From Greg Sheremeta <gshereme(a)redhat.com>:
Greg Sheremeta has submitted this change and it was merged.
Change subject: webadmin: fixed 'Add iSCSI' dialog help
......................................................................
webadmin: fixed 'Add iSCSI' dialog help
'Add iSCSI' dialog help link wasn't working due to missing
super call. Fixed.
Change-Id: I9f395b19511c6548f60264080158fd5e04434b59
Bug-Url: https://bugzilla.redhat.com/1389549
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/IscsiBondModel.java
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Greg Sheremeta: Verified
--
To view, visit https://gerrit.ovirt.org/69272
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9f395b19511c6548f60264080158fd5e04434b59
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-host-deploy[ovirt-host-deploy-1.6]: Change 4.1 repo for build artifacts
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Change 4.1 repo for build artifacts
......................................................................
Change 4.1 repo for build artifacts
I have changed the 4.1 repo to be latest.tested
instead of nightly
Change-Id: Ic00552d58bdd231ec33c5ebe53a32f00bd82abed
Signed-off-by: Gil Shinar <gshinar(a)redhat.com>
---
M automation/build-artifacts.repos
M automation/check-patch.repos
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved; Passed CI tests
Gil Shinar: Verified
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/69486
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic00552d58bdd231ec33c5ebe53a32f00bd82abed
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: ovirt-host-deploy-1.6
Gerrit-Owner: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-host-deploy[master]: set 'virtual-host' as the default tuned profile
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: set 'virtual-host' as the default tuned profile
......................................................................
set 'virtual-host' as the default tuned profile
'virtual-host' is the recommanded tuned profile for hypervisors.
Same profile is recommanded for hyperconverged installation with
gluster. So when there is no tuned profile defined at the cluster
level then 'virtual-host' will be used if virt service is enabled.
Note: If there is no profile defined at the cluster level and only
gluster service is enabled not virt service then we will not
set any tuned profile.
Change-Id: Ifab913bb55dc4708fe33799459a83c6ea7d43ede
Bug-Url: https://bugzilla.redhat.com/1380739
Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com>
---
M src/plugins/ovirt-host-deploy/tune/tuned.py
1 file changed, 5 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Sahina Bose: Looks good to me, but someone else must approve
Ramesh N: Verified
--
To view, visit https://gerrit.ovirt.org/69452
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifab913bb55dc4708fe33799459a83c6ea7d43ede
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-host-deploy[ovirt-host-deploy-1.6]: Change 4.1 repo for build artifacts
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Change 4.1 repo for build artifacts
......................................................................
Change 4.1 repo for build artifacts
I have changed the 4.1 repo to be latest.tested
instead of nightly
Change-Id: I4bad3444c3201de3d3ccf31085359694ea283754
Signed-off-by: Gil Shinar <gshinar(a)redhat.com>
---
M automation/build-artifacts.repos
M automation/check-merged.repos
M automation/check-patch.repos
3 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/69480
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4bad3444c3201de3d3ccf31085359694ea283754
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: ovirt-host-deploy-1.6
Gerrit-Owner: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine-sdk-java[sdk_4.1]: Run tests for both http client versions
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Run tests for both http client versions
......................................................................
Run tests for both http client versions
This patch changes Unit tests so they run for both implementations,
of the http client library. Now with every build we run both.
Change-Id: I5994e65184b4f0ca2b3114db5b81ad5e10959ad9
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
(cherry picked from commit a3fac0688b8282fa1886be61d2678c0a0b9d481d)
---
M automation/build.py
M sdk/pom.xml
2 files changed, 90 insertions(+), 0 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/69483
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5994e65184b4f0ca2b3114db5b81ad5e10959ad9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine-sdk-java[master]: Run tests for both http client versions
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Run tests for both http client versions
......................................................................
Run tests for both http client versions
This patch changes Unit tests so they run for both implementations,
of the http client library. Now with every build we run both.
Change-Id: I5994e65184b4f0ca2b3114db5b81ad5e10959ad9
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M automation/build.py
M sdk/pom.xml
2 files changed, 90 insertions(+), 0 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/61598
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5994e65184b4f0ca2b3114db5b81ad5e10959ad9
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months