Change in ovirt-hosted-engine-ha[master]: Fix refreshing vm conf
by Code Review
>From Martin Sivák <msivak(a)redhat.com>:
Martin Sivák has submitted this change and it was merged.
Change subject: Fix refreshing vm conf
......................................................................
Fix refreshing vm conf
When refreshing the vm configuration on the host
we first try the ovf store, if no content was found
we try the shared storage vm.conf.
When we have the content we can refresh the locally
stored file.
The recent refactor broke this functionality, this patch
fixes it.
Change-Id: I281b42a6cb2c5cfdd5821cd50e3f2608d3ae8896
Bug-Url: https://bugzilla.redhat.com/1301681
Signed-off-by: Jenny Tokar <jtokar(a)redhat.com>
---
M ovirt_hosted_engine_ha/env/config.py
1 file changed, 8 insertions(+), 3 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved
Jenkins CI: Passed CI tests
Jenny Tokar: Verified
--
To view, visit https://gerrit.ovirt.org/69235
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I281b42a6cb2c5cfdd5821cd50e3f2608d3ae8896
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[master]: core: Add host affinity check in host maintenance.
by Code Review
>From Martin Sivák <msivak(a)redhat.com>:
Martin Sivák has submitted this change and it was merged.
Change subject: core: Add host affinity check in host maintenance.
......................................................................
core: Add host affinity check in host maintenance.
Add a validation for Maintenance number of hosts command
to check for VM to hosts hard affinity presence.
Bug-Url: https://bugzilla.redhat.com/1404660
Change-Id: Iaf89ab224d3ee47325b62747c83675ddcf65cf95
Signed-off-by: Yanir Quinn <yquinn(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java
M packaging/dbscripts/affinity_groups_sp.sql
2 files changed, 46 insertions(+), 30 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved
Martin Peřina: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Yanir Quinn: Verified
--
To view, visit https://gerrit.ovirt.org/69369
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf89ab224d3ee47325b62747c83675ddcf65cf95
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[ovirt-engine-4.1]: core: Block detach of a storage domain contains VMs/template...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Block detach of a storage domain contains VMs/templates leases
......................................................................
core: Block detach of a storage domain contains VMs/templates leases
Change-Id: I456fcd791a2852b44e437a61be06c8d0cdc73db3
Bug-Url: https://bugzilla.redhat.com/1408877
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/DetachStorageDomainFromPoolCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
7 files changed, 21 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Liron Aravot: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/69560
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I456fcd791a2852b44e437a61be06c8d0cdc73db3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[ovirt-engine-4.1]: webadmin: upload image - use uploadMessagePanel
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: upload image - use uploadMessagePanel
......................................................................
webadmin: upload image - use uploadMessagePanel
Upload Image:
use uploadMessagePanel for failure on resume error
to keep consistency with the other error messages.
Change-Id: Ie288d238d6413f7b0871a35786aa95ddefcf10f7
Bug-Url: https://bugzilla.redhat.com/1363696
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/69515
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie288d238d6413f7b0871a35786aa95ddefcf10f7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[master]: webadmin: remove redundant progressMessagePanel
by Code Review
>From Daniel Erez <derez(a)redhat.com>:
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: remove redundant progressMessagePanel
......................................................................
webadmin: remove redundant progressMessagePanel
Removing progressMessagePanel from UploadImagePopupView;
unneeded since progress is already displayed in status column.
Change-Id: I4509ceefa892a4feee5fa57509218e2474e72fa2
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/UploadImagePopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/UploadImagePopupView.ui.xml
2 files changed, 0 insertions(+), 12 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Daniel Erez: Verified
--
To view, visit https://gerrit.ovirt.org/69514
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4509ceefa892a4feee5fa57509218e2474e72fa2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[master]: dal: AuditLogMessages - missing message
by Code Review
>From Liron Aravot <laravot(a)redhat.com>:
Liron Aravot has submitted this change and it was merged.
Change subject: dal: AuditLogMessages - missing message
......................................................................
dal: AuditLogMessages - missing message
This patch adds the missing
"USER_DEACTIVATE_STORAGE_DOMAIN_OVF_UPDATE_INCOMPLETE" message.
Change-Id: I29e2eb1f8faef4c3c4884a6b1fa5a7601e33a19f
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/68924
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I29e2eb1f8faef4c3c4884a6b1fa5a7601e33a19f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in jenkins[master]: Re-factored system-tests builders
by Code Review
>From Eyal Edri <eedri(a)redhat.com>:
Eyal Edri has submitted this change and it was merged.
Change subject: Re-factored system-tests builders
......................................................................
Re-factored system-tests builders
The system-tests jobs had their own builder script which made then
unnecessarily different then other standard-CI jobs.
This patch gets rid of the system-tests builder script and makes use of
the standard-ci builder macros instead.
Change-Id: I5ebe785ec090cd09e2dee28c947166f75c2e5b22
Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-995
Signed-off-by: Barak Korren <bkorren(a)redhat.com>
---
D jobs/confs/shell-scripts/system_tests.sh
M jobs/confs/yaml/builders/system_tests_builders.yaml
2 files changed, 13 insertions(+), 33 deletions(-)
Approvals:
Eyal Edri: Verified; Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/69396
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5ebe785ec090cd09e2dee28c947166f75c2e5b22
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: David Caro <david(a)dcaro.es>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[master]: core: Block detach of a storage domain contains VMs/template...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Block detach of a storage domain contains VMs/templates leases
......................................................................
core: Block detach of a storage domain contains VMs/templates leases
Change-Id: I456fcd791a2852b44e437a61be06c8d0cdc73db3
Bug-Url: https://bugzilla.redhat.com/1408877
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/DetachStorageDomainFromPoolCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
7 files changed, 21 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Liron Aravot: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/69319
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I456fcd791a2852b44e437a61be06c8d0cdc73db3
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-hosted-engine-setup[master]: jsonrpc: python jsonrpcvdscli instead of vdsClient
by Code Review
>From Simone Tiraboschi <stirabos(a)redhat.com>:
Simone Tiraboschi has submitted this change and it was merged.
Change subject: jsonrpc: python jsonrpcvdscli instead of vdsClient
......................................................................
jsonrpc: python jsonrpcvdscli instead of vdsClient
Use python jsonrpcvdscli instead of vdsClient for
ancillary commands on bash scripts.
Adding unit test for the vm.conf parsing code based
on pytest.
Adding the initial pytest configuration.
Change-Id: I4880eb94dfabe9628d34687a97febe3b1c6fd969
Bug-Url: https://bugzilla.redhat.com/1393918
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M .gitignore
M Makefile.am
M ovirt-hosted-engine-setup.spec.in
M po/POTFILES.in
A pytest.ini
M src/bin/hosted-engine.in
M src/ovirt_hosted_engine_setup/Makefile.am
A src/ovirt_hosted_engine_setup/vdsm_helper.py
A src/ovirt_hosted_engine_setup/vm_test.conf
A src/ovirt_hosted_engine_setup/vmconf.py
A src/ovirt_hosted_engine_setup/vmconf_test.py
M src/plugins/gr-he-upgradeappliance/vm/runvm.py
12 files changed, 534 insertions(+), 55 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Simone Tiraboschi: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68828
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4880eb94dfabe9628d34687a97febe3b1c6fd969
Gerrit-PatchSet: 26
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[master]: core: AddVdsCommand type inference
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: core: AddVdsCommand type inference
......................................................................
core: AddVdsCommand type inference
Change-Id: I4cf885de9c70b4b7870268cdc97930451bb33751
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/AddVdsCommand.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/69476
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4cf885de9c70b4b7870268cdc97930451bb33751
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months