February 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.1.1.z]: he_restore: updating foreign key removing HE hosts
by Code Review 23 Feb '17

23 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: he_restore: updating foreign key removing HE hosts ...................................................................... he_restore: updating foreign key removing HE hosts For migration or disaster recovery purposes we let the user filter out the hosted-engine hosts to redeploy from a backup on a different hosted-engine env. In order to be sure that all the hosted-engine runs with a local up-do-date configuration we have to remove them from the engine DB asking to the user to redeploy them to be sure that they point to the right hosted-engine storage domain. In order to remove them at restore time avoiding foreign key errors, we need to update all the existing VMs related to these hosts. Set status=Down, exit_reason=AdminShutdown, exit_status=Normal, run_on_vds=NULL, migrating_to_vds=NULL for all the VM that were running on the hosted-engine hosts we are filtering out at restore time. Change-Id: I85a6fcd18005393e69ed319e7b56709e7adc5b9b Bug-Url: https://bugzilla.redhat.com/1416466 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/dbutils/hecleaner_sp.sql 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Passed CI tests Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit https://gerrit.ovirt.org/72919 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85a6fcd18005393e69ed319e7b56709e7adc5b9b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1.1.z Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.1.1.z]: he_restore: avoid failing with other VM disks
by Code Review 23 Feb '17

23 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: he_restore: avoid failing with other VM disks ...................................................................... he_restore: avoid failing with other VM disks For migration or disaster recovery purposes we let the user filter out the hosted-engine storage domain and the engine VM to redeploy from a backup on a different hosted-engine env. Due to another bug the user could create a floating disk on the hosted-engine storage domain and then connect it to the engine VM. In this case we should still remove the hosted-engine storage domain filtering out other VMs disks as well without failing. Change-Id: I2be23b172ea592f9b6be08477fad0f4bf29a30ad Bug-Url: https://bugzilla.redhat.com/1416459 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/dbutils/hecleaner_sp.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72920 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2be23b172ea592f9b6be08477fad0f4bf29a30ad Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1.1.z Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Allow deployment of HE on clusters with compatibility ...
by Code Review 23 Feb '17

23 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Allow deployment of HE on clusters with compatibility less than 4.0 ...................................................................... core: Allow deployment of HE on clusters with compatibility less than 4.0 Removes the check to prevent deployment of HE on clusters with compatibility vesrion less than 4.0. The host must have repositories for ovirt 4.0 or newer, otherwise the deployment will fail. Change-Id: Iec29070e37058a3d02246e13563ad650a24bd6a1 Bug-Url: https://bugzilla.redhat.com/1383156 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/HostValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/HostValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 9 insertions(+), 26 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Phillip Bailey: Looks good to me, but someone else must approve Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/72917 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec29070e37058a3d02246e13563ad650a24bd6a1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Fix installing logutils.jar
by Code Review 23 Feb '17

23 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Fix installing logutils.jar ...................................................................... core: Fix installing logutils.jar Fix installing logutils.jar on downstream build when using minimead.py which replaces pom version with specific version of the build. Change-Id: I2099186df489841b95d1a086a05f03e9bb525d9d Bug-Url: https://bugzilla.redhat.com/1408193 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72884 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2099186df489841b95d1a086a05f03e9bb525d9d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: he: Ensures that there will be no spm_id=1 host after restore.
by Code Review 23 Feb '17

23 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: he: Ensures that there will be no spm_id=1 host after restore. ...................................................................... he: Ensures that there will be no spm_id=1 host after restore. Restoring HE environment from backup could lead into two hosts, thinking they have spm_id==1 at same moment. One of those hosts will be newly deployed HE host with default spm_id==1, another one host will be old host from the database. This patch changes spm_id of the host with value '1' to some unused value. Change-Id: Ib7b10f57a9350adf3da73580c4a69e5ce317502e Bug-Url: https://bugzilla.redhat.com/1417518 Signed-off-by: Denis Chaplygin <dchaplyg(a)redhat.com> (cherry picked from commit b440a7e46bba47e43e16305236c3c3207345139e) --- M packaging/setup/dbutils/hecleaner_sp.sql 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Passed CI tests Simone Tiraboschi: Verified Allon Mureinik: Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/72895 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7b10f57a9350adf3da73580c4a69e5ce317502e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: Warn when deploying HE with cluster compatibility ...
by Code Review 23 Feb '17

23 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Warn when deploying HE with cluster compatibility less than 4.0 ...................................................................... webadmin: Warn when deploying HE with cluster compatibility less than 4.0 Show a warning when setting deployment of hosted engine through the UI and the compatibility version of the cluster is less than 4.0 Change-Id: I15f4856558762507845055a0b88eac1e8f948d18 Bug-Url: https://bugzilla.redhat.com/1383156 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInstallPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInstallPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml 9 files changed, 75 insertions(+), 10 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Phillip Bailey: Looks good to me, but someone else must approve Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/72894 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15f4856558762507845055a0b88eac1e8f948d18 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: he_restore: updating foreign key removing HE hosts
by Code Review 23 Feb '17

23 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: he_restore: updating foreign key removing HE hosts ...................................................................... he_restore: updating foreign key removing HE hosts For migration or disaster recovery purposes we let the user filter out the hosted-engine hosts to redeploy from a backup on a different hosted-engine env. In order to be sure that all the hosted-engine runs with a local up-do-date configuration we have to remove them from the engine DB asking to the user to redeploy them to be sure that they point to the right hosted-engine storage domain. In order to remove them at restore time avoiding foreign key errors, we need to update all the existing VMs related to these hosts. Set status=Down, exit_reason=AdminShutdown, exit_status=Normal, run_on_vds=NULL, migrating_to_vds=NULL for all the VM that were running on the hosted-engine hosts we are filtering out at restore time. Change-Id: I85a6fcd18005393e69ed319e7b56709e7adc5b9b Bug-Url: https://bugzilla.redhat.com/1416466 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/dbutils/hecleaner_sp.sql 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72802 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85a6fcd18005393e69ed319e7b56709e7adc5b9b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: Revert "webadmin: Refresh VM numa nodes when VM memory or CP...
by Code Review 23 Feb '17

23 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: Revert "webadmin: Refresh VM numa nodes when VM memory or CPU cores are changed" ...................................................................... Revert "webadmin: Refresh VM numa nodes when VM memory or CPU cores are changed" This reverts commit 9ce06369690cec196ab5ff60d8bf9a02448a24c1. Reverted commit on gerrit: https://gerrit.ovirt.org/#/c/69946/ Change-Id: Ic8b10a33a1bf50421527b25d19fc1f4606a4d70d Bug-Url: https://bugzilla.redhat.com/1291064 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> (cherry picked from commit 5db67a7e3f57fea347e82b10ebaf4980e4a9cb26) --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/72873 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8b10a33a1bf50421527b25d19fc1f4606a4d70d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: Update VM NUMA nodes if VM memory or CPU count has...
by Code Review 23 Feb '17

23 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Update VM NUMA nodes if VM memory or CPU count has changed ...................................................................... webadmin: Update VM NUMA nodes if VM memory or CPU count has changed Detect if the total memory or the number of CPUs were changed in the Edit dialog. If they were, NUMA nodes are changed to fit the new values. Change-Id: I67b796a128c0af17dd54056b862798cd0d650bcf Bug-Url: https://bugzilla.redhat.com/1291064 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> (cherry picked from commit 54fc01a5e5b81b3f1ac017d9100ff7f7fc6e8ce8) --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/72874 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67b796a128c0af17dd54056b862798cd0d650bcf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Warn on add brick for HC volume
by Code Review 23 Feb '17

23 Feb '17

>From Sahina Bose <sabose(a)redhat.com>: Sahina Bose has submitted this change and it was merged. Change subject: webadmin: Warn on add brick for HC volume ...................................................................... webadmin: Warn on add brick for HC volume Show a warning about recommendation of adding new volumes to scale out an HC cluster Change-Id: I1534ccbaab95dc386ba373877a7a0c6fb9de0f05 Bug-Url: https://bugzilla.redhat.com/1417582 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties 3 files changed, 59 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Sahina Bose: Verified; Looks good to me, approved Ramesh N: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/72883 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1534ccbaab95dc386ba373877a7a0c6fb9de0f05 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0