February 2017 - Engine-commits - oVirt List Archives

Change in jenkins[master]: Leave single target platform for vdsmfake
by Code Review 21 Feb '17

21 Feb '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. Change subject: Leave single target platform for vdsmfake ...................................................................... Leave single target platform for vdsmfake This project doesn't produce any RPMs and is really java only that produces wars or fat jar. Change-Id: I15f7b877ebcd68490fc073243dfc38f0dccba341 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M jobs/confs/projects/ovirt-vdsmfake/ovirt-vdsmfake_standard.yaml 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Barak Korren: Verified; Looks good to me, approved; Ready for merge Gil Shinar: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72775 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15f7b877ebcd68490fc073243dfc38f0dccba341 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Pavel Zhukov <pavel(a)zhukoff.net> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: move initialization type from vm to the parameters of ...
by Code Review 21 Feb '17

21 Feb '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: move initialization type from vm to the parameters of run-vm ...................................................................... core: move initialization type from vm to the parameters of run-vm It is not really a property of a VM but a configuration for the run operation (for example, in the next run we may want to use cloud-init and on the next run we certainly won't want it because the VM is already initialized). Thus, this patch moves the initilizationType from the overloaded VM object to the parameters of Create command. Change-Id: I8e11c3db2ce9fa8501c6f4e8bbe319f47a6be0b9 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/CreateVDSCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVDSCommand.java 4 files changed, 18 insertions(+), 17 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/72686 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e11c3db2ce9fa8501c6f4e8bbe319f47a6be0b9 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: remove acpiEnabled parameter for run-vm
by Code Review 21 Feb '17

21 Feb '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: remove acpiEnabled parameter for run-vm ...................................................................... core: remove acpiEnabled parameter for run-vm The parameter acpiEnabled is always true for run VM so it is unneeded. Change-Id: I36a60e6543459bf00260cb60b71c7add96ebef5a Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmParams.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java 3 files changed, 0 insertions(+), 14 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/72685 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36a60e6543459bf00260cb60b71c7add96ebef5a Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: boot sequence parameter is relevant only in run-once
by Code Review 21 Feb '17

21 Feb '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: boot sequence parameter is relevant only in run-once ...................................................................... core: boot sequence parameter is relevant only in run-once In regular run flow the boot sequence from the VM definition should be used. In run-once this can be overridden and thus it resides in the command's parameters. However, since it is specific to run-once, it should reside in RunVmOnceParams rather than RunVmParams. Change-Id: I85ac285fc9799cc13ba5ce4a133e854ed63087bb Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/RunVmValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmOnceParams.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmParams.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilderImpl.java 8 files changed, 39 insertions(+), 57 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/72654 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85ac285fc9799cc13ba5ce4a133e854ed63087bb Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Update backup servers option
by Code Review 21 Feb '17

21 Feb '17

>From Sahina Bose <sabose(a)redhat.com>: Sahina Bose has submitted this change and it was merged. Change subject: webadmin: Update backup servers option ...................................................................... webadmin: Update backup servers option Update backup servers option when gluster volume is selected in storage domain Change-Id: Ia1cf0ce5cbe5112d47c29a54144ac5267057b918 Bug-Url: https://bugzilla.redhat.com/1417554 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/ConnectStorageToVdsCommand.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/GlusterStorageModel.java 2 files changed, 56 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Sahina Bose: Verified; Looks good to me, approved Ramesh N: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/72293 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1cf0ce5cbe5112d47c29a54144ac5267057b918 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Make nightly publisher wait for cron job to finish
by Code Review 21 Feb '17

21 Feb '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. Change subject: Make nightly publisher wait for cron job to finish ...................................................................... Make nightly publisher wait for cron job to finish Sometimes we see a race-condition formed where the cron job that processes the result of the nightly publisher job does not finish running before the next publisher job for the same oVirt version runs. This can happen if something in the publisher job output makes the cron job fail constantly or if the publisher job is manually started frequently enough. This patch makes the publisher job wait for up to 50 minuts for the cron job to finish and then fail under the assumption that we're seeing a consistent cron job failure. This will allow detecting the so-far transparent cron failures via the Jenkins job failures Also re-factored the publishers YAML to DRY it up Change-Id: I875cc4aedc65580f07e517cc606a87a5f74355ea Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1161 Signed-off-by: Barak Korren <bkorren(a)redhat.com> --- M jobs/confs/projects/ovirt/publish-rpms-nightly-3.6.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-4.0.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-4.1.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml A jobs/confs/yaml/publishers/publish-rpms-nightly.yaml 5 files changed, 83 insertions(+), 65 deletions(-) Approvals: Sandro Bonazzola: Looks good to me Eyal Edri: Looks good to me, approved Barak Korren: Verified; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72634 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I875cc4aedc65580f07e517cc606a87a5f74355ea Gerrit-PatchSet: 9 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Pavel Zhukov <pavel(a)zhukoff.net> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-host-deploy[ovirt-host-deploy-1.6]: build: ovirt-host-deploy-1.6.1
by Code Review 21 Feb '17

21 Feb '17

>From Yedidyah Bar David <didi(a)redhat.com>: Yedidyah Bar David has submitted this change and it was merged. Change subject: build: ovirt-host-deploy-1.6.1 ...................................................................... build: ovirt-host-deploy-1.6.1 Change-Id: I28e131a6165f6206d2212fe897c3e178b18b4074 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ChangeLog M automation/build-artifacts.sh M configure.ac M ovirt-host-deploy.spec.in 4 files changed, 14 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/72454 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28e131a6165f6206d2212fe897c3e178b18b4074 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: ovirt-host-deploy-1.6 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: imgbased: add manual builder
by Code Review 21 Feb '17

21 Feb '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: imgbased: add manual builder ...................................................................... imgbased: add manual builder Change-Id: Ia25daf96f418d7a840310f92802ad0ad8da94092 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/imgbased/imgbased.yaml 1 file changed, 12 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72754 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia25daf96f418d7a840310f92802ad0ad8da94092 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: Export artifacts from check-patch also
by Code Review 21 Feb '17

21 Feb '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: Export artifacts from check-patch also ...................................................................... Export artifacts from check-patch also Because why not... Also: - Make sure 'exported-artifacts' is cleaned before putting stuff there - Make sure nothing is left in 'output' Change-Id: I916b91876e31a4eb8c6a416050b144ade8404a17 Signed-off-by: Barak Korren <bkorren(a)redhat.com> --- M automation/build-artifacts.sh M automation/check-patch.sh 2 files changed, 7 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Barak Korren: Verified Eyal Edri: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71562 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I916b91876e31a4eb8c6a416050b144ade8404a17 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-host-deploy[ovirt-host-deploy-1.6]: tune/iosched: Keep default
by Code Review 21 Feb '17

21 Feb '17

>From Yedidyah Bar David <didi(a)redhat.com>: Yedidyah Bar David has submitted this change and it was merged. Change subject: tune/iosched: Keep default ...................................................................... tune/iosched: Keep default Do not configure default ioscheduler anymore. We used to configure it to 'deadline', which is the default for supported kernels, thus not needed anymore. Remove old configuration file if found. With the previous configuration we wrote, it was impossible to override host-deploy's change by setting an attribute in a later conf file, which is what some storage vendors recommend to do. With this patch this should be trivial. Change-Id: I2e98afaed5444efd67cc5f7ad3a3b40aa1f76933 Bug-Url: https://bugzilla.redhat.com/1381219 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 8c42c3f4150000d5f9afd36fb0b4b9770edcb818) --- M src/plugins/ovirt-host-deploy/tune/Makefile.am M src/plugins/ovirt-host-deploy/tune/iosched.py D src/plugins/ovirt-host-deploy/tune/ovirt-iosched.rules 3 files changed, 36 insertions(+), 47 deletions(-) Approvals: Jenkins CI: Passed CI tests Yedidyah Bar David: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/72753 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e98afaed5444efd67cc5f7ad3a3b40aa1f76933 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: ovirt-host-deploy-1.6 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0