February 2017 - Engine-commits - oVirt List Archives

Change in ovirt-host-deploy[master]: tune/iosched: Keep default
by Code Review 21 Feb '17

21 Feb '17

>From Yedidyah Bar David <didi(a)redhat.com>: Yedidyah Bar David has submitted this change and it was merged. Change subject: tune/iosched: Keep default ...................................................................... tune/iosched: Keep default Do not configure default ioscheduler anymore. We used to configure it to 'deadline', which is the default for supported kernels, thus not needed anymore. Remove old configuration file if found. With the previous configuration we wrote, it was impossible to override host-deploy's change by setting an attribute in a later conf file, which is what some storage vendors recommend to do. With this patch this should be trivial. Change-Id: I2e98afaed5444efd67cc5f7ad3a3b40aa1f76933 Bug-Url: https://bugzilla.redhat.com/1381219 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M src/plugins/ovirt-host-deploy/tune/Makefile.am M src/plugins/ovirt-host-deploy/tune/iosched.py D src/plugins/ovirt-host-deploy/tune/ovirt-iosched.rules 3 files changed, 36 insertions(+), 47 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/72632 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e98afaed5444efd67cc5f7ad3a3b40aa1f76933 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Fix Rubocop issue
by Code Review 21 Feb '17

21 Feb '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Fix Rubocop issue ...................................................................... Fix Rubocop issue This patch fixes a Rubocop issue introduced by a recently added example. Change-Id: Ifdf22cab2e3b65a16eafc2f1cb47035c42e5a160 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit ce0c9261902fc9a6e4f5e41b310eca2882ed4d17) (cherry picked from commit e9ea6e05dfed13c279f961661983529f926ac7b9) --- M sdk/examples/update_quota_limits.rb 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/72751 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifdf22cab2e3b65a16eafc2f1cb47035c42e5a160 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.1]: Fix Rubocop issue
by Code Review 21 Feb '17

21 Feb '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Fix Rubocop issue ...................................................................... Fix Rubocop issue This patch fixes a Rubocop issue introduced by a recently added example. Change-Id: Ifdf22cab2e3b65a16eafc2f1cb47035c42e5a160 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit ce0c9261902fc9a6e4f5e41b310eca2882ed4d17) --- M sdk/examples/update_quota_limits.rb 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/72750 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifdf22cab2e3b65a16eafc2f1cb47035c42e5a160 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.1 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Fix Rubocop issue
by Code Review 21 Feb '17

21 Feb '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Fix Rubocop issue ...................................................................... Fix Rubocop issue This patch fixes a Rubocop issue introduced by a recently added example. Change-Id: Ifdf22cab2e3b65a16eafc2f1cb47035c42e5a160 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/examples/update_quota_limits.rb 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/72749 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifdf22cab2e3b65a16eafc2f1cb47035c42e5a160 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Integrate whitelist into std-CI
by Code Review 21 Feb '17

21 Feb '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: Integrate whitelist into std-CI ...................................................................... Integrate whitelist into std-CI White-listing patches is espcially important for Standard-CI where any patch can change the automation scripts. Change-Id: Ied5a57460eb1edecaf604ab28e67a946cd591c5a Signed-off-by: Barak Korren <bkorren(a)redhat.com> Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1153 --- M jobs/confs/shell-scripts/whitelist-filter.sh M jobs/confs/yaml/templates/standard-stage.yaml M jobs/confs/yaml/triggers/standard.yaml 3 files changed, 41 insertions(+), 2 deletions(-) Approvals: Nadav Goldin: Looks good to me Nir Soffer: Looks good to me Eyal Edri: Looks good to me, approved; Ready for merge Barak Korren: Verified; Ready for review Jenkins CI: Passed CI tests Objections: Michal Skrivanek: I would prefer that you didn't submit this -- To view, visit https://gerrit.ovirt.org/72402 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied5a57460eb1edecaf604ab28e67a946cd591c5a Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Pavel Zhukov <pavel(a)zhukoff.net> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Add quota limit update example
by Code Review 21 Feb '17

21 Feb '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Add quota limit update example ...................................................................... Add quota limit update example This patch adds an example that shows how to update a storage quota limit. Change-Id: I1cd96ae40a0b2b134cd1b55342590aa9da8d704b Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit e0985f08c748a36aa4af1f7414c027b3b87de110) (cherry picked from commit 9f00a7603809880517a0dbc9481f27bdad95e065) --- A sdk/examples/update_quota_limits.rb 1 file changed, 86 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/72747 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1cd96ae40a0b2b134cd1b55342590aa9da8d704b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.1]: Add quota limit update example
by Code Review 21 Feb '17

21 Feb '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Add quota limit update example ...................................................................... Add quota limit update example This patch adds an example that shows how to update a storage quota limit. Change-Id: I1cd96ae40a0b2b134cd1b55342590aa9da8d704b Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit e0985f08c748a36aa4af1f7414c027b3b87de110) --- A sdk/examples/update_quota_limits.rb 1 file changed, 86 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/72746 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1cd96ae40a0b2b134cd1b55342590aa9da8d704b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.1 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add quota limit update example
by Code Review 21 Feb '17

21 Feb '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Add quota limit update example ...................................................................... Add quota limit update example This patch adds an example that shows how to update a storage quota limit. Change-Id: I1cd96ae40a0b2b134cd1b55342590aa9da8d704b Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A sdk/examples/update_quota_limits.rb 1 file changed, 86 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72514 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1cd96ae40a0b2b134cd1b55342590aa9da8d704b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: engine: format DR schedule representation
by Code Review 21 Feb '17

21 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: engine: format DR schedule representation ...................................................................... engine: format DR schedule representation Change-Id: I842535b47fff9e8a575413f191120d78772f2b7f Bug-Url: https://bugzilla.redhat.com/1417816 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/StorageSyncSchedule.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Sahina Bose: Verified; Looks good to me, approved Ramesh N: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/72734 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I842535b47fff9e8a575413f191120d78772f2b7f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: Correct error reporting for georep delete
by Code Review 21 Feb '17

21 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Correct error reporting for georep delete ...................................................................... webadmin: Correct error reporting for georep delete Show relevant error to user while deleting a geo-replication session that is used for replication storage domain data Change-Id: I0124f37459d9284d831a2bdb4a4af0ef551aabdf Bug-Url: https://bugzilla.redhat.com/1418567 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 19 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Sahina Bose: Verified; Looks good to me, approved Ramesh N: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/72733 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0124f37459d9284d831a2bdb4a4af0ef551aabdf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0