February 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Fix installing logutils.jar
by Code Review 17 Feb '17

17 Feb '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: core: Fix installing logutils.jar ...................................................................... core: Fix installing logutils.jar Downstream build doesn't properly work with non-versioned artifacts, so we need to switch back to generating logutils JAR with version and then remove the version when copying the JAR into final destination. Change-Id: Ic40449341c9738010cedec32a51eb6d85384dd0c Bug-Url: https://bugzilla.redhat.com/1408193 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M Makefile M backend/manager/logutils/pom.xml 2 files changed, 1 insertion(+), 5 deletions(-) Approvals: Martin Peřina: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72478 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic40449341c9738010cedec32a51eb6d85384dd0c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: RemoveVmFromPoolCommand DAO injection
by Code Review 17 Feb '17

17 Feb '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: RemoveVmFromPoolCommand DAO injection ...................................................................... core: RemoveVmFromPoolCommand DAO injection Commit 2d8e01 introduced an injection of a VmPoolDao instance. This is redundant as the command already inherits this injected DAO from AuditLoggableBase. This patch cleans up the code by removing that redundant injection. Change-Id: I5fcc0e7f98d9de91f3f36e48b9251fd6d172c442 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromPoolCommand.java 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/72469 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5fcc0e7f98d9de91f3f36e48b9251fd6d172c442 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: remove patternfly1 dependency, add ovirt-js-dependen...
by Code Review 16 Feb '17

16 Feb '17

>From Greg Sheremeta <gshereme(a)redhat.com>: Greg Sheremeta has submitted this change and it was merged. Change subject: engine: remove patternfly1 dependency, add ovirt-js-dependencies ...................................................................... engine: remove patternfly1 dependency, add ovirt-js-dependencies Change-Id: I4df937283ef518a2d78e3c41dc41698bd86a7100 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/72456 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4df937283ef518a2d78e3c41dc41698bd86a7100 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: remove the ProductKey section if product key is not pr...
by Code Review 16 Feb '17

16 Feb '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: remove the ProductKey section if product key is not provided ...................................................................... core: remove the ProductKey section if product key is not provided The reason is that the sysprep operation fails if the product key is empty. Change-Id: I70c8bb82d28c20d338a0b04466a5e200fc558194 Bug-Url: https://bugzilla.redhat.com/1419562 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandler.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandlerTest.java 2 files changed, 84 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Verified Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Michal Skrivanek: Looks good to me, but someone else must approve Arik Hadas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/72426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70c8bb82d28c20d338a0b04466a5e200fc558194 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.0]: packaging: fixing bad permissions on answer file from the past
by Code Review 16 Feb '17

16 Feb '17

>From Simone Tiraboschi <stirabos(a)redhat.com>: Simone Tiraboschi has submitted this change and it was merged. Change subject: packaging: fixing bad permissions on answer file from the past ...................................................................... packaging: fixing bad permissions on answer file from the past answers.conf is in the configuration volume on the shared storage since 3.6 while it was just a local file before. The 3.5 -> 3.6 upgrade procedure is able to move it to the shared storage but it runs in ovirt-ha-agent deamon as vdsm user so answers.conf should be readable by vdsm user. Bug-Url: https://bugzilla.redhat.com/1422864 Change-Id: If234bae54f204f733016e4268f18ec2c86802aca Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt-hosted-engine-setup.spec.in 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/72434 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If234bae54f204f733016e4268f18ec2c86802aca Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.0 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-node-ng: add per patch checks
by Code Review 16 Feb '17

16 Feb '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-node-ng: add per patch checks ...................................................................... ovirt-node-ng: add per patch checks add check-merged and check-patch jobs Change-Id: Ie53e526736a85e245a461790124303e5ebdac6ca Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-node-ng/ovirt-node-ng.yaml 1 file changed, 35 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Barak Korren: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/69979 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie53e526736a85e245a461790124303e5ebdac6ca Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Pavel Zhukov <pavel(a)zhukoff.net> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: not only inject members but also call postConstruct
by Code Review 16 Feb '17

16 Feb '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: not only inject members but also call postConstruct ...................................................................... core: not only inject members but also call postConstruct Since the CreateVDSCommand is using the postConstruct method, it is important to make sure that the postConstruct method will be properly called. Change-Id: I4929af1a488065bc3589fa058318ca1b23359841 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/72446 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4929af1a488065bc3589fa058318ca1b23359841 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: manual ost: new manual job to rule all the suites
by Code Review 16 Feb '17

16 Feb '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: manual ost: new manual job to rule all the suites ...................................................................... manual ost: new manual job to rule all the suites With this job, you can choose which suite you want to run, add you own patch on top of it for testing, choose lago version and a fallback version. Change-Id: Ibe54f1dd1f70d8bc166fee137afcc7c0429c4cf2 Signed-off-by: Daniel Belenky <dbelenky(a)redhat.com> --- M jobs/confs/projects/ovirt/system-tests.yaml M jobs/confs/yaml/builders/system_tests_builders.yaml A jobs/confs/yaml/parmeters/upgrade-table.yaml 3 files changed, 124 insertions(+), 10 deletions(-) Approvals: Eyal Edri: Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests Daniel Belenky: Verified; Ready for review Yedidyah Bar David: Looks good to me -- To view, visit https://gerrit.ovirt.org/71706 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe54f1dd1f70d8bc166fee137afcc7c0429c4cf2 Gerrit-PatchSet: 15 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gal Ben Haim <galbh2(a)gmail.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.1]: packaging: fixing bad permissions on answer file from the past
by Code Review 16 Feb '17

16 Feb '17

>From Simone Tiraboschi <stirabos(a)redhat.com>: Simone Tiraboschi has submitted this change and it was merged. Change subject: packaging: fixing bad permissions on answer file from the past ...................................................................... packaging: fixing bad permissions on answer file from the past answers.conf is in the configuration volume on the shared storage since 3.6 while it was just a local file before. The 3.5 -> 3.6 upgrade procedure is able to move it to the shared storage but it runs in ovirt-ha-agent deamon as vdsm user so answers.conf should be readable by vdsm user. Bug-Url: https://bugzilla.redhat.com/1401359 Change-Id: If234bae54f204f733016e4268f18ec2c86802aca Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt-hosted-engine-setup.spec.in 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/72433 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If234bae54f204f733016e4268f18ec2c86802aca Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.1 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: remove pool when last VM detached
by Code Review 16 Feb '17

16 Feb '17

>From Shahar Havivi <shavivi(a)redhat.com>: Shahar Havivi has submitted this change and it was merged. Change subject: core: remove pool when last VM detached ...................................................................... core: remove pool when last VM detached Change-Id: I85c319b492d88ec2f864c6746ffd6afe8469dd0d Bug-Url: https://bugzilla.redhat.com/1419520 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromPoolCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/locks/LockingGroup.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java 3 files changed, 33 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/72354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85c319b492d88ec2f864c6746ffd6afe8469dd0d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0