February 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Rng devices are updated during cluster downgrade
by Code Review 16 Feb '17

16 Feb '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: Rng devices are updated during cluster downgrade ...................................................................... core: Rng devices are updated during cluster downgrade When cluster version is downgraded from 4.1 to 4.0, rng devices of templates and VMs in the cluster are changed from urandom to random. Change-Id: I42080bb17cb0cb31eac3ece8f6f531432e056cb3 Bug-Url: https://bugzilla.redhat.com/1419924 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmRngDevice.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Jakub Niedermertl: Verified Arik Hadas: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/72318 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42080bb17cb0cb31eac3ece8f6f531432e056cb3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: fixing ACTION_TYPE_FAILED_NETWORK_IN_MANY_USES macro
by Code Review 16 Feb '17

16 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: fixing ACTION_TYPE_FAILED_NETWORK_IN_MANY_USES macro ...................................................................... webadmin: fixing ACTION_TYPE_FAILED_NETWORK_IN_MANY_USES macro ACTION_TYPE_FAILED_NETWORK_IN_MANY_USES expects to fill ACTION_TYPE_FAILED_NETWORK_IN_MANY_USES_LIST and ACTION_TYPE_FAILED_NETWORK_IN_MANY_USES_LIST_COUNTER whilst currently ACTION_TYPE_FAILED_NETWORK_IN_ONE_USE_LIST and ACTION_TYPE_FAILED_NETWORK_IN_ONE_USE_LIST_COUNTER are provided. Change-Id: Iaaf9d59631357dcb878a678c48f21b0075a58771 Bug-Id: https://bugzilla.redhat.com/1395583 Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Leon Goldberg: Verified -- To view, visit https://gerrit.ovirt.org/72384 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaaf9d59631357dcb878a678c48f21b0075a58771 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: random/urandom update added to next-run snapshot
by Code Review 16 Feb '17

16 Feb '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: random/urandom update added to next-run snapshot ...................................................................... core: random/urandom update added to next-run snapshot VMs that were running during cluster update 4.0 -> 4.1 didn't get its 'random' rng updated since the 'random' -> 'urandom' change was not included in next-run snapshot. This resulted in VM in updated cluster with incompatible rng device that prevented the VM from running. Fixed by including updated rng device in next-run snapshot. Calls of RngDeviceUtils updated to pass effective compatibility version instead of cluster version. Bug-Url: https://bugzilla.redhat.com/1419924 Change-Id: I917108c2497a2953c7b829120b28a63626d95b29 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/RngDeviceUtils.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/HasRngDevice.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UpdateVmTemplateParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java 7 files changed, 82 insertions(+), 57 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/72017 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I917108c2497a2953c7b829120b28a63626d95b29 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: add fc25 to ovirt-js-dependencies
by Code Review 16 Feb '17

16 Feb '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: add fc25 to ovirt-js-dependencies ...................................................................... add fc25 to ovirt-js-dependencies Change-Id: If14e80e833e7bc2c23cee54b3c66ffacb979bffb Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M jobs/confs/projects/ovirt-js-dependencies/ovirt-js-dependencies_standard.yaml 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved; Ready for merge Barak Korren: Verified; Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72376 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If14e80e833e7bc2c23cee54b3c66ffacb979bffb Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <david(a)dcaro.es> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Pavel Zhukov <pavel(a)zhukoff.net> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[master]: node: remove 90-ngn-disable-networkmanager
by Code Review 16 Feb '17

16 Feb '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: node: remove 90-ngn-disable-networkmanager ...................................................................... node: remove 90-ngn-disable-networkmanager Leave NM enabled by default on NGN for VDSM Change-Id: Iba4f6111157cd44c819e5d0860082d0e8e91111a Signed-off-by: Ryan Barry <rbarry(a)redhat.com> --- M ovirt-release-master.spec.in 1 file changed, 0 insertions(+), 10 deletions(-) Approvals: Douglas Schilling Landgraf: Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, approved; Passed CI tests Ryan Barry: Verified -- To view, visit https://gerrit.ovirt.org/71881 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba4f6111157cd44c819e5d0860082d0e8e91111a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[master]: node: add glusterfs to the default firewall zone
by Code Review 16 Feb '17

16 Feb '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: node: add glusterfs to the default firewall zone ...................................................................... node: add glusterfs to the default firewall zone With glusterfs packages present, bring glusterfs into the default firewalld zone also. Change-Id: Idcfd1177c46e97a60fd78e8bcf6358c97eb9ead0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1418630 Signed-off-by: Ryan Barry <rbarry(a)redhat.com> --- M ovirt-release-master.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved; Passed CI tests Simone Tiraboschi: Looks good to me, but someone else must approve Ryan Barry: Verified -- To view, visit https://gerrit.ovirt.org/71636 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idcfd1177c46e97a60fd78e8bcf6358c97eb9ead0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: added networkInUseByMany* tests
by Code Review 16 Feb '17

16 Feb '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. Change subject: backend: added networkInUseByMany* tests ...................................................................... backend: added networkInUseByMany* tests Adding the missing tests for ACTION_TYPE_FAILED_NETWORK_IN_MANY_USES; differentiating between one network/many networks throughout the tests. Change-Id: Ibfabfc8d024839544cd9e2e7083c1540128e6b6d Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkValidatorTest.java 1 file changed, 45 insertions(+), 7 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Leon Goldberg: Verified -- To view, visit https://gerrit.ovirt.org/72383 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibfabfc8d024839544cd9e2e7083c1540128e6b6d Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: restapi: Fix VM affinity rule mapping
by Code Review 16 Feb '17

16 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: restapi: Fix VM affinity rule mapping ...................................................................... restapi: Fix VM affinity rule mapping Fix VM affinity rule default value when no rule is passed. Change-Id: I226653f4fc32b4af16470452f7bb238e6d5415ae Bug-Url: https://bugzilla.redhat.com/1414818 Signed-off-by: Yanir Quinn <yquinn(a)redhat.com> (cherry picked from commit d37d9be) --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/AffinityGroupMapper.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Yanir Quinn: Verified -- To view, visit https://gerrit.ovirt.org/72321 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I226653f4fc32b4af16470452f7bb238e6d5415ae Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: scheduling: Honor the Start Running On option
by Code Review 16 Feb '17

16 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: scheduling: Honor the Start Running On option ...................................................................... scheduling: Honor the Start Running On option We should treat the VM's option Start Running On more seriously. This patch makes it 99 times more important than other policy units. That means we will honor it unless there are 99 better hosts according to other policy units. Change-Id: Iadadbf7b2a6b27e5f9db7aa9fdaf15b8b43c33d4 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1421713 Signed-off-by: Martin Sivak <msivak(a)redhat.com> (cherry picked from commit 1dce05e438183e1bf5e0b3f4ee926eb1aee26c40) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/InternalClusterPolicies.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Martin Sivák: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72353 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iadadbf7b2a6b27e5f9db7aa9fdaf15b8b43c33d4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Add conflicts check to host affinity
by Code Review 16 Feb '17

16 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Add conflicts check to host affinity ...................................................................... core: Add conflicts check to host affinity Added conflicts check for host affinity. These conflicts will include : Hosts that have enforcing positive and negative affinity conflicts. Hosts that have positive and negative affinity conflicts. Non intersecting hosts conflicts. VM to host affinity with positive VM to VM conflicts VM to host affinity with negative VM to VM conflicts Bug-Url: https://bugzilla.redhat.com/1417935 Change-Id: Ia515a2429bd2db3c290b40b69f3079fcd1cd1a1b Signed-off-by: Yanir Quinn <yquinn(a)redhat.com> (cherry picked from commit 066f100) --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesConflicts.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcer.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/AffinityGroupCRUDCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcerTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 12 files changed, 770 insertions(+), 43 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Yanir Quinn: Verified -- To view, visit https://gerrit.ovirt.org/72322 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia515a2429bd2db3c290b40b69f3079fcd1cd1a1b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0