February 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: upgrade to PatternFly 3, jQuery 2, gwtbootstrap 0.9.3
by Code Review 15 Feb '17

15 Feb '17

>From Alexander Wels <awels(a)redhat.com>: Alexander Wels has submitted this change and it was merged. Change subject: engine: upgrade to PatternFly 3, jQuery 2, gwtbootstrap 0.9.3 ...................................................................... engine: upgrade to PatternFly 3, jQuery 2, gwtbootstrap 0.9.3 Change-Id: Iadfb6c3e035f1b717eb4d5d324bd371436bb1239 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M Makefile M README.adoc M backend/manager/modules/branding/src/main/resources/META-INF/tags/obrand/javascripts.tag M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/credentialsChange.jsp M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/login.jsp M frontend/webadmin/modules/pom.xml M packaging/branding/ovirt.brand/branding.properties 7 files changed, 27 insertions(+), 25 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/61716 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iadfb6c3e035f1b717eb4d5d324bd371436bb1239 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: fixing a typo in canNetworkCompatibilityBeDecreased
by Code Review 15 Feb '17

15 Feb '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. Change subject: backend: fixing a typo in canNetworkCompatibilityBeDecreased ...................................................................... backend: fixing a typo in canNetworkCompatibilityBeDecreased Change-Id: I32fc54fbf288279eacc6d9f5d556463ac89e0dbb Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/UpdateStoragePoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/UpdateStoragePoolCommandTest.java 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved; Passed CI tests Leon Goldberg: Verified Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/72326 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32fc54fbf288279eacc6d9f5d556463ac89e0dbb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: dashboards: update dwh views version
by Code Review 15 Feb '17

15 Feb '17

>From Alexander Wels <awels(a)redhat.com>: Alexander Wels has submitted this change and it was merged. Change subject: dashboards: update dwh views version ...................................................................... dashboards: update dwh views version Change-Id: I2d845ac01c6788aff5e1aaf6d60d83e5504b95a1 Bug-Url: https://bugzilla.redhat.com/1421942 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/server/dashboard/dao/ClusterDwhDAO.properties M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/server/dashboard/dao/HostDwhDAO.properties M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/server/dashboard/dao/StorageDomainDwhDAO.properties M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/server/dashboard/dao/VmDwhDAO.properties 4 files changed, 52 insertions(+), 52 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, but someone else must approve Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72238 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d845ac01c6788aff5e1aaf6d60d83e5504b95a1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: LabelFilterPolicyUnit type inference
by Code Review 15 Feb '17

15 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: LabelFilterPolicyUnit type inference ...................................................................... core: LabelFilterPolicyUnit type inference Change-Id: I32e7d07df5c8c35bca66ec3e6eb3ae11a523ac9b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/LabelFilterPolicyUnit.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/72059 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32e7d07df5c8c35bca66ec3e6eb3ae11a523ac9b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[v2.1.z]: jsonrpc: avoid using vdscli
by Code Review 15 Feb '17

15 Feb '17

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. Change subject: jsonrpc: avoid using vdscli ...................................................................... jsonrpc: avoid using vdscli Change-Id: I8c565347f4e7e2dfbd9cdd44198b6846b8f50de8 Bug-Url: https://bugzilla.redhat.com/1101554 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/storage_backends.py 1 file changed, 23 insertions(+), 22 deletions(-) Approvals: Denis Chaplygin: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72300 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c565347f4e7e2dfbd9cdd44198b6846b8f50de8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: v2.1.z Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[master]: jsonrpc: avoid using vdscli
by Code Review 15 Feb '17

15 Feb '17

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. Change subject: jsonrpc: avoid using vdscli ...................................................................... jsonrpc: avoid using vdscli Change-Id: I8c565347f4e7e2dfbd9cdd44198b6846b8f50de8 Bug-Url: https://bugzilla.redhat.com/1101554 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/storage_backends.py 1 file changed, 23 insertions(+), 22 deletions(-) Approvals: Denis Chaplygin: Verified; Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c565347f4e7e2dfbd9cdd44198b6846b8f50de8 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-guest-agent[ovirt-4.1]: win32: Do not attempt to login when the desktop is unlocked
by Code Review 15 Feb '17

15 Feb '17

>From Vinzenz Feenstra <vfeenstr(a)redhat.com>: Vinzenz Feenstra has submitted this change and it was merged. Change subject: win32: Do not attempt to login when the desktop is unlocked ...................................................................... win32: Do not attempt to login when the desktop is unlocked When the desktop is unlocked we should not try to login because we're calling the 'Secure Attention Sequence' which will open the fullscreen window with the options to lock the screen, change password etc. This is a disturbing side effect that should be avoided. After searching for the best possible solution I came to the conclusion that the solution introduced in this patch is good enough, even though it won't work right after starting the agent. It will start working after the first login or unlock of the screen. That means also that this functionality won't be working after a restart of the service, since the agent won't be aware of the fact that it has been only restarted. I also can't say by default that the screen is unlocked, because that would break the SSO on startup and other cases. Therefore I assumed this as the currently 'good enough solution' as this is also a niche problem because for this feature to be useful the option to take no action on console disconnect has to be active in the ovirt-engine. The default is the lock screen behavior which will intiate the locking of the screen in case of a disconnect of the console. Bug-Url: https://bugzilla.redhat.com/1365925 Backport-To: 4.1 Change-Id: I52e92dc00eb34f9f6afc98dc4743a7d793de858b Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> (cherry picked from commit c3cfd269d66def2a3b1bf5cfcfd878493aa99473) --- M ovirt-guest-agent/GuestAgentWin32.py M ovirt-guest-agent/OVirtAgentLogic.py 2 files changed, 11 insertions(+), 1 deletion(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/72356 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I52e92dc00eb34f9f6afc98dc4743a7d793de858b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: ovirt-4.1 Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-guest-agent[master]: win32: Do not attempt to login when the desktop is unlocked
by Code Review 15 Feb '17

15 Feb '17

>From Vinzenz Feenstra <vfeenstr(a)redhat.com>: Vinzenz Feenstra has submitted this change and it was merged. Change subject: win32: Do not attempt to login when the desktop is unlocked ...................................................................... win32: Do not attempt to login when the desktop is unlocked When the desktop is unlocked we should not try to login because we're calling the 'Secure Attention Sequence' which will open the fullscreen window with the options to lock the screen, change password etc. This is a disturbing side effect that should be avoided. After searching for the best possible solution I came to the conclusion that the solution introduced in this patch is good enough, even though it won't work right after starting the agent. It will start working after the first login or unlock of the screen. That means also that this functionality won't be working after a restart of the service, since the agent won't be aware of the fact that it has been only restarted. I also can't say by default that the screen is unlocked, because that would break the SSO on startup and other cases. Therefore I assumed this as the currently 'good enough solution' as this is also a niche problem because for this feature to be useful the option to take no action on console disconnect has to be active in the ovirt-engine. The default is the lock screen behavior which will intiate the locking of the screen in case of a disconnect of the console. Bug-Url: https://bugzilla.redhat.com/1365925 Backport-To: 4.1 Change-Id: I52e92dc00eb34f9f6afc98dc4743a7d793de858b Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/GuestAgentWin32.py M ovirt-guest-agent/OVirtAgentLogic.py 2 files changed, 11 insertions(+), 1 deletion(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved; Passed CI tests Milan Zamazal: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/71223 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I52e92dc00eb34f9f6afc98dc4743a7d793de858b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[v2.1.z]: Add a method to get all editable keys on shared storage
by Code Review 15 Feb '17

15 Feb '17

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. Change subject: Add a method to get all editable keys on shared storage ...................................................................... Add a method to get all editable keys on shared storage Add a method to get all the keys that can be edited. That method gives the user more info about what can be edited for each editable file. Change-Id: I28a4dec3b854592c13a7f5b755531bd36e4642bb Bug-Url:https://bugzilla.redhat.com/1417583 Signed-off-by: Jenny Tokar <jtokar(a)redhat.com> --- M ovirt_hosted_engine_ha/client/client.py M ovirt_hosted_engine_ha/env/config.py 2 files changed, 24 insertions(+), 0 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Jenny Tokar: Verified -- To view, visit https://gerrit.ovirt.org/72346 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28a4dec3b854592c13a7f5b755531bd36e4642bb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: v2.1.z Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>

1 0

Change in ovirt-hosted-engine-ha[v2.1.z]: Provide more info in error message
by Code Review 15 Feb '17

15 Feb '17

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. Change subject: Provide more info in error message ...................................................................... Provide more info in error message Add a list of supported types to the error message when trying to set or get shared storage configuration. Change-Id: I68e0e1b32fc6bd15f8b38cd00795342d6b14e683 Bug-Url:https://bugzilla.redhat.com/1417583 Signed-off-by: Jenny Tokar <jtokar(a)redhat.com> --- M ovirt_hosted_engine_ha/env/config.py 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Jenny Tokar: Verified -- To view, visit https://gerrit.ovirt.org/72347 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68e0e1b32fc6bd15f8b38cd00795342d6b14e683 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: v2.1.z Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>

1 0