February 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-java[sdk_4.0]: Add Sysprep example
by Code Review 14 Feb '17

14 Feb '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add Sysprep example ...................................................................... Add Sysprep example This patch adds an example that shows how to add a virtual machine and then start it with a custom Sysprep configuration file. Change-Id: I8aebe94b532cffbf146f719b531a243b6e310432 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 418ee4445cf1e01c16511175ca2f06f043caf78a) --- A sdk/src/test/java/org/ovirt/engine/sdk4/examples/AddVmWithSysprep.java 1 file changed, 96 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72230 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8aebe94b532cffbf146f719b531a243b6e310432 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[sdk_4.1]: Add Sysprep example
by Code Review 14 Feb '17

14 Feb '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add Sysprep example ...................................................................... Add Sysprep example This patch adds an example that shows how to add a virtual machine and then start it with a custom Sysprep configuration file. Change-Id: I8aebe94b532cffbf146f719b531a243b6e310432 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 418ee4445cf1e01c16511175ca2f06f043caf78a) --- A sdk/src/test/java/org/ovirt/engine/sdk4/examples/AddVmWithSysprep.java 1 file changed, 96 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72165 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8aebe94b532cffbf146f719b531a243b6e310432 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.1]: Add Sysprep example
by Code Review 14 Feb '17

14 Feb '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add Sysprep example ...................................................................... Add Sysprep example This patch adds an example that shows how to add a virtual machine and then start it with a custom Sysprep configuration file. Change-Id: If04f421c88aced61c6cd53611c2168e2bc920f37 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit d1fb33ebbaebad4277432ad1043ffdfb3f9e686d) --- A sdk/examples/add_vm_with_sysprep.py 1 file changed, 95 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72162 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If04f421c88aced61c6cd53611c2168e2bc920f37 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: upgrade job: Add opstools repo
by Code Review 14 Feb '17

14 Feb '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: upgrade job: Add opstools repo ...................................................................... upgrade job: Add opstools repo Change-Id: Ia5426da4beb4ed388485a53e7aebc25d0bded3a1 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M jobs/confs/projects/ovirt-engine/ovirt-engine_upgrade-engine.yaml 1 file changed, 8 insertions(+), 4 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me, approved; Ready for merge Gil Shinar: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71786 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5426da4beb4ed388485a53e7aebc25d0bded3a1 Gerrit-PatchSet: 5 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <david(a)dcaro.es> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Pavel Zhukov <pavel(a)zhukoff.net> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: InjectorRule constructor reference
by Code Review 14 Feb '17

14 Feb '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: InjectorRule constructor reference ...................................................................... core: InjectorRule constructor reference Clean up the code by using a constructor reference instead of a lambda. Change-Id: I895918d6d895189cb6a7094311bbde56e87ff2dd Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/di/InjectorRule.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/72212 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I895918d6d895189cb6a7094311bbde56e87ff2dd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: InjectRule static inner classes
by Code Review 14 Feb '17

14 Feb '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: InjectRule static inner classes ...................................................................... core: InjectRule static inner classes InjectorRule's inner classes don't use any data and/or functionality from their enclosing classes, so they can be simplified to static inner classes. More importantly, this prevents the CDI to hold a reference to the first InjectRule created by its inner TestCDIProvider, so the garbage collector can pick it up. Change-Id: I75aade124728868a9da825f8b40de8a0f230ff76 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/di/InjectorRule.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/72213 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75aade124728868a9da825f8b40de8a0f230ff76 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: InjectorRule typing
by Code Review 14 Feb '17

14 Feb '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: InjectorRule typing ...................................................................... core: InjectorRule typing Use typed classes instead of raw classes. Change-Id: Id0cd922d884192172b0095079275b5d8cd40ea32 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/di/InjectorRule.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/72211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0cd922d884192172b0095079275b5d8cd40ea32 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: InjectorRule static initialization
by Code Review 14 Feb '17

14 Feb '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: InjectorRule static initialization ...................................................................... core: InjectorRule static initialization Move the InjectorRule's initialization of the CDI to a static block instead of the convoluted implementation of this logic where every new instance needs to check if the static member has already been initialized or not. Change-Id: I2e8a4f9a4a239a1d2d383d7e31b4a399a43a2e1b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/di/InjectorRule.java 1 file changed, 2 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/72214 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e8a4f9a4a239a1d2d383d7e31b4a399a43a2e1b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: Power Management restart displays misleading message.
by Code Review 14 Feb '17

14 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Power Management restart displays misleading message. ...................................................................... webadmin: Power Management restart displays misleading message. Rephrase message when power management restart is invoked. Change-Id: I4a5074775093b814cf9fcf58c9508f4c78657d1f Bug-Url: https://bugzilla.redhat.com/1418002 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Passed CI tests Martin Peřina: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/72096 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a5074775093b814cf9fcf58c9508f4c78657d1f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: USB autoshare conditionally disabled
by Code Review 14 Feb '17

14 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: USB autoshare conditionally disabled ...................................................................... webadmin: USB autoshare conditionally disabled Widget Console options dialog > SPICE Options group > Enable USB autoshare is enabled only when USB support (~ spice usb redirection) is enabled. Change-Id: Ic13f0e0f6be444c38ac134aaaf224f6bd3fe7139 Bug-Url: https://bugzilla.redhat.com/1369175 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ConsolePopupPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ConsolePopupView.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties 4 files changed, 20 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72195 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic13f0e0f6be444c38ac134aaaf224f6bd3fe7139 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0