Change in ovirt-engine[ovirt-engine-4.1]: webadmin: NPE on edit pool dialog
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: NPE on edit pool dialog
......................................................................
webadmin: NPE on edit pool dialog
The resource allocation of the edit pool dialog has a logic which tries to
select the storage domain of the selected template to be the same as the
storage domain on which some Vm from the pool is.
The logic has an assumption that the selected template's disks are the parent
disks of the respective VM. This assumption is true only if the template is not
versioned. If the template has versions, this assumption is broken.
This causes an issue that the disk allocation part is not properly inited and
consequently fails on validation on NPE.
Fixed by first initing the storage to the values of the template disks and than
try to match them to the VM ones.
Change-Id: Iafc386b7cc4b013293c7b7f627053a438f7df7cc
Bug-Url: https://bugzilla.redhat.com/1388963
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
(cherry picked from commit 6c146a0d92407e52f9b99540ca7dcdfcb5fc825f)
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingPoolModelBehavior.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Verified
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/72192
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iafc386b7cc4b013293c7b7f627053a438f7df7cc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: core: fix NPE on query from export domain
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: fix NPE on query from export domain
......................................................................
core: fix NPE on query from export domain
The recent injection of OvfManager into OvfHelper requires us to inject
stuff into instances of OvfHelper. When not doing so, we are expected
to get NPEs. So this patch replaces instantiation of OvfHelper with its
injection.
Change-Id: I3ef419f1cb8d80c452dab85984f815ff99765d9c
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/GetVmsFromExportDomainQuery.java
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/72206
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3ef419f1cb8d80c452dab85984f815ff99765d9c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in jenkins[master]: mirrors-reposync.conf: fix fc24 url
by Code Review
>From Barak Korren <bkorren(a)redhat.com>:
Barak Korren has submitted this change and it was merged.
Change subject: mirrors-reposync.conf: fix fc24 url
......................................................................
mirrors-reposync.conf: fix fc24 url
Change-Id: I00ae03929aa7b80a655d0bc9024a90052be7018e
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M data/mirrors-reposync.conf
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Barak Korren: Verified; Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
Rafael Martins: Looks good to me
--
To view, visit https://gerrit.ovirt.org/72182
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I00ae03929aa7b80a655d0bc9024a90052be7018e
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: core: Introduce logutils module
by Code Review
>From Martin Peřina <mperina(a)redhat.com>:
Martin Peřina has submitted this change and it was merged.
Change subject: core: Introduce logutils module
......................................................................
core: Introduce logutils module
1. Introduces logutils module, which contains code extending standard
java.logging framework
2. This module needs to be separated from other utils classes, so we can
insert it into boot class path, which is needed to specify custom
logging formatter introduced in subsequent classes
3. Moves JavaLoggingUtils class to logutils module
Change-Id: Idee6583569dfb68e56b164e174e3f22ad236b374
Bug-Url: https://bugzilla.redhat.com/1408193
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M Makefile
M backend/manager/extensions-tool/pom.xml
A backend/manager/logutils/exclude-filters.xml
A backend/manager/logutils/pom.xml
R backend/manager/logutils/src/main/java/org/ovirt/engine/core/logutils/JavaLoggingUtils.java
M backend/manager/pom.xml
M backend/manager/tools/pom.xml
M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigExecutor.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/Notifier.java
M ovirt-engine.spec.in
M packaging/bin/engine-config.sh
M packaging/bin/ovirt-engine-extensions-tool.sh
M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in
13 files changed, 49 insertions(+), 4 deletions(-)
Approvals:
Ondra Machacek: Looks good to me, but someone else must approve
Martin Peřina: Verified; Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
Ravi Nori: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/67161
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idee6583569dfb68e56b164e174e3f22ad236b374
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: tools: Add time zone to log records
by Code Review
>From Martin Peřina <mperina(a)redhat.com>:
Martin Peřina has submitted this change and it was merged.
Change subject: tools: Add time zone to log records
......................................................................
tools: Add time zone to log records
1. Introduces TimeZoneBasedFormatter which bypasses inability of
java.util.logging framework to specify different time zone used to
format date/time part of the log record
2. Adds time zone to time stamp to log records for
ovirt-engine-notifier, engine-config and
ovirt-engine-extensions-tool
Change-Id: I1e0704c0b07b2c7e233a134f137a89db7fbc6f6e
Bug-Url: https://bugzilla.redhat.com/1408193
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/logutils/src/main/java/org/ovirt/engine/core/logutils/JavaLoggingUtils.java
A backend/manager/logutils/src/main/java/org/ovirt/engine/core/logutils/TimeZoneBasedFormatter.java
M packaging/conf/extensions-tool-logging.properties
M packaging/conf/notifier-logging.properties.in
M packaging/conf/tools-logging.properties
5 files changed, 137 insertions(+), 10 deletions(-)
Approvals:
Ondra Machacek: Looks good to me, but someone else must approve
Martin Peřina: Verified; Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
Ravi Nori: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/67162
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1e0704c0b07b2c7e233a134f137a89db7fbc6f6e
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: dashboards: Fixed host.hourly_cpu_mem_history dashboard query
by Code Review
>From Alexander Wels <awels(a)redhat.com>:
Alexander Wels has submitted this change and it was merged.
Change subject: dashboards: Fixed host.hourly_cpu_mem_history dashboard query
......................................................................
dashboards: Fixed host.hourly_cpu_mem_history dashboard query
Change-Id: I3184f4d4860af8f73544ce836195ec0242ab75f2
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/server/dashboard/dao/HostDwhDAO.properties
1 file changed, 57 insertions(+), 59 deletions(-)
Approvals:
Shirly Radco: Looks good to me, but someone else must approve
Alexander Wels: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/69972
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3184f4d4860af8f73544ce836195ec0242ab75f2
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: dashboards: Fixed last_5_min_cpu_mem_average dashboard query
by Code Review
>From Alexander Wels <awels(a)redhat.com>:
Alexander Wels has submitted this change and it was merged.
Change subject: dashboards: Fixed last_5_min_cpu_mem_average dashboard query
......................................................................
dashboards: Fixed last_5_min_cpu_mem_average dashboard query
Change-Id: I42af9ae012435071a8957cf6dfb7fca60bb630e5
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/server/dashboard/dao/HostDwhDAO.properties
1 file changed, 20 insertions(+), 17 deletions(-)
Approvals:
Alexander Wels: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/70700
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I42af9ae012435071a8957cf6dfb7fca60bb630e5
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: dashboards: Fixed host.total_cpu_memory_count dashboard query
by Code Review
>From Alexander Wels <awels(a)redhat.com>:
Alexander Wels has submitted this change and it was merged.
Change subject: dashboards: Fixed host.total_cpu_memory_count dashboard query
......................................................................
dashboards: Fixed host.total_cpu_memory_count dashboard query
Change-Id: I560f8b7fdb71e05162b1b472707cf7dfa7b77d2c
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/server/dashboard/dao/HostDwhDAO.properties
1 file changed, 3 insertions(+), 12 deletions(-)
Approvals:
Alexander Wels: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/69971
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I560f8b7fdb71e05162b1b472707cf7dfa7b77d2c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: dashboards: Fixed vms utilization dashboard queries
by Code Review
>From Alexander Wels <awels(a)redhat.com>:
Alexander Wels has submitted this change and it was merged.
Change subject: dashboards: Fixed vms utilization dashboard queries
......................................................................
dashboards: Fixed vms utilization dashboard queries
The queries incluede max, which slowed down the queries.
I updtaed the queries so that they will not use it.
Change-Id: I8908e9144629e73f59588960b0af91711a2e3746
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/server/dashboard/dao/VmDwhDAO.properties
1 file changed, 60 insertions(+), 70 deletions(-)
Approvals:
Alexander Wels: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68789
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8908e9144629e73f59588960b0af91711a2e3746
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: engine: Alert about DC(s) not upgraded to latest version
by Code Review
>From Martin Peřina <mperina(a)redhat.com>:
Martin Peřina has submitted this change and it was merged.
Change subject: engine: Alert about DC(s) not upgraded to latest version
......................................................................
engine: Alert about DC(s) not upgraded to latest version
On engine restart and every 7 days raise an alert for all
data centers that have compatibility version lower than
the highest engine compatibility version.
Change-Id: I5b0ad6b05e9f12c1fbbec06519be0c35c1485496
Bug-Url: https://bugzilla.redhat.com/1413150
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DataCenterCompatibilityChecker.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
4 files changed, 77 insertions(+), 0 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Ravi Nori: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/71799
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5b0ad6b05e9f12c1fbbec06519be0c35c1485496
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months