February 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: AddCpuProfileCommandTest parameters mocking
by Code Review 13 Feb '17

13 Feb '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: AddCpuProfileCommandTest parameters mocking ...................................................................... core: AddCpuProfileCommandTest parameters mocking The parameters member is @Mocked and then immediately overridden by a real object in the setUp() method. This patch removes the useless annotation. Change-Id: I809c150b08ff66356a42c48c85e097a875e7383c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/profiles/AddCpuProfileCommandTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/72121 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I809c150b08ff66356a42c48c85e097a875e7383c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Silent runner when needed in command tests
by Code Review 13 Feb '17

13 Feb '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: Silent runner when needed in command tests ...................................................................... core: Silent runner when needed in command tests While the test suite passes in maven, some tests may fail in IDEA when run individually due to redundant mocking. Using the Silent runner solves this issue. Change-Id: I5b8e764370e0ad4791fbc6d7cb4f35f2eedcf8e9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddClusterCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/PauseGlusterVolumeGeoRepSessionCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/ResumeGeoRepSessionCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StopGeoRepSessionCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/hostdeploy/GetoVirtISOsTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/connection/AddStorageServerConnectionCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/repoimage/ExportRepoImageCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/repoimage/ImportRepoImageCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VmValidatorTest.java 9 files changed, 18 insertions(+), 18 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/72134 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b8e764370e0ad4791fbc6d7cb4f35f2eedcf8e9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GetGlusterGeoReplicationEligibleVolumesQueryTest streams
by Code Review 13 Feb '17

13 Feb '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: GetGlusterGeoReplicationEligibleVolumesQueryTest streams ...................................................................... core: GetGlusterGeoReplicationEligibleVolumesQueryTest streams This patch reimplments checkEquals with Java 8's stream. This new implementation is not only shorter and easier to read, but also reduces the time-complexity of the comparison from O(n*m) to O(n+m). Change-Id: I68ab8c0a709cb1e46b7bf5beec179c3971d197b8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterGeoReplicationEligibleVolumesQueryTest.java 1 file changed, 6 insertions(+), 13 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/72132 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68ab8c0a709cb1e46b7bf5beec179c3971d197b8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GetVdsAndNetworkInterfacesByNetworkIdQueryTest mocking
by Code Review 13 Feb '17

13 Feb '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: GetVdsAndNetworkInterfacesByNetworkIdQueryTest mocking ...................................................................... core: GetVdsAndNetworkInterfacesByNetworkIdQueryTest mocking Remove redundant mocking that adds nothing to the test and may actually cause it to fail under strict mocking. Change-Id: I9c1463387f91dddd56fa2bc1bfa5c9b9be346c31 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/GetVdsAndNetworkInterfacesByNetworkIdQueryTest.java 1 file changed, 0 insertions(+), 15 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Martin Mucha: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/72133 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c1463387f91dddd56fa2bc1bfa5c9b9be346c31 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Add Sysprep example
by Code Review 13 Feb '17

13 Feb '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Add Sysprep example ...................................................................... Add Sysprep example This patch adds an example that shows how to add a virtual machine and then start it with a custom Sysprep configuration file. Change-Id: I2e7c1a7ac61f2124fd9667b3cf794d441133216e Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 24d261bc7d0e56e4153f5ac647a5abb6cbeb2bad) (cherry picked from commit af38239f909747269d5ae952bae16cfbfa2d41d1) --- A sdk/examples/add_vm_with_sysprep.rb 1 file changed, 85 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/72173 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e7c1a7ac61f2124fd9667b3cf794d441133216e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.1]: Add Sysprep example
by Code Review 13 Feb '17

13 Feb '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Add Sysprep example ...................................................................... Add Sysprep example This patch adds an example that shows how to add a virtual machine and then start it with a custom Sysprep configuration file. Change-Id: I2e7c1a7ac61f2124fd9667b3cf794d441133216e Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 24d261bc7d0e56e4153f5ac647a5abb6cbeb2bad) --- A sdk/examples/add_vm_with_sysprep.rb 1 file changed, 85 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/72172 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e7c1a7ac61f2124fd9667b3cf794d441133216e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.1 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add Sysprep example
by Code Review 13 Feb '17

13 Feb '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Add Sysprep example ...................................................................... Add Sysprep example This patch adds an example that shows how to add a virtual machine and then start it with a custom Sysprep configuration file. Change-Id: I2e7c1a7ac61f2124fd9667b3cf794d441133216e Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A sdk/examples/add_vm_with_sysprep.rb 1 file changed, 85 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests Moti Asayag: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/71862 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e7c1a7ac61f2124fd9667b3cf794d441133216e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[master]: Add Sysprep example
by Code Review 13 Feb '17

13 Feb '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add Sysprep example ...................................................................... Add Sysprep example This patch adds an example that shows how to add a virtual machine and then start it with a custom Sysprep configuration file. Change-Id: I8aebe94b532cffbf146f719b531a243b6e310432 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A sdk/src/test/java/org/ovirt/engine/sdk4/examples/AddVmWithSysprep.java 1 file changed, 96 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71968 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8aebe94b532cffbf146f719b531a243b6e310432 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Add Sysprep example
by Code Review 13 Feb '17

13 Feb '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add Sysprep example ...................................................................... Add Sysprep example This patch adds an example that shows how to add a virtual machine and then start it with a custom Sysprep configuration file. Change-Id: If04f421c88aced61c6cd53611c2168e2bc920f37 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A sdk/examples/add_vm_with_sysprep.py 1 file changed, 95 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71865 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If04f421c88aced61c6cd53611c2168e2bc920f37 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: SerialChildCommandsExecutionCallback - performNextOper...
by Code Review 13 Feb '17

13 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: SerialChildCommandsExecutionCallback - performNextOperation() ...................................................................... core: SerialChildCommandsExecutionCallback - performNextOperation() In case a command fails during its execute() method execution, we shouldn't proceed to perform the next operation. Change-Id: Iae18a7502fa8019959a4264f47e65e617e83885d Bug-Url: https://bugzilla.redhat.com/1421619 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SerialChildCommandsExecutionCallback.java 1 file changed, 20 insertions(+), 14 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/72140 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae18a7502fa8019959a4264f47e65e617e83885d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0