February 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk[master]: Merge link with element if it has same name
by Code Review 09 Feb '17

09 Feb '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Merge link with element if it has same name ...................................................................... Merge link with element if it has same name This patch merges the link and element if it has same name. For example when API returns following XML: <root> <link href='/link' rel'attrs'/> <attrs> <attr id='123'/> </attrs> </root> We must ensure that both the link and element are read and merged into single attribute of Python SDK, so user can later access the 'href' of the link as well as content of the 'attr' element. Change-Id: Ied8cdd24632083967cbc5c4d5528c8c1cf02ab63 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/python/ReadersGenerator.java A sdk/tests/test_affinity_group_reader.py 2 files changed, 101 insertions(+), 7 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71784 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied8cdd24632083967cbc5c4d5528c8c1cf02ab63 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[master]: dialog: human: help debug newlines sent to logger
by Code Review 09 Feb '17

09 Feb '17

>From Yedidyah Bar David <didi(a)redhat.com>: Yedidyah Bar David has submitted this change and it was merged. Change subject: dialog: human: help debug newlines sent to logger ...................................................................... dialog: human: help debug newlines sent to logger Previous patch changed logger to handle newlines differently. When this happens, note to debug log, so that if we suspect that some output was broken by this change, it is easier to debug. Change-Id: If186d2edede3317bfcbcdc4c4ca30c200998a415 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M src/plugins/otopi/dialog/human.py 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/72021 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If186d2edede3317bfcbcdc4c4ca30c200998a415 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: opstools-ansible: add fc25 support
by Code Review 09 Feb '17

09 Feb '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: opstools-ansible: add fc25 support ...................................................................... opstools-ansible: add fc25 support Change-Id: I798374c670ded79821e2901876223c38f0a19d2f Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/opstools-ansible/opstools-ansible_create-rpms.yaml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72019 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I798374c670ded79821e2901876223c38f0a19d2f Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: upload image dialog - use host select-box
by Code Review 09 Feb '17

09 Feb '17

>From Daniel Erez <derez(a)redhat.com>: Daniel Erez has submitted this change and it was merged. Change subject: webadmin: upload image dialog - use host select-box ...................................................................... webadmin: upload image dialog - use host select-box Added 'Use Host' select-box on upload image dialog. Change-Id: I42f992afa6f5d9bf94c9caed8a7d33eb3cfc012b Bug-Url: https://bugzilla.redhat.com/1419853 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/UploadImagePopupView.ui.xml 3 files changed, 23 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/71947 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42f992afa6f5d9bf94c9caed8a7d33eb3cfc012b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Power Management restart displays misleading message.
by Code Review 09 Feb '17

09 Feb '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: webadmin: Power Management restart displays misleading message. ...................................................................... webadmin: Power Management restart displays misleading message. Rephrase message when power management restart is invoked. Change-Id: I4a5074775093b814cf9fcf58c9508f4c78657d1f Bug-Url: https://bugzilla.redhat.com/1418002 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Ravi Nori: Verified Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/71906 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a5074775093b814cf9fcf58c9508f4c78657d1f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Package list for upgrade checks has to contain only ...
by Code Review 09 Feb '17

09 Feb '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: engine: Package list for upgrade checks has to contain only valid packages per version ...................................................................... engine: Package list for upgrade checks has to contain only valid packages per version Package list for upgrade should not contain packages not available for the version. Change-Id: I85e03bee60c985772d9c326a9bd1daebb08d53dc Bug-Url: https://bugzilla.redhat.com/1418757 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85e03bee60c985772d9c326a9bd1daebb08d53dc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[master]: dialog: human: Allow newline (\n) in logger
by Code Review 09 Feb '17

09 Feb '17

>From Yedidyah Bar David <didi(a)redhat.com>: Yedidyah Bar David has submitted this change and it was merged. Change subject: dialog: human: Allow newline (\n) in logger ...................................................................... dialog: human: Allow newline (\n) in logger Motivation: Some plugins may report errors with multi lines explaining causes, ways to overcome the error and so on and we want to format it properly. Change: Stop replacing \n with a space, and add identation. Change-Id: I75485706c3e90da63061164051a0e50e250c8a6c Related-to: https://gerrit.ovirt.org/#/c/70422/ Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M src/plugins/otopi/dialog/human.py 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/70662 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75485706c3e90da63061164051a0e50e250c8a6c Gerrit-PatchSet: 5 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: clean ReadOnlyDiskModel for upload image
by Code Review 09 Feb '17

09 Feb '17

>From Daniel Erez <derez(a)redhat.com>: Daniel Erez has submitted this change and it was merged. Change subject: webadmin: clean ReadOnlyDiskModel for upload image ...................................................................... webadmin: clean ReadOnlyDiskModel for upload image ReadOnlyDiskModel is used only for UploadImageModel, hence, removing any irrelevant logic. Change-Id: Idfae91f31427f7e9476336cec5be7d2359738901 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ReadOnlyDiskModel.java 2 files changed, 5 insertions(+), 70 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71946 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idfae91f31427f7e9476336cec5be7d2359738901 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: disable upload actions when API transfer is active
by Code Review 09 Feb '17

09 Feb '17

>From Daniel Erez <derez(a)redhat.com>: Daniel Erez has submitted this change and it was merged. Change subject: webadmin: disable upload actions when API transfer is active ...................................................................... webadmin: disable upload actions when API transfer is active Disable cancel/pause/resume image upload when transferring via API is active. Change-Id: I195f4825802150efe3fa34e8cbb7dd6ad6852123 Bug-Url: https://bugzilla.redhat.com/1419886 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java 1 file changed, 11 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/71905 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I195f4825802150efe3fa34e8cbb7dd6ad6852123 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: directlun disk dialog - missing host label
by Code Review 09 Feb '17

09 Feb '17

>From Daniel Erez <derez(a)redhat.com>: Daniel Erez has submitted this change and it was merged. Change subject: webadmin: directlun disk dialog - missing host label ...................................................................... webadmin: directlun disk dialog - missing host label Added missing 'Use host' label on new disk dialog (DirectLUN tab). Change-Id: I55fba202912d8a604e18a6e0cfa4bc1959277aa4 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/71916 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55fba202912d8a604e18a6e0cfa4bc1959277aa4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0