March 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.1]: engine: add active hosts caching in NetworkClusterHelper
by Code Review 26 Mar '17

26 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: engine: add active hosts caching in NetworkClusterHelper ...................................................................... engine: add active hosts caching in NetworkClusterHelper Change-Id: I4ca0a3a1d7979ce7017d37cb3dc982464e20be26 Bug-Url: https://bugzilla.redhat.com/1431228 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterHelperTest.java 2 files changed, 98 insertions(+), 49 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/74082 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ca0a3a1d7979ce7017d37cb3dc982464e20be26 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: engine: use vdsDynamicDao instead of vdsDao
by Code Review 26 Mar '17

26 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: engine: use vdsDynamicDao instead of vdsDao ...................................................................... engine: use vdsDynamicDao instead of vdsDao Avoid using vdsDao as it uses very complicated vds view. Change-Id: I54eaaf3cb49296da8378eab37504be0064e3810b Bug-Url: https://bugzilla.redhat.com/1431228 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpdateVdsCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/74334 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54eaaf3cb49296da8378eab37504be0064e3810b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: engine: remove redundant load of NetworkCluster's in UpdateV...
by Code Review 26 Mar '17

26 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: engine: remove redundant load of NetworkCluster's in UpdateVdsCommand ...................................................................... engine: remove redundant load of NetworkCluster's in UpdateVdsCommand Change-Id: I59642de8e33d0c68dfd98dc94e6261a18d1a02b0 Bug-Url: https://bugzilla.redhat.com/1431228 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpdateVdsCommand.java 1 file changed, 2 insertions(+), 8 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/74081 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59642de8e33d0c68dfd98dc94e6261a18d1a02b0 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: engine: reuse preliminarily loaded host object in HostNicsUtil
by Code Review 26 Mar '17

26 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: engine: reuse preliminarily loaded host object in HostNicsUtil ...................................................................... engine: reuse preliminarily loaded host object in HostNicsUtil Change-Id: I1d12c0355b3ec4dcc6072296ced70ed8a446c10c Bug-Url: https://bugzilla.redhat.com/1431228 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostNicsUtil.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterHelperTest.java 3 files changed, 19 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/74083 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d12c0355b3ec4dcc6072296ced70ed8a446c10c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: engine: use HostNicsUtil instead of GetVdsInterfacesByVdsId ...
by Code Review 26 Mar '17

26 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: engine: use HostNicsUtil instead of GetVdsInterfacesByVdsId query ...................................................................... engine: use HostNicsUtil instead of GetVdsInterfacesByVdsId query Use HostNicsUtil instead of GetVdsInterfacesByVdsId query in NetworkClusterHelper. Change-Id: I2a64df138487b2ab85df1c88041c69c61b288849 Bug-Url: https://bugzilla.redhat.com/1431412 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterHelperTest.java 2 files changed, 45 insertions(+), 20 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/73917 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a64df138487b2ab85df1c88041c69c61b288849 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: engine: update commands to use the new networkClusterHelper....
by Code Review 26 Mar '17

26 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: engine: update commands to use the new networkClusterHelper.setStatus ...................................................................... engine: update commands to use the new networkClusterHelper.setStatus Update command to use the methods that gets a collection of networks instead of calling the singular method in a loop. Change-Id: I41380a5fcdf3cfc57e98e131374974cc96614d5f Bug-Url: https://bugzilla.redhat.com/1431228 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpdateVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java 4 files changed, 4 insertions(+), 12 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/74084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41380a5fcdf3cfc57e98e131374974cc96614d5f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: engine: add shortcut in DefaultReadDao.get
by Code Review 26 Mar '17

26 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: engine: add shortcut in DefaultReadDao.get ...................................................................... engine: add shortcut in DefaultReadDao.get Add shortcut in DefaultReadDao.get for input null value. Change-Id: I7dddaf2890270a0789a6176f6f4ac20d246cf688 Bug-Url: https://bugzilla.redhat.com/1431228 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DefaultReadDao.java 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/74337 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7dddaf2890270a0789a6176f6f4ac20d246cf688 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: engine: make NetworkClusterHelper a CDI bean
by Code Review 26 Mar '17

26 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: engine: make NetworkClusterHelper a CDI bean ...................................................................... engine: make NetworkClusterHelper a CDI bean * make NetworkClusterHelper methods non-static * inject NetworkClusterHelper bean in its user classes instead of creating there a new instance of it or using that statically * add NetworkClusterHelperTest Change-Id: I06861e0baefa66b840bda7eeb470f08c31f1252c Bug-Url: https://bugzilla.redhat.com/1431412 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpdateVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToClusterInternalCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkFromClusterInternalCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/UpdateNetworkOnClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/RemoveNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterHelperTest.java 11 files changed, 232 insertions(+), 59 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/73915 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06861e0baefa66b840bda7eeb470f08c31f1252c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: replace javax.ejb.Singleton with javax.inject.Singleton
by Code Review 26 Mar '17

26 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: replace javax.ejb.Singleton with javax.inject.Singleton ...................................................................... core: replace javax.ejb.Singleton with javax.inject.Singleton Change-Id: Idf5ba453840bfb0e9c0f52ea5757b577e77f9ca7 Bug-Url: https://bugzilla.redhat.com/1431412 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/MacPoolFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmNicMacsUtils.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/74359 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf5ba453840bfb0e9c0f52ea5757b577e77f9ca7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: engine: extract HostNicsUtil out of GetVdsInterfacesByVdsIdQ...
by Code Review 26 Mar '17

26 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: engine: extract HostNicsUtil out of GetVdsInterfacesByVdsIdQuery ...................................................................... engine: extract HostNicsUtil out of GetVdsInterfacesByVdsIdQuery Extract the logic from GetVdsInterfacesByVdsIdQuery into HostNicsUtil class, in order to enable re-using that easier. Change-Id: I89f5b3717f93e728178b212302553fb9e1d28f7e Bug-Url: https://bugzilla.redhat.com/1431412 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetVdsInterfacesByVdsIdQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostNicsUtil.java 2 files changed, 102 insertions(+), 81 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/73916 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89f5b3717f93e728178b212302553fb9e1d28f7e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0