Change in ovirt-engine[ovirt-engine-4.1]: engine: replace javax.ejb.Singleton with javax.inject.Singleton
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: engine: replace javax.ejb.Singleton with javax.inject.Singleton
......................................................................
engine: replace javax.ejb.Singleton with javax.inject.Singleton
Change-Id: If18c0f1307d47508e944942461745cb7bd859658
Bug-Url: https://bugzilla.redhat.com/1431412
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/FindActiveVmsUsingNetwork.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/LunHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveStorageMigrationHelper.java
3 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Martin Mucha: Looks good to me, but someone else must approve
Alona Kaplan: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/74358
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If18c0f1307d47508e944942461745cb7bd859658
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[master]: core: ExtensionsManager type inference
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: core: ExtensionsManager type inference
......................................................................
core: ExtensionsManager type inference
Change-Id: I040d224f044ec86d4c18e60c1b937ed8c345629f
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/74626
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I040d224f044ec86d4c18e60c1b937ed8c345629f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[master]: core: ExtensionsManager#initiailze local var
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: core: ExtensionsManager#initiailze local var
......................................................................
core: ExtensionsManager#initiailze local var
Removed an unused local variable.
Change-Id: I203304b2310eaadbaba09e113fa321facb729856
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java
1 file changed, 1 insertion(+), 6 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/74629
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I203304b2310eaadbaba09e113fa321facb729856
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[master]: core: ExtensionsManager private globalContext
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: core: ExtensionsManager private globalContext
......................................................................
core: ExtensionsManager private globalContext
globalContext is used as an argument to synchronize. As per Java's
best practices, it should be final, to avoid hard-to-detect race
bugs.
Change-Id: I90ff1735824fd44210faca7ba2e2832cfd0e2ff9
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/74630
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I90ff1735824fd44210faca7ba2e2832cfd0e2ff9
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[master]: core: ExtensionsManager String.format
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: core: ExtensionsManager String.format
......................................................................
core: ExtensionsManager String.format
Removed String.format calls on strings that don't have a format
specification to improve performance.
Change-Id: If346e254a12324d5aaa9dc0627b3be1599551caf
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/74628
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If346e254a12324d5aaa9dc0627b3be1599551caf
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[master]: core: ExtensionsManager redundant semicolons
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: core: ExtensionsManager redundant semicolons
......................................................................
core: ExtensionsManager redundant semicolons
Change-Id: I1956875afb79bf981e047b123fe4d25972c1422a
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/74627
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1956875afb79bf981e047b123fe4d25972c1422a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[master]: userportal, webadmin: fix context menu font size
by Code Review
>From Greg Sheremeta <gshereme(a)redhat.com>:
Greg Sheremeta has submitted this change and it was merged.
Change subject: userportal, webadmin: fix context menu font size
......................................................................
userportal, webadmin: fix context menu font size
Change-Id: Ic9cb46ed318ffa8cda90bfec9535db7a2ff7b417
Bug-Url: https://bugzilla.redhat.com/1435115
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/MainSectionView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/MainSectionView.ui.xml
2 files changed, 0 insertions(+), 2 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Greg Sheremeta: Verified
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/74610
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9cb46ed318ffa8cda90bfec9535db7a2ff7b417
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[master]: engine: made helptag scripts executable
by Code Review
>From Greg Sheremeta <gshereme(a)redhat.com>:
Greg Sheremeta has submitted this change and it was merged.
Change subject: engine: made helptag scripts executable
......................................................................
engine: made helptag scripts executable
Change-Id: I9160eb872f76feb35778d5fa82b7a045580d75ea
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M build/helptag.py
M build/helptag_checker.py
2 files changed, 0 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Greg Sheremeta: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/74453
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9160eb872f76feb35778d5fa82b7a045580d75ea
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[master]: automation: build both firefox and chrome gwt permutations
by Code Review
>From Greg Sheremeta <gshereme(a)redhat.com>:
Greg Sheremeta has submitted this change and it was merged.
Change subject: automation: build both firefox and chrome gwt permutations
......................................................................
automation: build both firefox and chrome gwt permutations
Build both firefox and chrome gwt permutations, since our QE
users use both. We discussed the performance hit via email,
and using a random engine build with low Jenkins load as an
example, this should only add 6 or less minutes to a build.
Change-Id: I476d028defcffa2757ebf3354f8f1a26ec0c6af9
JIRA-Url: https://ovirt-jira.atlassian.net/browse/OVIRT-973
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M automation/build-artifacts.sh
1 file changed, 11 insertions(+), 4 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Greg Sheremeta: Verified; Looks good to me, approved
Vojtech Szocs: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/74462
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I476d028defcffa2757ebf3354f8f1a26ec0c6af9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[master]: core: Allow TLSv1.2 for external provider communication
by Code Review
>From Martin Peřina <mperina(a)redhat.com>:
Martin Peřina has submitted this change and it was merged.
Change subject: core: Allow TLSv1.2 for external provider communication
......................................................................
core: Allow TLSv1.2 for external provider communication
Allows to use TLSv1.2 for protocol negotiation for external provider
communication.
Change-Id: I96e22228e5780ad0e63b70fb3d7dcda31c53e41d
Bug-Url: https://bugzilla.redhat.com/1421204
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
2 files changed, 4 insertions(+), 3 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Ondra Machacek: Verified
Tal Nisan: Looks good to me, approved
Martin Peřina: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/72083
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I96e22228e5780ad0e63b70fb3d7dcda31c53e41d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months