March 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.1]: tools: Remove VdsmSSLProtocol from engine-config options
by Code Review 24 Mar '17

24 Mar '17

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: tools: Remove VdsmSSLProtocol from engine-config options ...................................................................... tools: Remove VdsmSSLProtocol from engine-config options Removes VdsmSSLProtocol from engine-config options as there's no reason for users to change this value (engine will always negotiate highest available TLS version supported by VDSM on the host). Change-Id: If66d9c26b6ca7ab04a17806544fc51d1c0f28b64 Bug-Url: https://bugzilla.redhat.com/1427790 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M packaging/etc/engine-config/engine-config.properties 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/74605 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If66d9c26b6ca7ab04a17806544fc51d1c0f28b64 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: getQemuImageInfo should not call teardown on live snap...
by Code Review 24 Mar '17

24 Mar '17

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: core: getQemuImageInfo should not call teardown on live snapshot. ...................................................................... core: getQemuImageInfo should not call teardown on live snapshot. Once a live snapshot is performed the volume should already be active in the host and therefore should not be prepared and teardown when executing getQemuImageInfo. The fix for this is to check whether the VM, the disks is attached to, is running, get the host that is running on and call getQemuImageInfo with that host without the prepare and teardown. Change-Id: Iadc5d353744cffab8575e5dc4945b707cdca7d59 Bug-Url: https://bugzilla.redhat.com/1433052 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/BaseImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferImageCommand.java 3 files changed, 41 insertions(+), 5 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/74571 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iadc5d353744cffab8575e5dc4945b707cdca7d59 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Refactor qcow compat update.
by Code Review 24 Mar '17

24 Mar '17

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Refactor qcow compat update. ...................................................................... core: Refactor qcow compat update. Refactor qcow compat update to use protected method for update. Change-Id: I4f32b7757eef012d9542db4b9c8a0798134ef920 Bug-Url: https://bugzilla.redhat.com/1433052 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/BaseImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferImageCommand.java 2 files changed, 30 insertions(+), 32 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/74570 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f32b7757eef012d9542db4b9c8a0798134ef920 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: tools: Remove VdsmSSLProtocol from engine-config options
by Code Review 24 Mar '17

24 Mar '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: tools: Remove VdsmSSLProtocol from engine-config options ...................................................................... tools: Remove VdsmSSLProtocol from engine-config options Removes VdsmSSLProtocol from engine-config options as there's no reason for users to change this value (engine will always negotiate highest available TLS version supported by VDSM on the host). Change-Id: If66d9c26b6ca7ab04a17806544fc51d1c0f28b64 Bug-Url: https://bugzilla.redhat.com/1427790 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M packaging/etc/engine-config/engine-config.properties 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, approved Martin Peřina: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/74603 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If66d9c26b6ca7ab04a17806544fc51d1c0f28b64 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: aaa: Use engine FQDN even for engine <-> SSO communication
by Code Review 24 Mar '17

24 Mar '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: aaa: Use engine FQDN even for engine <-> SSO communication ...................................................................... aaa: Use engine FQDN even for engine <-> SSO communication Use engine FQDN in ENGINE_SSO_SERVICE_URL instead of localhost even though that is used only for communication between engine and SSO module Change-Id: I257ade69545e46c3dfd039e6ab7354b8bf37c47b Bug-Url: https://bugzilla.redhat.com/1426027 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/sso.py 1 file changed, 166 insertions(+), 146 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/73538 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I257ade69545e46c3dfd039e6ab7354b8bf37c47b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ExtensionProxy type inference
by Code Review 24 Mar '17

24 Mar '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: core: ExtensionProxy type inference ...................................................................... core: ExtensionProxy type inference Change-Id: I36d87eac92f5cc6a8d9c9f625c1118d1e5de88c0 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionProxy.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/74595 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36d87eac92f5cc6a8d9c9f625c1118d1e5de88c0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ebay-cors-filter: drop jobs
by Code Review 24 Mar '17

24 Mar '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: ebay-cors-filter: drop jobs ...................................................................... ebay-cors-filter: drop jobs ebay-cors-filter is now shipped within Fedora and CentOS Virt SIG. It was already not deployed within oVirt repos so no reason to keep it. Change-Id: I3ce8023e56a2ad2df8beff40c7ca25adc75899d0 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- D jobs/confs/projects/ebay-cors-filter/ebay-cors-filter.yaml M jobs/confs/yaml/templates/create-rpms_mock.yaml 2 files changed, 0 insertions(+), 28 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Barak Korren: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/74594 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ce8023e56a2ad2df8beff40c7ca25adc75899d0 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Pavel Zhukov <pzhukov(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in jenkins[master]: ovirt-release: test ppc64le on master only
by Code Review 24 Mar '17

24 Mar '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-release: test ppc64le on master only ...................................................................... ovirt-release: test ppc64le on master only CentOS is still missing some deps on ppc64le for node so the check fails there. Disabling until centos is fixed. Change-Id: I5d6afc86496b37bb29c4d0cfc9682c2defb26d33 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-release/ovirt-release_standard.yaml 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/74475 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d6afc86496b37bb29c4d0cfc9682c2defb26d33 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1.1.z]: scheduler: make task queue size configurable
by Code Review 23 Mar '17

23 Mar '17

>From Oved Ourfali <oourfali(a)redhat.com>: Oved Ourfali has submitted this change and it was merged. Change subject: scheduler: make task queue size configurable ...................................................................... scheduler: make task queue size configurable We need to make queue size used by thread executor configurable so it could be increased for bigger environments. To preserve the behavior we want to block when a queue is full. Bug-Url: https://bugzilla.redhat.com/1429534 Change-Id: Id9dc99637d73c43ad37768bc8bcdd1be8b9cb327 Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerThreadPool.java M packaging/services/ovirt-engine/ovirt-engine.conf.in M packaging/services/ovirt-engine/ovirt-engine.xml.in 3 files changed, 78 insertions(+), 4 deletions(-) Approvals: Piotr Kliczewski: Verified Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/74328 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9dc99637d73c43ad37768bc8bcdd1be8b9cb327 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1.1.z Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Lock down Extensions' API checkstyle
by Code Review 23 Mar '17

23 Mar '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: Lock down Extensions' API checkstyle ...................................................................... core: Lock down Extensions' API checkstyle Commit 879829 upgraded the project's checkstyle version in the root pom.xml. However, the extensions-api-root module does NOT inherit from the root module, even though it's in the same project, so it was not affected by this upgrade. This patch locks in the checkstyle version of that module to match the rest of the project. Change-Id: I329a72215a08ecf20658607a818a2eea2e86ae82 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/extensions-api-root/pom.xml 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/74588 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I329a72215a08ecf20658607a818a2eea2e86ae82 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0