Change in ovirt-engine[ovirt-engine-4.1.1.z]: core: Prevert running sparsify on disks on local storage
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Prevert running sparsify on disks on local storage
......................................................................
core: Prevert running sparsify on disks on local storage
Change-Id: I8b3b0c7ebda2e91c90478a8735efd401ec16fd44
Bug-Url: https://bugzilla.redhat.com/1426265
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
8 files changed, 22 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/74075
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b3b0c7ebda2e91c90478a8735efd401ec16fd44
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1.1.z
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
7 years, 6 months
Change in ovirt-engine[ovirt-engine-4.1]: core: Prevert running sparsify on disks on local storage
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Prevert running sparsify on disks on local storage
......................................................................
core: Prevert running sparsify on disks on local storage
Change-Id: I8b3b0c7ebda2e91c90478a8735efd401ec16fd44
Bug-Url: https://bugzilla.redhat.com/1426265
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
8 files changed, 22 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/74074
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b3b0c7ebda2e91c90478a8735efd401ec16fd44
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
7 years, 6 months
Change in ovirt-engine[master]: core: Prevert running sparsify on disks on local storage
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Prevert running sparsify on disks on local storage
......................................................................
core: Prevert running sparsify on disks on local storage
Change-Id: I8b3b0c7ebda2e91c90478a8735efd401ec16fd44
Bug-Url: https://bugzilla.redhat.com/1426265
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
8 files changed, 22 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/74057
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b3b0c7ebda2e91c90478a8735efd401ec16fd44
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[master]: core: Reduce scope of class member in DiskValidatorTest
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Reduce scope of class member in DiskValidatorTest
......................................................................
core: Reduce scope of class member in DiskValidatorTest
The lunDisk class member is only used in one method and can be defined
as a local variable
Change-Id: I3ca0019c950187be7b7f4ea30d86061c99fd940e
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskValidatorTest.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/74058
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3ca0019c950187be7b7f4ea30d86061c99fd940e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[master]: core: Remove redundant assignment in DiskValidatorTest
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Remove redundant assignment in DiskValidatorTest
......................................................................
core: Remove redundant assignment in DiskValidatorTest
Change-Id: Ida62d089f5667720f4c677973ac66691e2958005
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskValidatorTest.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/74059
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ida62d089f5667720f4c677973ac66691e2958005
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[ovirt-engine-4.1.1.z]: core: vm from template - revert flow
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: vm from template - revert flow
......................................................................
core: vm from template - revert flow
When failing on creation of desktop/server vm based on a template
currently there is no rollback of the created disks in case of failure
to complete the entire operation.
For server vms the rollback was never implemented while for desktop vms
the rollback isn't perform since the flow was updated to use the coco
framework (as it was performed using the SPMRevertTask).
As the endWithFailure() method is shared between the flows, this patch
adds the rollback for both.
Note that is this patch is targeted to the 4.1 branch the solution isn't
yet complete - the flow should be rewritten so that the disk is added in
transaction and then the copy flow is initiated.
In case of failure to complete the creation/copy the engine should
attempt
to remove the disk, if the removal fails the disk should remain in
ILLEGAL status so that the user will be able to attempt to delete it to
free the space used by it.
Change-Id: I530f522cd9fe064bb2844ed89f8d4877b25af0f5
Bug-Url: https://bugzilla.redhat.com/1426136
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateSnapshotFromTemplateCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
5 files changed, 41 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/74078
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I530f522cd9fe064bb2844ed89f8d4877b25af0f5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1.1.z
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
7 years, 6 months
Change in ovirt-engine[ovirt-engine-4.1]: core: vm from template - revert flow
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: vm from template - revert flow
......................................................................
core: vm from template - revert flow
When failing on creation of desktop/server vm based on a template
currently there is no rollback of the created disks in case of failure
to complete the entire operation.
For server vms the rollback was never implemented while for desktop vms
the rollback isn't perform since the flow was updated to use the coco
framework (as it was performed using the SPMRevertTask).
As the endWithFailure() method is shared between the flows, this patch
adds the rollback for both.
Note that is this patch is targeted to the 4.1 branch the solution isn't
yet complete - the flow should be rewritten so that the disk is added in
transaction and then the copy flow is initiated.
In case of failure to complete the creation/copy the engine should
attempt
to remove the disk, if the removal fails the disk should remain in
ILLEGAL status so that the user will be able to attempt to delete it to
free the space used by it.
Change-Id: I530f522cd9fe064bb2844ed89f8d4877b25af0f5
Bug-Url: https://bugzilla.redhat.com/1426136
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateSnapshotFromTemplateCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
5 files changed, 41 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/74064
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I530f522cd9fe064bb2844ed89f8d4877b25af0f5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-live[ovirt-live-4.1]: centos7: Rename dummy device to match the allowed template
by Code Review
>From Lev Veyde <lveyde(a)redhat.com>:
Lev Veyde has submitted this change and it was merged.
Change subject: centos7: Rename dummy device to match the allowed template
......................................................................
centos7: Rename dummy device to match the allowed template
dummy0 network device is renamed to dummy_0, to match the
allowed naming template of dummy_*.
Change-Id: If416a3832ad4d4f151e717f1940afd761de3c1c5
Signed-off-by: Lev Veyde <lveyde(a)redhat.com>
---
M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in
D centos-7/oVirtLiveFiles/root/etc/ovirt-host-deploy.conf.d/50-vdsm-conf-fake-nic.conf
R centos-7/oVirtLiveFiles/root/etc/sysconfig/network-scripts/ifcfg-dummy_0
M centos-7/oVirtLiveFiles/root/home/liveuser/oVirtLiveFiles/engine-setup-yad.sh
M centos-7/oVirtLiveFiles/root/usr/libexec/vdsm/hooks/before_vdsm_start/20-setupBridge.py
5 files changed, 6 insertions(+), 7 deletions(-)
Approvals:
Lev Veyde: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/74004
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If416a3832ad4d4f151e717f1940afd761de3c1c5
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-live
Gerrit-Branch: ovirt-live-4.1
Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-live[master]: centos7: Rename dummy device to match the allowed template
by Code Review
>From Lev Veyde <lveyde(a)redhat.com>:
Lev Veyde has submitted this change and it was merged.
Change subject: centos7: Rename dummy device to match the allowed template
......................................................................
centos7: Rename dummy device to match the allowed template
dummy0 network device is renamed to dummy_0, to match the
allowed naming template of dummy_*.
Change-Id: If416a3832ad4d4f151e717f1940afd761de3c1c5
Signed-off-by: Lev Veyde <lveyde(a)redhat.com>
---
M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in
D centos-7/oVirtLiveFiles/root/etc/ovirt-host-deploy.conf.d/50-vdsm-conf-fake-nic.conf
R centos-7/oVirtLiveFiles/root/etc/sysconfig/network-scripts/ifcfg-dummy_0
M centos-7/oVirtLiveFiles/root/home/liveuser/oVirtLiveFiles/engine-setup-yad.sh
M centos-7/oVirtLiveFiles/root/usr/libexec/vdsm/hooks/before_vdsm_start/20-setupBridge.py
5 files changed, 6 insertions(+), 7 deletions(-)
Approvals:
Lev Veyde: Verified; Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/74003
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If416a3832ad4d4f151e717f1940afd761de3c1c5
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-live
Gerrit-Branch: master
Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in gerrit-admin[master]: Added more logic to set_modified hook
by Code Review
>From Eyal Edri <eedri(a)redhat.com>:
Eyal Edri has submitted this change and it was merged.
Change subject: Added more logic to set_modified hook
......................................................................
Added more logic to set_modified hook
Adding more logic to check that the bug milestone is equal to the patch branch,
if it's not equal it will check that the branch (for that milestone)
doesn't exist and only then it will set the bug status to MODIFIED.
Example 1:
patch branch: ovirt-engine-4.1
bug milestone: ovirt-4.1.1 (branch doesn't exist)
result: OK ==> will change the bug status to MODIFIED
Example 2:
patch branch: ovirt-engine-4.1
bug milestone: ovirt-4.1.1 (branch exist)
result: WARN ==> bug status won't be changed to MODIFIED
(detected a newer branch 'ovirt-engine-4.1.1.z' that matches the milestone)
Change-Id: I5b6808f51bd2286089753b0afd7238c1869b4008
Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1238
Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com>
---
M hooks/custom_hooks/set_modified
1 file changed, 104 insertions(+), 20 deletions(-)
Approvals:
Shlomo Ben David: Verified
Eyal Edri: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73767
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5b6808f51bd2286089753b0afd7238c1869b4008
Gerrit-PatchSet: 2
Gerrit-Project: gerrit-admin
Gerrit-Branch: master
Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
7 years, 6 months