Change in ovirt-engine-sdk-ruby[sdk_4.1]: Install python2-lxml in Fedora 25
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Install python2-lxml in Fedora 25
......................................................................
Install python2-lxml in Fedora 25
In Fedora 25 the name of the 'lxml' package is 'python2-lxml' instead of
'python-lxml', so we need to change the '.packages.fc25' file accordingly.
Change-Id: I96ed72086249dca78e84af2a26f976e2251447a6
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit d81b2f6642a69f6170c3b23ce73eea6fd818f382)
---
M automation/build.packages.fc25
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73479
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I96ed72086249dca78e84af2a26f976e2251447a6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine-sdk-ruby[sdk_4.0]: Check that URL has been provided
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Check that URL has been provided
......................................................................
Check that URL has been provided
Currently the SDK doesn't check that the 'url' parameter has been
provided. As a unexpected errors happen later, when using the
connection, which are difficult to interpret. To avoid that this patch
changes the 'Connection' class so that it raises an exception is the
'url' parameter isn't provided.
Change-Id: I927c4097e718fe7b63e73c72bbff3c960b6387ac
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 772749b455a7601d4587e715d6a43f8a4cfbf73f)
(cherry picked from commit 5ff9103b186480ed82575f043187de400d883ecd)
---
M sdk/lib/ovirtsdk4/connection.rb
M sdk/spec/connection_create_spec.rb
2 files changed, 13 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73478
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I927c4097e718fe7b63e73c72bbff3c960b6387ac
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine-sdk-ruby[master]: Send INFO log messages with summaries of requests and responses
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Send INFO log messages with summaries of requests and responses
......................................................................
Send INFO log messages with summaries of requests and responses
Currently the SDK only sends output the log when the 'debug' parameter
is 'true', and then it sends all the HTTP traffic. This is too much
information in most production environments, so an intermediate level of
information is required. This patch changes the SDK so that it will use
the 'INFO' level so send summaries of the requests sent and the
responses received, something like this:
INFO: Sending 'GET' request to URL 'https://myserver/ovirt-engine/api/vms?search=name%3Dmyvm'.
INFO: Received response code '200'.
This will be automatically enabled when passing a 'log' parameter to the
constructor of the 'Connection' class.
Change-Id: I38a81b8e646b8a327ccc3d80738e9d95c4055fc1
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M sdk/ext/ovirtsdk4c/ov_http_client.c
1 file changed, 36 insertions(+), 0 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73134
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I38a81b8e646b8a327ccc3d80738e9d95c4055fc1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Boris Odnopozov <bodnopoz(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine-sdk-ruby[master]: Install python2-lxml in Fedora 25
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Install python2-lxml in Fedora 25
......................................................................
Install python2-lxml in Fedora 25
In Fedora 25 the name of the 'lxml' package is 'python2-lxml' instead of
'python-lxml', so we need to change the '.packages.fc25' file accordingly.
Change-Id: I96ed72086249dca78e84af2a26f976e2251447a6
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M automation/build.packages.fc25
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73476
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I96ed72086249dca78e84af2a26f976e2251447a6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine-sdk-ruby[sdk_4.1]: Check that URL has been provided
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Check that URL has been provided
......................................................................
Check that URL has been provided
Currently the SDK doesn't check that the 'url' parameter has been
provided. As a unexpected errors happen later, when using the
connection, which are difficult to interpret. To avoid that this patch
changes the 'Connection' class so that it raises an exception is the
'url' parameter isn't provided.
Change-Id: I927c4097e718fe7b63e73c72bbff3c960b6387ac
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 772749b455a7601d4587e715d6a43f8a4cfbf73f)
---
M sdk/lib/ovirtsdk4/connection.rb
M sdk/spec/connection_create_spec.rb
2 files changed, 13 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73477
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I927c4097e718fe7b63e73c72bbff3c960b6387ac
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine-sdk-ruby[master]: Check that URL has been provided
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Check that URL has been provided
......................................................................
Check that URL has been provided
Currently the SDK doesn't check that the 'url' parameter has been
provided. As a unexpected errors happen later, when using the
connection, which are difficult to interpret. To avoid that this patch
changes the 'Connection' class so that it raises an exception is the
'url' parameter isn't provided.
Change-Id: I927c4097e718fe7b63e73c72bbff3c960b6387ac
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M sdk/lib/ovirtsdk4/connection.rb
M sdk/spec/connection_create_spec.rb
2 files changed, 13 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73459
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I927c4097e718fe7b63e73c72bbff3c960b6387ac
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine-sdk-ruby[sdk_4.0]: Ignore unsupported Enum values
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Ignore unsupported Enum values
......................................................................
Ignore unsupported Enum values
If Ruby SDK is used with engine which has some new functionality
implemented, which is not supported by Ruby SDK, the Ruby SDK
should ignore those new elements.
For example if new version of API will implement new Enum value for,
RngSource, the old Ruby SDK should ignore this element, and read
only the elements the Ruby SDK understand.
Change-Id: Ice6b822548008ada589e1b78258c1611527a5df6
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
(cherry picked from commit 1ebb796edfebc0b9b58840e3a4e640c49b57c93e)
(cherry picked from commit 2de1bcb389eadb67a717e16602d3efa6c6ee60d5)
---
M generator/src/main/java/org/ovirt/sdk/ruby/ReadersGenerator.java
M sdk/lib/ovirtsdk4/reader.rb
M sdk/spec/cluster_reader_spec.rb
M sdk/spec/vm_reader_spec.rb
4 files changed, 80 insertions(+), 4 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73401
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ice6b822548008ada589e1b78258c1611527a5df6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine[master]: ui: fix few console fields to be greyed out for headless mode
by Code Review
>From Tomas Jelinek <tjelinek(a)redhat.com>:
Tomas Jelinek has submitted this change and it was merged.
Change subject: ui: fix few console fields to be greyed out for headless mode
......................................................................
ui: fix few console fields to be greyed out for headless mode
when setting a VM / Template / Pool / Instance Type as headless, the
following fields are now greyed out (were not till now):
'Monitors' label
'Single Sign On method' label
In addition, the following fields:
USB Support
Monitors
Enable SPICE file transfer
Enable SPICE clipboard copy and paste
are all left greyed out for headless even when the OS is changed to "Linux"
or "Red Hat Enterprise Linux 6.x x64 (were changed to non greyed out
till this patch).
Change-Id: Ia7f93a77cced74529b3fe194ba8746750d6ef50b
Bug-Url: https://bugzilla.redhat.com/1425124
Signed-off-by: Sharon Gratch <sgratch(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
3 files changed, 17 insertions(+), 3 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Sharon Gratch: Verified
--
To view, visit https://gerrit.ovirt.org/73364
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7f93a77cced74529b3fe194ba8746750d6ef50b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-hosted-engine-ha[v2.1.z]: build: post ovirt-hosted-engine-ha-2.1.0.4
by Code Review
>From Martin Sivák <msivak(a)redhat.com>:
Martin Sivák has submitted this change and it was merged.
Change subject: build: post ovirt-hosted-engine-ha-2.1.0.4
......................................................................
build: post ovirt-hosted-engine-ha-2.1.0.4
Change-Id: I5980dccfa71a1772cd416dccb8cc8d8fe9ef04bf
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M configure.ac
M ovirt-hosted-engine-ha.spec.in
2 files changed, 8 insertions(+), 5 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Sivák: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73385
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5980dccfa71a1772cd416dccb8cc8d8fe9ef04bf
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: v2.1.z
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
7 years, 3 months
Change in ovirt-engine[ovirt-engine-4.1]: core: Increment vm db generation when importing devices
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Increment vm db generation when importing devices
......................................................................
core: Increment vm db generation when importing devices
When importing vm devices the db generation column was
not updated.
The ovf generation process relies on this column to know
when a new ovf needs to be generated. Since the column
wasn't updated the imported devices were not included in
the ovf.
Change-Id: I0fe8c7a350e417db1ce0ba273a7d470a89afbe69
Bug-Url: https://bugzilla.redhat.com/1416846
Signed-off-by: Jenny Tokar <jtokar(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDaoImpl.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoring.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoringTest.java
M packaging/dbscripts/vms_sp.sql
5 files changed, 48 insertions(+), 10 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
Jenny Tokar: Verified
--
To view, visit https://gerrit.ovirt.org/73343
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0fe8c7a350e417db1ce0ba273a7d470a89afbe69
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months