March 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk[sdk_4.1]: [maven-release-plugin] prepare release 4.1.1
by Code Review 02 Mar '17

02 Mar '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: [maven-release-plugin] prepare release 4.1.1 ...................................................................... [maven-release-plugin] prepare release 4.1.1 Change-Id: I5ae36bd0a3bfe54cb021353c3f9275c005c423ea Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M generator/pom.xml M pom.xml M sdk/pom.xml 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/73427 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ae36bd0a3bfe54cb021353c3f9275c005c423ea Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[sdk_4.1]: Update to model 4.1.31
by Code Review 02 Mar '17

02 Mar '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Update to model 4.1.31 ...................................................................... Update to model 4.1.31 The more relevant changes in the new version of the model are the following: * Add `auto_storage_select` attribute to the `VmPool` type. * Move `vnic_profile_mappings` and `reassign_bad_macs` from the `import` operation to the `register` operation * Add IPv6 details to the `NicConfiguration` type. * Add NFS 4.2 support. Change-Id: Ib56e13b41c5caef83887ddb6f87a59dbbb92a0bc Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/73390 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib56e13b41c5caef83887ddb6f87a59dbbb92a0bc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[master]: Update to model 4.2.6 and metamodel 1.2.0
by Code Review 02 Mar '17

02 Mar '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Update to model 4.2.6 and metamodel 1.2.0 ...................................................................... Update to model 4.2.6 and metamodel 1.2.0 The more relevant changes in the new version of the model are the following: * Add `auto_storage_select` attribute to the `VmPool` type. * Move `vnic_profile_mappings` and `reassign_bad_macs` from the `import` operation to the `register` operation * Add `all_content` parameter to snapshots services. * Add `default_route` value to the `NetworkUsage` enum. * Add IPv6 details to the `NicConfiguration` type. * Add NFS 4.2 support. Change-Id: Ib56e13b41c5caef83887ddb6f87a59dbbb92a0bc Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M pom.xml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/73389 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib56e13b41c5caef83887ddb6f87a59dbbb92a0bc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.1]: Update CHANGES.adoc for release 4.1.1
by Code Review 02 Mar '17

02 Mar '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Update CHANGES.adoc for release 4.1.1 ...................................................................... Update CHANGES.adoc for release 4.1.1 Change-Id: Ib3772fc0e706cdb8ecd2a97d4a55e2e0f30d590f Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M sdk/CHANGES.adoc 1 file changed, 36 insertions(+), 2 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/73426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3772fc0e706cdb8ecd2a97d4a55e2e0f30d590f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: simplify Collection.forEach calls
by Code Review 02 Mar '17

02 Mar '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: simplify Collection.forEach calls ...................................................................... core: simplify Collection.forEach calls Remove calls to Collection.stream when it isn't neccessary. Change-Id: I21d50678b061e6ca605ae3b85eddd5b6cd6f8ad3 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HostMaintenanceCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/GetDefaultAllowedOriginsQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/KatelloProvider.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/IpConfigurationCompleter.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AddVmNumaNodesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/SetVmNumaNodesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/ConnectStorageToVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/OvfHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandCtorsTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/NetworkDeviceHelperImplTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/DeactivateStorageDomainCommandTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StepDaoTest.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3OperatingSystemOutAdapter.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmMigrationProgressMonitoring.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 18 files changed, 18 insertions(+), 24 deletions(-) Approvals: Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Verified; Looks good to me, approved Arik Hadas: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/73292 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21d50678b061e6ca605ae3b85eddd5b6cd6f8ad3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: replace lambda with Comparator.comparing
by Code Review 02 Mar '17

02 Mar '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: engine: replace lambda with Comparator.comparing ...................................................................... engine: replace lambda with Comparator.comparing Change-Id: Ieaf602d864f3ec12e39a3511b3fbdad1384f5c1f Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionWeightPolicyUnitTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Arik Hadas: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, but someone else must approve Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/73291 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieaf602d864f3ec12e39a3511b3fbdad1384f5c1f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: replace lambda with Comparator.comparingInt
by Code Review 02 Mar '17

02 Mar '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: engine: replace lambda with Comparator.comparingInt ...................................................................... engine: replace lambda with Comparator.comparingInt Change-Id: I5a73f9d96231e9c00372b1fd0b0e54136f18ad60 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/BasicWeightSelectorPolicyUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/RankSelectorPolicyUnit.java 3 files changed, 8 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Arik Hadas: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, but someone else must approve Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/73290 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a73f9d96231e9c00372b1fd0b0e54136f18ad60 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: replace lambda with Comparator.naturalOrder
by Code Review 02 Mar '17

02 Mar '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: engine: replace lambda with Comparator.naturalOrder ...................................................................... engine: replace lambda with Comparator.naturalOrder Change-Id: If7ad49ae99a87084ad1c6c7715103dbe65ccfb01 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DataCenterCompatibilityChecker.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/73289 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7ad49ae99a87084ad1c6c7715103dbe65ccfb01 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: missing validation
by Code Review 02 Mar '17

02 Mar '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. Change subject: core: missing validation ...................................................................... core: missing validation passthrough vNIC profile disallows network filter usage. Change-Id: I628346554cf732067a26911be573dd2d46619e1e Bug-Url: https://bugzilla.redhat.com/1411666 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVnicProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVnicProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VnicProfileValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VnicProfileValidatorTest.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 45 insertions(+), 20 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71806 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I628346554cf732067a26911be573dd2d46619e1e Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: Add specialized validation for Long values
by Code Review 02 Mar '17

02 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Add specialized validation for Long values ...................................................................... webadmin: Add specialized validation for Long values This patch adds a LongValidation class to provide validation of Long values. Previously, the EditQuotaClusterModel and EditQuotaStorageModel classes used the IntegerValidation class to validate some Long type values, which resulted in mistakes such as those detailed in https://bugzilla.redhat.com/1423468. Change-Id: Ieddd09396be5bdb113bec430afa71913715130db Bug-Url: https://bugzilla.redhat.com/1423468 Signed-off-by: Tony Wang <Sline798(a)gmail.com> Signed-off-by: Phillip Bailey <phbailey(a)redhat.com> --- A backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/LongCompat.java A backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/LongCompatTest.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Compat.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/EditQuotaClusterModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/EditQuotaStorageModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/LongValidation.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages.properties 8 files changed, 140 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/73421 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieddd09396be5bdb113bec430afa71913715130db Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0