Change in ovirt-engine[ovirt-engine-4.1]: core: Monitor devices only for vms that are already in the db
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Monitor devices only for vms that are already in the db
......................................................................
core: Monitor devices only for vms that are already in the db
Before this fix vm devices hash was stored in an internal cache
for all vms that were reported by vdsm no matter if they were
present in the engine db at the time.
This caused problems with hosted engine vm that was imported
after the device hash was saved in the cache. Since device monitoring
relies on this cache and there was no change in the hash reported
from vdsm and the hash in the cache the devices weren't imported.
This patch allows monitoring caching info only for vms that already
exist in the db and so solves this issue.
Change-Id: Ib011ac5c7f28de7891b0b6e3c09b107679c1ff29
Bug-Url: https://bugzilla.redhat.com/1425108
Signed-off-by: Jenny Tokar <jtokar(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/PollVmStatsRefresher.java
1 file changed, 7 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
Jenny Tokar: Verified
--
To view, visit https://gerrit.ovirt.org/73424
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib011ac5c7f28de7891b0b6e3c09b107679c1ff29
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine[ovirt-engine-4.1]: core: CommandCallbacksPoller - set the command correlation id
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: CommandCallbacksPoller - set the command correlation id
......................................................................
core: CommandCallbacksPoller - set the command correlation id
This patch updates the CommandCallbacksPoller to set the command
correlation id before executing the needed callback method in order to
be able to track the flow easily in the logs.
Change-Id: Ib934bf4421a7fbf890b5c006263ff559b9d88462
Bug-Url: https://bugzilla.redhat.com/1428346
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCallbacksPoller.java
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/73440
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib934bf4421a7fbf890b5c006263ff559b9d88462
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine[ovirt-engine-4.1]: core: Backend - set the parent correlation id
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Backend - set the parent correlation id
......................................................................
core: Backend - set the parent correlation id
When command is executed as a child command the correlation id should be
derived from the parent parameters to ease tracking the flow in the
logs.
Change-Id: Iaea59a769f6a44051340a9b9247f27fc5fc76be3
Bug-Url: https://bugzilla.redhat.com/1428346
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/73441
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaea59a769f6a44051340a9b9247f27fc5fc76be3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine[ovirt-engine-4.1]: core: MoveImageGroup - remove image correlation id
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: MoveImageGroup - remove image correlation id
......................................................................
core: MoveImageGroup - remove image correlation id
This patch changes the MoveImageGroup command to pass the correlation id
to the executed RemoveImage to ease tracking the entire flow in the log.
Change-Id: I31141ac43903ce723c3549efe4f58aa99f62e2a1
Bug-Url: https://bugzilla.redhat.com/1428346
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/MoveImageGroupCommand.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/73442
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I31141ac43903ce723c3549efe4f58aa99f62e2a1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine[ovirt-engine-4.1]: restapi: Update to model 4.1.31
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Update to model 4.1.31
......................................................................
restapi: Update to model 4.1.31
The more relevant changes in this new version of the model are the
following:
* Add `auto_storage_select` attribute to the `VmPool` type.
* Move `vnic_profile_mappings` and `reassign_bad_macs` from
the `import` operation to the `register` operation.
Change-Id: I9ce11fe08ce8e539d7d8cf74d0a284bda7de2d2b
Related-To: https://bugzilla.redhat.com/1425731
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M pom.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ondra Machacek: Looks good to me, but someone else must approve
Shahar Havivi: Looks good to me, approved
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73434
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ce11fe08ce8e539d7d8cf74d0a284bda7de2d2b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
7 years, 3 months
Change in ovirt-engine-sdk-java[sdk_4.1]: [maven-release-plugin] prepare for next development iteration
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: [maven-release-plugin] prepare for next development iteration
......................................................................
[maven-release-plugin] prepare for next development iteration
Change-Id: I078ed4503db1212b88a764f916458ae5fdf4854a
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M generator/pom.xml
M pom.xml
M sdk/pom.xml
3 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73436
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I078ed4503db1212b88a764f916458ae5fdf4854a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine-sdk-java[sdk_4.1]: [maven-release-plugin] prepare release 4.1.1
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: [maven-release-plugin] prepare release 4.1.1
......................................................................
[maven-release-plugin] prepare release 4.1.1
Change-Id: I8f2c076dc874453ce8312b33e5e281102262c07d
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M generator/pom.xml
M pom.xml
M sdk/pom.xml
3 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73435
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8f2c076dc874453ce8312b33e5e281102262c07d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-engine-sdk-java[sdk_4.1]: Update CHANGES.adoc for release 4.1.1
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Update CHANGES.adoc for release 4.1.1
......................................................................
Update CHANGES.adoc for release 4.1.1
Change-Id: Ibb2ea37e94548bbe23418bb70c8791ef20f4dfd1
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M sdk/CHANGES.adoc
1 file changed, 28 insertions(+), 2 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73432
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb2ea37e94548bbe23418bb70c8791ef20f4dfd1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-host-deploy[ovirt-host-deploy-1.6]: build: post ovirt-host-deploy-1.6.2
by Code Review
>From Yedidyah Bar David <didi(a)redhat.com>:
Yedidyah Bar David has submitted this change and it was merged.
Change subject: build: post ovirt-host-deploy-1.6.2
......................................................................
build: post ovirt-host-deploy-1.6.2
Change-Id: I18ebef1bcbf1da3fb3ee9a882773d05e58612e22
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M ChangeLog
M automation/build-artifacts.sh
M configure.ac
3 files changed, 6 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/73430
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I18ebef1bcbf1da3fb3ee9a882773d05e58612e22
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: ovirt-host-deploy-1.6
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in ovirt-host-deploy[ovirt-host-deploy-1.6]: build: ovirt-host-deploy-1.6.2
by Code Review
>From Yedidyah Bar David <didi(a)redhat.com>:
Yedidyah Bar David has submitted this change and it was merged.
Change subject: build: ovirt-host-deploy-1.6.2
......................................................................
build: ovirt-host-deploy-1.6.2
Change-Id: I196a0dd671df7cbcddcc204cbee404eeea2abb13
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M ChangeLog
M automation/build-artifacts.sh
M configure.ac
M ovirt-host-deploy.spec.in
4 files changed, 8 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/73429
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I196a0dd671df7cbcddcc204cbee404eeea2abb13
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: ovirt-host-deploy-1.6
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months