Change in ovirt-release[master]: Makefile.am: Use tabspaces 8 instead of 2
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Makefile.am: Use tabspaces 8 instead of 2
......................................................................
Makefile.am: Use tabspaces 8 instead of 2
Historically, Makefile.am contains a tab, which standardized
at every multiple of 8.
https://en.wikipedia.org/wiki/Tab_key
Change-Id: I8803ae1995a0bac860d45b5e8ff4160aea6490be
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M Makefile.am
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Douglas Schilling Landgraf: Verified
Sandro Bonazzola: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/75712
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8803ae1995a0bac860d45b5e8ff4160aea6490be
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br>
Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in ovirt-host-deploy[master]: Removing closeup stage from vdsm config plugin.
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Removing closeup stage from vdsm config plugin.
......................................................................
Removing closeup stage from vdsm config plugin.
Code was reintroduced by mistake, possibly after a bad rebase.
Change-Id: I41926056987faa98f44b388e13dc731275e3dce7
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
---
M src/plugins/ovirt-host-deploy/vdsm/config.py
1 file changed, 0 insertions(+), 10 deletions(-)
Approvals:
Douglas Schilling Landgraf: Looks good to me, but someone else must approve
Sandro Bonazzola: Looks good to me, approved
Eli Mesika: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Leon Goldberg: Verified
Dan Kenigsberg: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/75355
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I41926056987faa98f44b388e13dc731275e3dce7
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br>
Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in ovirt-release[master]: host: Enable libvirtd service in the preset
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: host: Enable libvirtd service in the preset
......................................................................
host: Enable libvirtd service in the preset
Change-Id: Idc484a8eb97476969d29c440f04fb025c597f35f
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1443965
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M host-node/systemd/system-preset/98-ovirt-host-node.preset
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified
Sandro Bonazzola: Looks good to me, approved; Passed CI tests
Yuval Turgeman: Looks good to me, but someone else must approve
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/75701
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idc484a8eb97476969d29c440f04fb025c597f35f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in jenkins[master]: qemu: drop 3.6 and 4.0 jobs
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: qemu: drop 3.6 and 4.0 jobs
......................................................................
qemu: drop 3.6 and 4.0 jobs
both 3.6 and 4.0 has gone EOL long ago, dropping
qemu jobs left around.
Change-Id: I797cbee88edcab615988540e38f2b2d027681371
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M jobs/confs/projects/qemu/qemu_create-rpms.yaml
1 file changed, 0 insertions(+), 20 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/75698
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I797cbee88edcab615988540e38f2b2d027681371
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
7 years
Change in ovirt-engine[master]: core: make the unmanaged usb controller to be managed
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: make the unmanaged usb controller to be managed
......................................................................
core: make the unmanaged usb controller to be managed
The issue:
- a VM is started on an older (pre 4.0) engine
- in this engine, if the USB is configured as disabled, no USB device is sent
to VDSM
- libvirt reacts by creating a new unmanaged USB controller
- this controller appears in engine as an unmanaged device
- after updating the engine, update of all VMs is called to modify the devices
according to the need of the new engine
- this code adds a managed USB controller
- in this stage, this VM has 2 USB controllers, one managed and one unmanaged
- from this point, anytime the USB devices are about to be touched (e.g.
creating a new template from this VM or from a snapshot of the VM) a sanity
check checking that there is only 1 USB controller fails throwing an exception
The fix is to detect that the unmanaged device is the one created by
libvirt and adopt it as ours.
Another issue:
If there are two usb controller for the VM:
* managed, unplugged
* unmanaged, plugged
and a snapshot is made and then previewed, the VM has two managed usb
controllers. It is caused by the fact that OVF doesn't store 'managed'
flag.
To mitigate this, every time normal usb controllers are updated and
there are more then one managed controller, all controllers are removed
and the proper one is recreated.
Change-Id: I74f516530e9be5887b12720f0cdaee4618a9e9c9
Bug-Url: https://bugzilla.redhat.com/1438188
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
1 file changed, 55 insertions(+), 13 deletions(-)
Approvals:
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/75133
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I74f516530e9be5887b12720f0cdaee4618a9e9c9
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in ovirt-engine[master]: tests: fix StartVdsCommandTest
by Code Review
>From Martin Peřina <mperina(a)redhat.com>:
Martin Peřina has submitted this change and it was merged.
Change subject: tests: fix StartVdsCommandTest
......................................................................
tests: fix StartVdsCommandTest
This patch fixes the StartVdsCommandTest, which was broken by
patch: If872dcab32f8e0f9c2806a64552cf7c6ff28a4b1
Change-Id: I44d53964e2788160fb5a087502d2eeebf091aadf
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/pm/StartVdsCommandTest.java
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Ondra Machacek: Verified
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/75709
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I44d53964e2788160fb5a087502d2eeebf091aadf
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in ovirt-hosted-engine-ha[master]: jsonrpc: reuse existing connection
by Code Review
>From Martin Sivák <msivak(a)redhat.com>:
Martin Sivák has submitted this change and it was merged.
Change subject: jsonrpc: reuse existing connection
......................................................................
jsonrpc: reuse existing connection
Keep a connection reference at module level to be
reused by future requests if still valid.
Change-Id: I82e8b842096f54ae74d62bcd48c079fa7b4a1b1d
Requires: https://gerrit.ovirt.org/58029
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1417708
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M ovirt_hosted_engine_ha/lib/util.py
1 file changed, 67 insertions(+), 31 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Sivák: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73757
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I82e8b842096f54ae74d62bcd48c079fa7b4a1b1d
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in ovirt-engine[master]: webadmin: Fix of max memory validation
by Code Review
>From Tomas Jelinek <tjelinek(a)redhat.com>:
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: Fix of max memory validation
......................................................................
webadmin: Fix of max memory validation
Previously it didn't block the confirmation of then VM dialog when
invalid.
Change-Id: Iae65b29977f3ac7808029f5d2dc29488c8582fa4
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/75527
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iae65b29977f3ac7808029f5d2dc29488c8582fa4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in ovirt-engine[ovirt-engine-4.1]: aaa: User can no longer use API having password with special...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: aaa: User can no longer use API having password with special character "+"
......................................................................
aaa: User can no longer use API having password with special character "+"
The request parameters are automatically
decoded to UTF-8 format when content type
and encoding are specified in the request.
It is not necessary to decode them on the
SSO end again.
Change-Id: I03d3ca6a8f75b72ad014681cd99dca5ec3e5d1a4
Bug-Url: https://bugzilla.redhat.com/1443645
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthAuthorizeServlet.java
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoUtils.java
2 files changed, 5 insertions(+), 17 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Ravi Nori: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/75694
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I03d3ca6a8f75b72ad014681cd99dca5ec3e5d1a4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in ovirt-engine[ovirt-engine-4.1]: engine: adding transaction bounderies to heart beat logging
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: engine: adding transaction bounderies to heart beat logging
......................................................................
engine: adding transaction bounderies to heart beat logging
We don't have exact boundary for transaction commit in
DwhHeartBeat.engineIsRunningNotification, so even if we
log correctly, the real database commit may be performed
later if db is too busy
Change-Id: Ib9009b5f41538bafd15fd4cc1d8a57c54556bf1c
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1430666
Signed-off-by: emesika <emesika(a)redhat.com>
(cherry picked from commit cf8072cc9b5038dc9ae887034aaa8fda48041d44)
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/dwh/DwhHeartBeat.java
1 file changed, 7 insertions(+), 2 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Eli Mesika: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/75686
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9009b5f41538bafd15fd4cc1d8a57c54556bf1c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years