April 2017 - Engine-commits - oVirt List Archives

Change in ovirt-host-deploy[ovirt-host-deploy-1.6]: vdsm: fix config decorator
by Code Review 20 Apr '17

20 Apr '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: vdsm: fix config decorator ...................................................................... vdsm: fix config decorator With patch https://gerrit.ovirt.org/53531 a OVIRT_VINTAGE_NODE specific condition has been introduced but it wasn't effective since the old decorator was still in place. With patch https://gerrit.ovirt.org/71599 the initial decorator has been removed but now it raises an issue with AIO plugin for oVirt Live. Restoring the initial decorator. Change-Id: I89c6d505558eb049a1d373ae1e1cb710d3c8d920 Bug-Url: https://bugzilla.redhat.com/1443064 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-host-deploy/vdsm/config.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75666 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89c6d505558eb049a1d373ae1e1cb710d3c8d920 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: ovirt-host-deploy-1.6 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: aaa: User can no longer use API having password with special...
by Code Review 20 Apr '17

20 Apr '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: aaa: User can no longer use API having password with special character "+" ...................................................................... aaa: User can no longer use API having password with special character "+" The request parameters are automatically decoded to UTF-8 format when content type and encoding are specified in the request. It is not necessary to decode them on the SSO end again. Change-Id: I03d3ca6a8f75b72ad014681cd99dca5ec3e5d1a4 Bug-Url: https://bugzilla.redhat.com/1443645 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthAuthorizeServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoUtils.java 2 files changed, 5 insertions(+), 17 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75668 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03d3ca6a8f75b72ad014681cd99dca5ec3e5d1a4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: publisher: drop 4.0 publisher
by Code Review 19 Apr '17

19 Apr '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: publisher: drop 4.0 publisher ...................................................................... publisher: drop 4.0 publisher 4.0 has gone EOL long ago, no further development is planned for 4.0 branches. Removing the publisher as first step toward removing all 4.0 jobs. Change-Id: I5359419c9757ef7a0b3c11d03c4521abe67f379c Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- D jobs/confs/projects/ovirt/publish-rpms-nightly-4.0.yaml M jobs/confs/yaml/builders/copy-create-job-artifact.yaml 2 files changed, 0 insertions(+), 178 deletions(-) Approvals: Sandro Bonazzola: Verified; Ready for review Eyal Edri: Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5359419c9757ef7a0b3c11d03c4521abe67f379c Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: vdsm: fix config decorator
by Code Review 19 Apr '17

19 Apr '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: vdsm: fix config decorator ...................................................................... vdsm: fix config decorator With patch https://gerrit.ovirt.org/53531 a OVIRT_VINTAGE_NODE specific condition has been introduced but it wasn't effective since the old decorator was still in place. With patch https://gerrit.ovirt.org/71599 the initial decorator has been removed but now it raises an issue with AIO plugin for oVirt Live. Restoring the initial decorator. Change-Id: I89c6d505558eb049a1d373ae1e1cb710d3c8d920 Bug-Url: https://bugzilla.redhat.com/1443064 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-host-deploy/vdsm/config.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/74025 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89c6d505558eb049a1d373ae1e1cb710d3c8d920 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: running create_functions.sql upon setup
by Code Review 19 Apr '17

19 Apr '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: running create_functions.sql upon setup ...................................................................... core: running create_functions.sql upon setup This patch fix an issue when only create_functions.sql was modified (for example adding a new function) In the case that this is the only change, the engine-setup will not recognize the change and the new function will not be created. The fix adds the create_functions.sql file to the list of files of which we have a MD5 sum that is used to track changes in thoise files. Change-Id: I60222b1fb61e2ef76788774cd59d096d4a1b4a31 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1432095 Signed-off-by: emesika <emesika(a)redhat.com> (cherry picked from commit b5a819de8216b2d226cf370ecd83914303584956) --- M packaging/dbscripts/dbfunc-common.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, approved Eli Mesika: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75575 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60222b1fb61e2ef76788774cd59d096d4a1b4a31 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: adding transaction bounderies to heart beat logging
by Code Review 19 Apr '17

19 Apr '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: engine: adding transaction bounderies to heart beat logging ...................................................................... engine: adding transaction bounderies to heart beat logging We don't have exact boundary for transaction commit in DwhHeartBeat.engineIsRunningNotification, so even if we log correctly, the real database commit may be performed later if db is too busy Change-Id: Ib9009b5f41538bafd15fd4cc1d8a57c54556bf1c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1430666 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/dwh/DwhHeartBeat.java 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Eli Mesika: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/74661 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9009b5f41538bafd15fd4cc1d8a57c54556bf1c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove leftover SPICE channel on RunVM
by Code Review 19 Apr '17

19 Apr '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: Remove leftover SPICE channel on RunVM ...................................................................... core: Remove leftover SPICE channel on RunVM After run of VM with SPICE graphics device the SPICEVMC channel remained in the vm_device table even after the VM has been long recofigured to not use SPICE. Since we don't want to remove this device prematurely, we extended the pre-vm-run device handling to also remove stray channels in the RunVmCommand. Change-Id: Ie2159a3ba247cabe2002dd9e9043126b65b3dd42 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1430688 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Verified Sharon Gratch: Looks good to me, but someone else must approve Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/75315 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2159a3ba247cabe2002dd9e9043126b65b3dd42 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin, userportal: Remove unused popup classes
by Code Review 19 Apr '17

19 Apr '17

>From Greg Sheremeta <gshereme(a)redhat.com>: Greg Sheremeta has submitted this change and it was merged. Change subject: webadmin,userportal: Remove unused popup classes ...................................................................... webadmin,userportal: Remove unused popup classes Remove unused SimplePopupPanel and its parents, all the dialogs should use SimpleDialogPanel. Change-Id: I6a7c752b764e4a96578031c9fa71734739205177 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/DialogBoxWithKeyHandlers.java D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/ResizableDialogBox.java D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimplePopupPanel.java D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimplePopupPanel.ui.xml 4 files changed, 0 insertions(+), 251 deletions(-) Approvals: Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/75610 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a7c752b764e4a96578031c9fa71734739205177 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: restapi: Update to model 4.1.35 and metamodel 1.1.14
by Code Review 19 Apr '17

19 Apr '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: restapi: Update to model 4.1.35 and metamodel 1.1.14 ...................................................................... restapi: Update to model 4.1.35 and metamodel 1.1.14 The more relevant changes in this new version of the model are the following: * Replace generic assigned networks services with services specific to the type of object that they are assigned to, in particular data centers and clusters. * Add `driver` attribute to `HostDevice` type. * Add common concepts document. * Add appendix containing changes from version 3 to version 4 of the API. * Add `readOnly` attribute to the `DiskAttachment` type. * Fix the type of the `Host.nics` link. It should be of type `HostNic[]`, not `Nic[]`. The replacement of generic assigned networks service with specific ones requires a significant refactor of the resources in that area. The changes in the new version of the metadel affect only the Java SDK, not the engine, but it is good practice to keep using the latest version. Change-Id: Ibef405d6f19330f61cb5ec7193c860557fcfb47b Related-To: https://bugzilla.redhat.com/1390498 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworkResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterNetworkResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterNetworksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/LinkHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3NICHelper.java R backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3ClusterNetworkServer.java R backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3ClusterNetworksServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3ClusterServer.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3DataCenterNetworkServer.java C backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3DataCenterNetworksServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3DataCenterServer.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterNetworksResourceTest.java M pom.xml 16 files changed, 195 insertions(+), 46 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75394 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibef405d6f19330f61cb5ec7193c860557fcfb47b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: disable dashboard data if DWH isn't available
by Code Review 19 Apr '17

19 Apr '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: disable dashboard data if DWH isn't available ...................................................................... webadmin: disable dashboard data if DWH isn't available Two checks are made to verify DWH configuration. First, the engine DWH config table is verified. Second, the ability of the JNDI managed DWH DataSource to create a DB connection is verified. If either test fails, the query caching and direct queries are disabled. The change will eliminate error logging for developers who don't need to work with DWH components. Bug-Url: https://bugzilla.redhat.com/1441857 Change-Id: I7e42b9e32b32ee75e6d1d290c187d35e1e784926 Signed-off-by: Scott J Dickerson <sdickers(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/DashboardDataServlet.java 1 file changed, 76 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved Scott Dickerson: Verified -- To view, visit https://gerrit.ovirt.org/75652 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e42b9e32b32ee75e6d1d290c187d35e1e784926 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0