April 2017 - Engine-commits - oVirt List Archives

Change in ovirt-guest-agent[master]: systemd: Add dependency on qemu-guest-agent service
by Code Review 20 Apr '17

20 Apr '17

>From Vinzenz Feenstra <vfeenstr(a)redhat.com>: Vinzenz Feenstra has submitted this change and it was merged. Change subject: systemd: Add dependency on qemu-guest-agent service ...................................................................... systemd: Add dependency on qemu-guest-agent service Change-Id: I0d288e8265b440df9f4b091c240d853eefabb895 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/ovirt-guest-agent.service 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved; Passed CI tests Tomas Golembiovsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/75672 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d288e8265b440df9f4b091c240d853eefabb895 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Corrected validation for geo-rep
by Code Review 20 Apr '17

20 Apr '17

>From Sahina Bose <sabose(a)redhat.com>: Sahina Bose has submitted this change and it was merged. Change subject: webadmin: Corrected validation for geo-rep ...................................................................... webadmin: Corrected validation for geo-rep AsciiName validation is not required for volume as this is a volume entity selection Change-Id: I640936d741456bc13977946272a0c3afddf6ced6 Bug-Url: https://bugzilla.redhat.com/1440071 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeGeoRepCreateModel.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Denis Chaplygin: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Sahina Bose: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/75573 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I640936d741456bc13977946272a0c3afddf6ced6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: jsonrpc: version bump
by Code Review 20 Apr '17

20 Apr '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: jsonrpc: version bump ...................................................................... jsonrpc: version bump Bug-Url: https://bugzilla.redhat.com/1438784 Change-Id: Iec706ed7f4df03a84304075be6c2e6111a5b472f Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> --- M ovirt-engine.spec.in M pom.xml 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Verified Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75677 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec706ed7f4df03a84304075be6c2e6111a5b472f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: restapi: Expose `driver` field of host devices
by Code Review 20 Apr '17

20 Apr '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: restapi: Expose `driver` field of host devices ...................................................................... restapi: Expose `driver` field of host devices Change-Id: I9dcdfa0b069655629ef0fae0959188631b2da9d2 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1430673 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostDeviceMapper.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Verified -- To view, visit https://gerrit.ovirt.org/75408 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9dcdfa0b069655629ef0fae0959188631b2da9d2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: add vm exit reason of type unknown
by Code Review 20 Apr '17

20 Apr '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: add vm exit reason of type unknown ...................................................................... core: add vm exit reason of type unknown When restoring a backup, the status and run_on_vds fields of the VM do not represent the actual information of the running VM. This may lead of unneeded restart of highly-available VMs that would cause a split-brain. Therefore, we decide to switch highly-available VMs to down when restoring a backup. But none of the existing exit reasons fit for this flow: Error would cause the VM to be restarted when the engine starts, and Normal doesn't reflect the situation properly since the VM was not shut-down properly. Thus, we add a new exit reason for this case, called Unknown. The whole purpose of this value, for now, is to prevent the automatic VM restart mechanism to skip VMs set with this value. Change-Id: I40710a943c60dbdbbdf9e8e9563afc121d1d632a Bug-Url: https://bugzilla.redhat.com/1441322 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmExitStatus.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/75510 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40710a943c60dbdbbdf9e8e9563afc121d1d632a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: pm: Wait for host to boot when executing start operation
by Code Review 20 Apr '17

20 Apr '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: pm: Wait for host to boot when executing start operation ...................................................................... pm: Wait for host to boot when executing start operation Previously when start fence action was executed we didn't wait for the host to boot. This may cause an issue when the host take too long to boot, so the host monitoring code will be re-executing the fence operation and the host will never boot. This patch handle the issue, so we now wait ServerRebootTimeout, after the 'start' operation is executed and after this timeout the host status is changed properly. Change-Id: If872dcab32f8e0f9c2806a64552cf7c6ff28a4b1 Bug-Url: https://bugzilla.redhat.com/1423657 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/StartVdsCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/pm/StartVdsCommandTest.java 2 files changed, 3 insertions(+), 4 deletions(-) Approvals: Ondra Machacek: Verified Martin Peřina: Looks good to me, approved Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75577 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If872dcab32f8e0f9c2806a64552cf7c6ff28a4b1 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin:Filter out duplicate LUN id exposed through multipl...
by Code Review 20 Apr '17

20 Apr '17

>From Maor Lipchuk <mlipchuk(a)redhat.com>: Maor Lipchuk has submitted this change and it was merged. Change subject: webadmin:Filter out duplicate LUN id exposed through multiple targets. ...................................................................... webadmin:Filter out duplicate LUN id exposed through multiple targets. Connecting the same LUN through multiple targets using the GUI sends the same LUN id multiple times for each target. Duplicate LUN ids should be filtered out before the engine calls createVG. Change-Id: I696bfdb660f3361d47427c610cda53c6c0942d11 Bug-Url: https://bugzilla.redhat.com/1441706 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 2 files changed, 6 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/75596 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I696bfdb660f3361d47427c610cda53c6c0942d11 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[master]: deps: gdeploy: changed copr repository
by Code Review 20 Apr '17

20 Apr '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: deps: gdeploy: changed copr repository ...................................................................... deps: gdeploy: changed copr repository Ramesh left Red Hat and will not be maintaining his repository any longer. Sac is the main developer of Gdeploy and is working on getting the package in Fedora before it can get included in the CentOS Storage SIG. Until the packages are in the repositories from the distributions, the COPR at https://copr.fedorainfracloud.org/coprs/sac/gdeploy/ contains the latest builds. Change-Id: I07f08892b3f3ffa7f9719e99993c2a7b199ac81f Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-el7-ppc64le-deps.repo.in M ovirt-el7-x86_64-deps.repo.in M ovirt-f25-deps.repo.in 3 files changed, 12 insertions(+), 12 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests Niels de Vos: Looks good to me, but someone else must approve Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/75670 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07f08892b3f3ffa7f9719e99993c2a7b199ac81f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Niels de Vos <ndevos(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: added new reports: free mem, overridden compatibility_version
by Code Review 20 Apr '17

20 Apr '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: added new reports: free mem, overridden compatibility_version ...................................................................... added new reports: free mem, overridden compatibility_version • every hosts will report vds.mem_available • if there is at least one VM, which has different vds_group_compatibility_version/cluster_compatibility_version than one defined in related vds_group/cluster record, new section "VMs with overridden cluster compatibility version" will be added to report, reporting all such networks Change-Id: I01e1929b42904b98ba905cd5eb3d9d0c0e8a28f6 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M src/inventory_report/produceReport.sh 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, approved Martin Mucha: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75574 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01e1929b42904b98ba905cd5eb3d9d0c0e8a28f6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Publishers: standard publisher- Added support to export find...
by Code Review 20 Apr '17

20 Apr '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: Publishers: standard publisher- Added support to export findbugs.xml ...................................................................... Publishers: standard publisher- Added support to export findbugs.xml Instead of having separated job for findbugs, this will integrate the plugin with all of the std ci jobs. Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-536 Change-Id: Ie24ad7d533e2c037fb569cf8172061107c24703f Signed-off-by: Daniel Belenky <dbelenky(a)redhat.com> --- M jobs/confs/yaml/publishers/standard.yaml 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me Eyal Edri: Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests Daniel Belenky: Verified; Ready for review -- To view, visit https://gerrit.ovirt.org/75459 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie24ad7d533e2c037fb569cf8172061107c24703f Gerrit-PatchSet: 6 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0