April 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: StorageDiskListModel generics
by Code Review 13 Apr '17

13 Apr '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: StorageDiskListModel generics ...................................................................... webadmin: StorageDiskListModel generics The items in a StorageDiskListModel are the DiskImages that reside on the StorageDomain. This patch fixes its generic specification to reflect this fact (and saves a cast while its at it). Change-Id: Iec69df16cb27998ce5e396581e01f0a21021787b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDiskListModel.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/75502 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec69df16cb27998ce5e396581e01f0a21021787b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Don't use Linq#cast in TemplateStorageListModel
by Code Review 13 Apr '17

13 Apr '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Don't use Linq#cast in TemplateStorageListModel ...................................................................... webadmin: Don't use Linq#cast in TemplateStorageListModel Linq#cast redundantly creates a new ArrayList with the same objects as the source collection has. This is, at best, an O(n) operation and usually even worse, as the ArrayList's internal array needs to be reallocated several times. This patch removes the calls to Linq#cast in TemplateStorageListModel and replaces them with explicit casts per element of the source collection where needed. Change-Id: Id441a97c601229a0abd0a7f61b8d2ff4c66437dc Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateStorageListModel.java 1 file changed, 14 insertions(+), 14 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75501 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id441a97c601229a0abd0a7f61b8d2ff4c66437dc Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Set qcow compat for floating QCOW volumes.
by Code Review 13 Apr '17

13 Apr '17

>From Maor Lipchuk <mlipchuk(a)redhat.com>: Maor Lipchuk has submitted this change and it was merged. Change subject: core: Set qcow compat for floating QCOW volumes. ...................................................................... core: Set qcow compat for floating QCOW volumes. Unregistered disks should be set with QCOW compat returned from the storage domain. Addition to this fix are the following changes: 1) use the register with multiple action to prevent a use case which VDSM will be non responsive. 2) Use non transactive in register disk so VDSM call will not hang the transaction. 3) Adding an audit log indicating the initial of register disk. Change-Id: I45f10a82fdf05737c952a6ffdbf0aaab48de9ff4 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/GetUnregisteredDiskQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/RegisterDiskCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/RegisterDiskModel.java 5 files changed, 97 insertions(+), 18 deletions(-) Approvals: Jenkins CI: Passed CI tests Maor Lipchuk: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/75374 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45f10a82fdf05737c952a6ffdbf0aaab48de9ff4 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Properly handle spicevmc redirs on USB support change
by Code Review 13 Apr '17

13 Apr '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: Properly handle spicevmc redirs on USB support change ...................................................................... core: Properly handle spicevmc redirs on USB support change After VM run with SPICE + USB enabled there were left several devices of type 'redirdev' which were unmanaged by the engine, and remained in the vm_device table even after the VM has been reconfigured to VNC (or USB disabled). This patch modifies the VmDeviceUtils#disableSpiceUsb to also clear the 'redirdev' SPICEVMC devices from the DB. To this end it was necessary to add new 'REDIRDEV' VmDeviceGeneralType - since the VmDeviceDao always treats the device 'type' in terms of this enum. Change-Id: Ib7013e8aa82a6b96802d37d6dcc9babffac37703 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1430688 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDeviceGeneralType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java 3 files changed, 22 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/75050 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7013e8aa82a6b96802d37d6dcc9babffac37703 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: cold-merge: Update step message to include the host name
by Code Review 13 Apr '17

13 Apr '17

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: cold-merge: Update step message to include the host name ...................................................................... cold-merge: Update step message to include the host name After the host running the merge snapshot command is chosen, update the step message to show the host name. Change-Id: Ie069edb8de1b54b6804f578bbce9169f5be97701 Bug-Url: https://bugzilla.redhat.com/1420401 Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/utils/VdsCommandsHelper.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/StepEnum.java M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties 3 files changed, 41 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Ala Hino: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/75505 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie069edb8de1b54b6804f578bbce9169f5be97701 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[master]: repos: added tested repository
by Code Review 13 Apr '17

13 Apr '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: repos: added tested repository ...................................................................... repos: added tested repository Added a new subpackage providing tested repository. Change-Id: Ia67c46bb47ff80eb0e51e1b2a0b940c057574c22 Bug-Url: https://bugzilla.redhat.com/1427045 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M Makefile.am M configure.ac M ovirt-release-master.spec.in A ovirt-tested.repo.in 4 files changed, 60 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests Barak Korren: Looks good to me, but someone else must approve Marek Libra: Looks good to me, but someone else must approve Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/75431 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia67c46bb47ff80eb0e51e1b2a0b940c057574c22 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core, webadmin: Memory hot unplug enabled
by Code Review 12 Apr '17

12 Apr '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core, webadmin: Memory hot unplug enabled ...................................................................... core, webadmin: Memory hot unplug enabled ... for Intels since 4.1 and for ppc since 4.2 (https://bugzilla.redhat.com/1323417) Memory hot unplug by decrementing VM memory is disabled - VmCommonUtils#isMemoryToBeHotplugged changed. Change-Id: I4c6ccc5865332c8c7d3e44b242035a3a374880d0 Bug-Url: https://bugzilla.redhat.com/1228543 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmChangedFieldsForNextRunQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmCommonUtils.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 7 files changed, 10 insertions(+), 23 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/73692 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c6ccc5865332c8c7d3e44b242035a3a374880d0 Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: cold-merge: Update step message to include the host name
by Code Review 12 Apr '17

12 Apr '17

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: cold-merge: Update step message to include the host name ...................................................................... cold-merge: Update step message to include the host name After the host running the merge snapshot command is chosen, update the step message to show the host name. Change-Id: Ie069edb8de1b54b6804f578bbce9169f5be97701 Bug-Url: https://bugzilla.redhat.com/1420401 Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/utils/VdsCommandsHelper.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/StepEnum.java M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties 3 files changed, 41 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Ala Hino: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/72921 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie069edb8de1b54b6804f578bbce9169f5be97701 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: rpc: Version bump
by Code Review 12 Apr '17

12 Apr '17

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: rpc: Version bump ...................................................................... rpc: Version bump Bug-Url: https://bugzilla.redhat.com/1112120 Change-Id: Ifb82cae6d57e09cbd9c75363b0c025074030fe7f Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/dependencies/common/src/main/modules/org/ovirt/vdsm-jsonrpc-java/main/module.xml M ovirt-engine.spec.in M pom.xml 3 files changed, 3 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Verified Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75333 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb82cae6d57e09cbd9c75363b0c025074030fe7f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[master]: Improve error message for wrong content type
by Code Review 12 Apr '17

12 Apr '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Improve error message for wrong content type ...................................................................... Improve error message for wrong content type Currently when the user specifies an incorrect URL path the SDK sends requests to the server anyhow, and it tries to parse the response body as XML, without checking the response content type. This generates error messages that don't explain the root cause of the problem. To improve that this patch changes the SDK so that it checks the content type of the responses and generates error messages that explain better the failure. For example, if the user specifies an incorrect URL path like '/ugly', the SDK will try to contact the server and will raise an exception containing the following error message: The response content type 'text/html; charset=iso-8859-1' isn't the expected XML. Is the path '/ugly' included in the 'url' parameter correct? The typical one is '/ovirt-engine/api' Change-Id: Ifc46f16fa65673bfde76d3ccc62dd5c3492cc289 Related-To: https://bugzilla.redhat.com/1440292 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/src/main/java/org/ovirt/engine/sdk4/internal/HttpConnection.java 1 file changed, 47 insertions(+), 1 deletion(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75435 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc46f16fa65673bfde76d3ccc62dd5c3492cc289 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0