April 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-java[sdk_4.1]: Improve error message for wrong content type
by Code Review 12 Apr '17

12 Apr '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Improve error message for wrong content type ...................................................................... Improve error message for wrong content type Currently when the user specifies an incorrect URL path the SDK sends requests to the server anyhow, and it tries to parse the response body as XML, without checking the response content type. This generates error messages that don't explain the root cause of the problem. To improve that this patch changes the SDK so that it checks the content type of the responses and generates error messages that explain better the failure. For example, if the user specifies an incorrect URL path like '/ugly', the SDK will try to contact the server and will raise an exception containing the following error message: The response content type 'text/html; charset=iso-8859-1' isn't the expected XML. Is the path '/ugly' included in the 'url' parameter correct? The typical one is '/ovirt-engine/api' Change-Id: Ifc46f16fa65673bfde76d3ccc62dd5c3492cc289 Related-To: https://bugzilla.redhat.com/1440292 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/src/main/java/org/ovirt/engine/sdk4/internal/HttpConnection.java 1 file changed, 47 insertions(+), 1 deletion(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75488 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc46f16fa65673bfde76d3ccc62dd5c3492cc289 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: FenceVolumeJob - avoiding growing number of db records
by Code Review 12 Apr '17

12 Apr '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: FenceVolumeJob - avoiding growing number of db records ...................................................................... core: FenceVolumeJob - avoiding growing number of db records FenceVolumeJob is executed in order to fence operations that were submitted and are supposed to be performed on the volume. In case of failure to fence an operation, the engine may attempt to fence it again - when the fencing fails constantly the number of commands will grow till the flow ends. As we store a record for each command in the commands table that's something should be prevented. The engine uses the command record just for polling (to avoid executing another fence operation before the previous one ended) and not for determining if the fencing succeeded (it polls the entity to verify that), therefore we are fine with deleting the command entity after the execution ends. Change-Id: I62659c3840ce4bc46f7846751d45b779f3606279 Bug-Url: https://bugzilla.redhat.com/1440549 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/FenceVolumeJobCommand.java 2 files changed, 24 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/75474 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62659c3840ce4bc46f7846751d45b779f3606279 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.1]: Improve error message for wrong content type
by Code Review 12 Apr '17

12 Apr '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Improve error message for wrong content type ...................................................................... Improve error message for wrong content type Currently when the user specifies an incorrect URL path the SDK sends requests to the server anyhow, and it tries to parse the response body as XML, without checking the response content type. This generates error messages that don't explain the root cause of the problem. To improve that this patch changes the SDK so that it checks the content type of the responses and generates error messages that explain better the failure. For example, if the user specifies an incorrect URL path like '/ugly', the SDK will try to contact the server and will raise an exception containing the following error message: The response content type 'text/html; charset=iso-8859-1' isn't the expected XML. Is the path '/ugly' included in the 'url' parameter correct? The typical one is '/ovirt-engine/api' Change-Id: I548ae621a025969fe2dbf086f49ba83ea52fc28f Bug-Url: https://bugzilla.redhat.com/1440292 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit 5c1b391547a2c9d962818e0b31ba9bbb57b5e593) --- M sdk/lib/ovirtsdk4/__init__.py M sdk/tests/server.py 2 files changed, 62 insertions(+), 1 deletion(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75487 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I548ae621a025969fe2dbf086f49ba83ea52fc28f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Improve error message for wrong content type
by Code Review 12 Apr '17

12 Apr '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Improve error message for wrong content type ...................................................................... Improve error message for wrong content type Currently when the user specifies an incorrect URL path the SDK sends requests to the server anyhow, and it tries to parse the response body as XML, without checking the response content type. This generates error messages that don't explain the root cause of the problem. To improve that this patch changes the SDK so that it checks the content type of the responses and generates error messages that explain better the failure. For example, if the user specifies an incorrect URL path like '/ugly', the SDK will try to contact the server and will raise an exception containing the following error message: The response content type 'text/html; charset=iso-8859-1' isn't the expected XML. Is the path '/ugly' included in the 'url' parameter correct? The typical one is '/ovirt-engine/api' Change-Id: I548ae621a025969fe2dbf086f49ba83ea52fc28f Bug-Url: https://bugzilla.redhat.com/1440292 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M sdk/lib/ovirtsdk4/__init__.py M sdk/tests/server.py 2 files changed, 62 insertions(+), 1 deletion(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75433 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I548ae621a025969fe2dbf086f49ba83ea52fc28f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.1]: Improve error message for wrong content type
by Code Review 12 Apr '17

12 Apr '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Improve error message for wrong content type ...................................................................... Improve error message for wrong content type Currently when the user specifies an incorrect URL path the SDK sends requests to the server anyhow, and it tries to parse the response body as XML, without checking the response content type. This generates error messages that don't explain the root cause of the problem. To improve that this patch changes the SDK so that it checks the content type of the responses and generates error messages that explain better the failure. For example, if the user specifies an incorrect URL path like '/ugly', the SDK will try to contact the server and will raise an exception containing the following error message: The response content type 'text/html; charset=iso-8859-1' isn't the expected XML. Is the path '/ugly' included in the 'url' parameter correct? The typical one is '/ovirt-engine/api' Change-Id: I71857a3762288f6bb8f8fdda70ba0b2f88e75e83 Related-To: https://bugzilla.redhat.com/1440292 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit ac41e70bbb168a16e55c03be27f2047ce2b9624e) --- M sdk/lib/ovirtsdk4/connection.rb 1 file changed, 51 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75485 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71857a3762288f6bb8f8fdda70ba0b2f88e75e83 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.1 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.1]: Convert header names to lower case
by Code Review 12 Apr '17

12 Apr '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Convert header names to lower case ...................................................................... Convert header names to lower case This patch changes the SDK so that HTTP response header names are always converted to lower case. That is needed in order to simplify the code that handles headers, so that it can directly get them from the headers hash instead of iterating it. Change-Id: Id3ad00646a8c4d9906c80c29d0baf13c1b9a427e Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 87da2121083c02783b672baf08e3c4b938c66289) --- M sdk/ext/ovirtsdk4c/ov_http_client.c 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75484 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3ad00646a8c4d9906c80c29d0baf13c1b9a427e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.1 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: Remove unused VmNicValidator#getDbFacade() method
by Code Review 12 Apr '17

12 Apr '17

>From Martin Betak <mbetak(a)redhat.com>: Martin Betak has submitted this change and it was merged. Change subject: backend: Remove unused VmNicValidator#getDbFacade() method ...................................................................... backend: Remove unused VmNicValidator#getDbFacade() method Change-Id: I0003ecc53cb44095325030521b4bb8a22a4a3c6e Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmNicValidator.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Martin Betak: Verified Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/75379 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0003ecc53cb44095325030521b4bb8a22a4a3c6e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Improve error message for wrong content type
by Code Review 12 Apr '17

12 Apr '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Improve error message for wrong content type ...................................................................... Improve error message for wrong content type Currently when the user specifies an incorrect URL path the SDK sends requests to the server anyhow, and it tries to parse the response body as XML, without checking the response content type. This generates error messages that don't explain the root cause of the problem. To improve that this patch changes the SDK so that it checks the content type of the responses and generates error messages that explain better the failure. For example, if the user specifies an incorrect URL path like '/ugly', the SDK will try to contact the server and will raise an exception containing the following error message: The response content type 'text/html; charset=iso-8859-1' isn't the expected XML. Is the path '/ugly' included in the 'url' parameter correct? The typical one is '/ovirt-engine/api' Change-Id: I71857a3762288f6bb8f8fdda70ba0b2f88e75e83 Related-To: https://bugzilla.redhat.com/1440292 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/lib/ovirtsdk4/connection.rb 1 file changed, 51 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75402 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71857a3762288f6bb8f8fdda70ba0b2f88e75e83 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Convert header names to lower case
by Code Review 12 Apr '17

12 Apr '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Convert header names to lower case ...................................................................... Convert header names to lower case This patch changes the SDK so that HTTP response header names are always converted to lower case. That is needed in order to simplify the code that handles headers, so that it can directly get them from the headers hash instead of iterating it. Change-Id: Id3ad00646a8c4d9906c80c29d0baf13c1b9a427e Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/ext/ovirtsdk4c/ov_http_client.c 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75401 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3ad00646a8c4d9906c80c29d0baf13c1b9a427e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: Revert "core: refactoring: Inject Async Operation dependencies"
by Code Review 12 Apr '17

12 Apr '17

>From Tomas Jelinek <tjelinek(a)redhat.com>: Tomas Jelinek has submitted this change and it was merged. Change subject: Revert "core: refactoring: Inject Async Operation dependencies" ...................................................................... Revert "core: refactoring: Inject Async Operation dependencies" This reverts commit 9a01113125f91e9fdae5b4eb5253a071591d2b7b. Change-Id: I6194e6dc31ec455a8861678dc9bc0c3adf240850 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AfterDeactivateSingleAsyncOperation.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AfterDeactivateSingleAsyncOperationFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/ConntectVDSToPoolAndDomains.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/DisconnectStoragePoolAsyncOperation.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/DisconnectStoragePoolAsyncOperationFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/RefreshPoolSingleAsyncOperation.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/RefreshStoragePoolAndDisconnectAsyncOperation.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/RefreshStoragePoolAndDisconnectAsyncOperationFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/RemoveStoragePoolCommand.java 9 files changed, 41 insertions(+), 111 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75472 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6194e6dc31ec455a8861678dc9bc0c3adf240850 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0