April 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Linq#distinct signature
by Code Review 12 Apr '17

12 Apr '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Linq#distinct signature ...................................................................... webadmin: Linq#distinct signature Use the interface List in Linq#distinct's signature instead of the concrete ArrayList implementation. This method makes no assumption on the List's implementation, and there's no reason to limit it to ArrayLists only. Change-Id: I69745aa0f5d22fa05b9fa22cc85df898de44ea35 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/75446 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69745aa0f5d22fa05b9fa22cc85df898de44ea35 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Remove Linq#concat
by Code Review 12 Apr '17

12 Apr '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Remove Linq#concat ...................................................................... webadmin: Remove Linq#concat Linq#concat is a poor implementation of an uncommon general-purpose contract. This patch removes its single usage (in IconValidation), and replaces it with a better performing non-general implementation. Change-Id: Ib982a6524d2c0ce1249eafb1accddcb36e00ac2c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/IconValidation.java 2 files changed, 3 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/75456 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib982a6524d2c0ce1249eafb1accddcb36e00ac2c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Remove Linq#concatUnsafe
by Code Review 12 Apr '17

12 Apr '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Remove Linq#concatUnsafe ...................................................................... webadmin: Remove Linq#concatUnsafe This patch replaces the usage of Linq#concatUnsafe in GuidePopupView with a better inline implementation using Java 8 streams which avoids the need to create a temporary concatinated list. As a result of this improvement, Linq#concatUnsafe is no longer used, and can safely be removed. Change-Id: I0340a9a0ca6a5ec7f88c488b982f7dae93944ef6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/guide/GuidePopupView.java 2 files changed, 6 insertions(+), 20 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/75457 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0340a9a0ca6a5ec7f88c488b982f7dae93944ef6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Remove Linq#except
by Code Review 12 Apr '17

12 Apr '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Remove Linq#except ...................................................................... webadmin: Remove Linq#except Remove Linq#except's naive implementation and replace the one place it was used, RoleListModel, with a better performing List#removeAll call. Change-Id: I48fb2401f026fce1fb6688bd2094b120f1462cca Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleListModel.java 2 files changed, 6 insertions(+), 28 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/75454 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48fb2401f026fce1fb6688bd2094b120f1462cca Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Reimplement AbstractUserPortalListModel#onVmAndPoo...
by Code Review 12 Apr '17

12 Apr '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Reimplement AbstractUserPortalListModel#onVmAndPoolLoad ...................................................................... webadmin: Reimplement AbstractUserPortalListModel#onVmAndPoolLoad This patch reimplements onVmAndPoolLoad using Java 8's stream capabilities. Using streams allows for a continuous processing of the data the method retrieves and improves performance by avoiding allocating temporary lists for each step of the process. Linq.zip, which is left unused as a consequence of these changes, is also removed as part of this patch. Change-Id: Idf62b40e6b528b7c30e222f53b709e2d3d8ba944 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/AbstractUserPortalListModel.java 2 files changed, 12 insertions(+), 24 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/75455 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf62b40e6b528b7c30e222f53b709e2d3d8ba944 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Linq#toEntityModelList ctor use
by Code Review 12 Apr '17

12 Apr '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Linq#toEntityModelList ctor use ...................................................................... webadmin: Linq#toEntityModelList ctor use This patch reuses the EntityModel(T) constructor instead of reimplementing its logic. Change-Id: I9c7028151f60177b1213a15fd52e3773a53ad162 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/75452 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c7028151f60177b1213a15fd52e3773a53ad162 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Inline Linq#toEntityModelList
by Code Review 12 Apr '17

12 Apr '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Inline Linq#toEntityModelList ...................................................................... webadmin: Inline Linq#toEntityModelList This patch inlines Linq#toEntityModelList to the single place that actually uses it, AttachDiskModel. As an added bonus, it reimplements the series of calls there to use a single stream instead of constructing a temporary ArrayList for each logical step of processing the original list, thus improving performance. Change-Id: Id0c2d92a3084cd5ab8657f5681f045c229db8d0d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AttachDiskModel.java 2 files changed, 7 insertions(+), 13 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/75453 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0c2d92a3084cd5ab8657f5681f045c229db8d0d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: FenceVolumeJob - avoiding growing number of db records
by Code Review 12 Apr '17

12 Apr '17

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: core: FenceVolumeJob - avoiding growing number of db records ...................................................................... core: FenceVolumeJob - avoiding growing number of db records FenceVolumeJob is executed in order to fence operations that were submitted and are supposed to be performed on the volume. In case of failure to fence an operation, the engine may attempt to fence it again - when the fencing fails constantly the number of commands will grow till the flow ends. As we store a record for each command in the commands table that's something should be prevented. The engine uses the command record just for polling (to avoid executing another fence operation before the previous one ended) and not for determining if the fencing succeeded (it polls the entity to verify that), therefore we are fine with deleting the command entity after the execution ends. Change-Id: I62659c3840ce4bc46f7846751d45b779f3606279 Bug-Url: https://bugzilla.redhat.com/1440549 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/FenceVolumeJobCommand.java 2 files changed, 24 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/75390 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62659c3840ce4bc46f7846751d45b779f3606279 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Win 10 x64 guest OS inherits from Win 8 x64
by Code Review 12 Apr '17

12 Apr '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Win 10 x64 guest OS inherits from Win 8 x64 ...................................................................... core: Win 10 x64 guest OS inherits from Win 8 x64 Previously it inherited from Win 10 (32bit) which wrongly brought 32bit memory limit. Memory limit updated for Windows 10 x64 - 2TB https://msdn.microsoft.com/en-us/library/windows/desktop/ aa366778(v=vs.85).aspx#physical_memory_limits_windows_10 Change-Id: I88184644b28fbfa32894d5eb4b95c3ecc8b0c88f Bug-Url: https://bugzilla.redhat.com/1439216 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M packaging/conf/osinfo-defaults.properties 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/75410 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88184644b28fbfa32894d5eb4b95c3ecc8b0c88f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: Fix small typos in error messages
by Code Review 12 Apr '17

12 Apr '17

>From Simone Tiraboschi <stirabos(a)redhat.com>: Simone Tiraboschi has submitted this change and it was merged. Change subject: Fix small typos in error messages ...................................................................... Fix small typos in error messages Change-Id: I0ff0b3f28a1e966c79a05c32d833b0e224ca0366 Signed-off-by: Yaniv Kaul <ykaul(a)redhat.com> --- M src/ovirt_hosted_engine_setup/engineapi.py 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Simone Tiraboschi: Looks good to me, approved Yaniv Kaul: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75208 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ff0b3f28a1e966c79a05c32d833b0e224ca0366 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0