Change in ovirt-engine[ovirt-engine-4.1]: core: make the unmanaged usb controller to be managed
by Code Review
>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>:
Piotr Kliczewski has submitted this change and it was merged.
Change subject: core: make the unmanaged usb controller to be managed
......................................................................
core: make the unmanaged usb controller to be managed
The issue:
- a VM is started on an older (pre 4.0) engine
- in this engine, if the USB is configured as disabled, no USB device is sent
to VDSM
- libvirt reacts by creating a new unmanaged USB controller
- this controller appears in engine as an unmanaged device
- after updating the engine, update of all VMs is called to modify the devices
according to the need of the new engine
- this code adds a managed USB controller
- in this stage, this VM has 2 USB controllers, one managed and one unmanaged
- from this point, anytime the USB devices are about to be touched (e.g.
creating a new template from this VM or from a snapshot of the VM) a sanity
check checking that there is only 1 USB controller fails throwing an exception
The fix is to detect that the unmanaged device is the one created by
libvirt and adopt it as ours.
Another issue:
If there are two usb controller for the VM:
* managed, unplugged
* unmanaged, plugged
and a snapshot is made and then previewed, the VM has two managed usb
controllers. It is caused by the fact that OVF doesn't store 'managed'
flag.
To mitigate this, every time normal usb controllers are updated and
there are more then one managed controller, all controllers are removed
and the proper one is recreated.
Change-Id: I74f516530e9be5887b12720f0cdaee4618a9e9c9
Bug-Url: https://bugzilla.redhat.com/1438188
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
1 file changed, 55 insertions(+), 13 deletions(-)
Approvals:
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/75713
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I74f516530e9be5887b12720f0cdaee4618a9e9c9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in jenkins[master]: Fix SDK jobs not having proper cleanup steps
by Code Review
>From Barak Korren <bkorren(a)redhat.com>:
Barak Korren has submitted this change and it was merged.
Change subject: Fix SDK jobs not having proper cleanup steps
......................................................................
Fix SDK jobs not having proper cleanup steps
Change-Id: I87b3669d2a8ab4d603922f769e7750d04b650971
Signed-off-by: Barak Korren <bkorren(a)redhat.com>
Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1354
---
M jobs/confs/yaml/templates/standard-stage.yaml
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Barak Korren: Verified; Looks good to me, approved; Ready for merge
Gil Shinar: Looks good to me
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/76137
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I87b3669d2a8ab4d603922f769e7750d04b650971
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
7 years, 7 months
Change in ovirt-engine[master]: core: fix run vm
by Code Review
>From Eli Mesika <emesika(a)redhat.com>:
Eli Mesika has submitted this change and it was merged.
Change subject: core: fix run vm
......................................................................
core: fix run vm
This was caused as a result od squashing patch that put the wrong value
in the address column of vm_device table.
Change-Id: I494c30b284264c6996c015f5ca29101f3ce87295
Signed-off-by: emesika <emesika(a)redhat.com>
---
M packaging/dbscripts/data/01200_insert_vm_device.sql
1 file changed, 8 insertions(+), 8 deletions(-)
Approvals:
Eli Mesika: Verified
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76139
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I494c30b284264c6996c015f5ca29101f3ce87295
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: webadmin: handle VmDynamic.fqdn==null in SubTabNetworkVmView
by Code Review
>From Tomas Jelinek <tjelinek(a)redhat.com>:
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: handle VmDynamic.fqdn==null in SubTabNetworkVmView
......................................................................
webadmin: handle VmDynamic.fqdn==null in SubTabNetworkVmView
In case VmDynamic.fqdn is set to null value, there is a "is null"
exception thrown by SafeHtmlString while trying to create the fqdn
tooltip in fqdnColumn.getTooltip() method.
Avoiding that by passing an empty str instead of a null value.
Change-Id: Ib27f4090bd51b15f48d37cf1dfdecbde2b5f2811
Bug-Url: https://bugzilla.redhat.com/1442697
Signed-off-by: Sharon Gratch <sgratch(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkVmView.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Sharon Gratch: Verified
--
To view, visit https://gerrit.ovirt.org/76133
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib27f4090bd51b15f48d37cf1dfdecbde2b5f2811
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[master]: core: Free VM lock if attaching a VM from pool failed
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: Free VM lock if attaching a VM from pool failed
......................................................................
core: Free VM lock if attaching a VM from pool failed
If VM is allocated to user from a VM Pool and the VM is not prestarted,
lock is taken on it early to prevent race condition between
AttachUserToVmFromPoolAndRunCommand and VmPoolMonitor. In regular flow,
this lock is freed by RunVmCommand. But if validation of
AttachUserToVmFromPoolAndRunCommand is failed or exception is thrown for
some reason, this lock must be freed explicitly.
Change-Id: I6d13d3196dd7e2557390675066e0b861071d846f
Bug-Url: https://bugzilla.redhat.com/1433924
Bug-Url: https://bugzilla.redhat.com/1432105
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java
1 file changed, 11 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/75508
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6d13d3196dd7e2557390675066e0b861071d846f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[master]: core: minor cleanup in vms monitoring
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: minor cleanup in vms monitoring
......................................................................
core: minor cleanup in vms monitoring
Add getVmManager method.
Change-Id: I69a760818fe868b9a46b74e0ffb516df3c043df6
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java
1 file changed, 8 insertions(+), 4 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/76034
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I69a760818fe868b9a46b74e0ffb516df3c043df6
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[master]: core: cleanup in SetVmStatus
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: cleanup in SetVmStatus
......................................................................
core: cleanup in SetVmStatus
1. This command is called internally from just a few places so
we can remove the validation of the parameters at the beginning
of the execute method.
2. This command is not used for setting the VM status to Unknown
thus the code for this specific case is removed.
3. This command is only used to set the VM status to Down or
ImageLocked, in both statuses the VM is not running, thus its
execute method can be simplified.
Change-Id: I724544f8063e04a7a5405a8e5cc25abea87c3b42
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/SetVmStatusVDSCommand.java
1 file changed, 5 insertions(+), 21 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/76033
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I724544f8063e04a7a5405a8e5cc25abea87c3b42
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-host-deploy[ovirt-host-deploy-1.6]: metrics: Make collectd/fluentd packages optional
by Code Review
>From Yedidyah Bar David <didi(a)redhat.com>:
Yedidyah Bar David has submitted this change and it was merged.
Change subject: metrics: Make collectd/fluentd packages optional
......................................................................
metrics: Make collectd/fluentd packages optional
Emit a warning if they are missing but do not fail deploy.
Change-Id: Ic2df4e82c92cfbf6c7df15c1ceca0600626e4385
Bug-Url: https://bugzilla.redhat.com/1443508
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
(cherry picked from commit d3e77e7ae4c29ae5a9ea35e43cfc835dac117cd7)
---
M src/plugins/ovirt-host-deploy/collectd/packages.py
M src/plugins/ovirt-host-deploy/fluentd/packages.py
2 files changed, 34 insertions(+), 12 deletions(-)
Approvals:
Ido Rosenzwig: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76098
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2df4e82c92cfbf6c7df15c1ceca0600626e4385
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: ovirt-host-deploy-1.6
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine-sdk[sdk_4.1]: Add list of build packages for Fedora 25
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Add list of build packages for Fedora 25
......................................................................
Add list of build packages for Fedora 25
This patch adds the 'build.packages.fc25' file containing the list of
packages needed by the automation environment to build in Fedora 25.
Change-Id: I0c9712c363e6bdbdda73526c51a8c8effa6f9660
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
A automation/build-artifacts.packages.fc25
A automation/build.packages.fc25
A automation/check-merged.packages.fc25
A automation/check-patch.packages.fc25
4 files changed, 26 insertions(+), 0 deletions(-)
Approvals:
Ondra Machacek: Looks good to me, approved
Juan Hernandez: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/76111
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0c9712c363e6bdbdda73526c51a8c8effa6f9660
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[master]: engine: Remove dead code
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Remove dead code
......................................................................
engine: Remove dead code
Change-Id: I1a1b948dc15ee9a6385aacd4df304e5da8dd5cae
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceQueryBase.java
1 file changed, 0 insertions(+), 26 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
Moti Asayag: Verified
--
To view, visit https://gerrit.ovirt.org/75332
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a1b948dc15ee9a6385aacd4df304e5da8dd5cae
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months