Change in ovirt-release[ovirt-4.1]: host: Enable libvirtd service in the preset
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: host: Enable libvirtd service in the preset
......................................................................
host: Enable libvirtd service in the preset
Change-Id: Idc484a8eb97476969d29c440f04fb025c597f35f
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1443965
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
(cherry picked from commit 4c0c8da6a69e9502f311a1bcfb006ec112034555)
---
M host-node/systemd/system-preset/98-ovirt-host-node.preset
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests
Yuval Turgeman: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/75721
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idc484a8eb97476969d29c440f04fb025c597f35f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-release
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br>
Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in ovirt-engine[master]: core: Allow to deactivate an Inactive domain
by Code Review
>From Liron Aravot <laravot(a)redhat.com>:
Liron Aravot has submitted this change and it was merged.
Change subject: core: Allow to deactivate an Inactive domain
......................................................................
core: Allow to deactivate an Inactive domain
The Inactive status is used to mark a domain as in problem. We can conclude
that there's a problem with a domain by inspecting the monitoring results retrieved
from the data center hosts.
Deactivating a domain essentially means to stop monitoring the domain, that's currently
allowed what the domain is Active, but we may want to stop monitor it when there's
a problem with it (and it's in Inactive status) as well.
This patch removes the limitation on doing so and adds attempt to perform ovf update
on the domain OVF stores, as we may still have access to the domain even if it's on Inactive
status (so the OVF update may succeed).
Change-Id: I92bd086020b9f90089b24c67ea1b1c3cf4149d9f
Bug-Url: https://bugzilla.redhat.com/1445753
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/DeactivateStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/DeactivateStorageDomainWithOvfUpdateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBase.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/DeactivateStorageDomainCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/VdcActionUtilsTest.java
6 files changed, 40 insertions(+), 17 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/71397
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I92bd086020b9f90089b24c67ea1b1c3cf4149d9f
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in ovirt-engine[master]: vdsbroker: Move storageDomainMonitoredStatus to common
by Code Review
>From Liron Aravot <laravot(a)redhat.com>:
Liron Aravot has submitted this change and it was merged.
Change subject: vdsbroker: Move storageDomainMonitoredStatus to common
......................................................................
vdsbroker: Move storageDomainMonitoredStatus to common
This patch moves the storageDomainMonitoredStatus constant to
common.StorageConstants
in order to use it in the following patches.
Change-Id: I8f35cb99e6e063b2b50d6c1144dc9864b95d2fe6
Bug-Url: https://bugzilla.redhat.com/1445753
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/StorageConstants.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxy.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/storage/StoragePoolDomainHelper.java
3 files changed, 10 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/71396
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8f35cb99e6e063b2b50d6c1144dc9864b95d2fe6
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in ovirt-engine[master]: DeactivateStorageDomainTest - rm method names 'test' prefix
by Code Review
>From Liron Aravot <laravot(a)redhat.com>:
Liron Aravot has submitted this change and it was merged.
Change subject: DeactivateStorageDomainTest - rm method names 'test' prefix
......................................................................
DeactivateStorageDomainTest - rm method names 'test' prefix
Change-Id: I8c5bc35b27888e0bc7886f5bf355b35cde1d1e42
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/DeactivateStorageDomainCommandTest.java
1 file changed, 7 insertions(+), 7 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/74711
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c5bc35b27888e0bc7886f5bf355b35cde1d1e42
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in ovirt-hosted-engine-setup[master]: plugins: core: Check that engine vm is up at the end of the ...
by Code Review
>From Simone Tiraboschi <stirabos(a)redhat.com>:
Simone Tiraboschi has submitted this change and it was merged.
Change subject: plugins: core: Check that engine vm is up at the end of the setup
......................................................................
plugins: core: Check that engine vm is up at the end of the setup
Check if engine's vm is up before announcing to the user:
'Hosted Engine successfully deployed' at the end of the setup
Change-Id: Ib4f73a5d4fad599d2136825ae01cf87fb960b7c5
Bug-Url: https://bugzilla.redhat.com/1304650
Signed-off-by: Ido Rosenzwig <irosenzw(a)redhat.com>
---
M src/ovirt_hosted_engine_setup/constants.py
M src/plugins/gr-he-common/core/misc.py
2 files changed, 38 insertions(+), 0 deletions(-)
Approvals:
Simone Tiraboschi: Looks good to me, approved
Ido Rosenzwig: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/75656
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib4f73a5d4fad599d2136825ae01cf87fb960b7c5
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in ovirt-engine[master]: dal: Fix vm_device data population - custom_properties
by Code Review
>From Roy Golan <rgolan(a)redhat.com>:
Roy Golan has submitted this change and it was merged.
Change subject: dal: Fix vm_device data population - custom_properties
......................................................................
dal: Fix vm_device data population - custom_properties
Mistakenly custom_properties in vm_device was set to a uuid - that would
fail deserializing vm_device custom properties
Change-Id: I23aa02117d03b2455e12d9c8dd74323d8a7a5440
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M packaging/dbscripts/data/01200_insert_vm_device.sql
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Roy Golan: Verified
--
To view, visit https://gerrit.ovirt.org/76080
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I23aa02117d03b2455e12d9c8dd74323d8a7a5440
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in ovirt-engine[master]: engine:BackendSnapshotsResource#mapDisks
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: engine:BackendSnapshotsResource#mapDisks
......................................................................
engine:BackendSnapshotsResource#mapDisks
Changed the 'for each' loop into a stream.
Change-Id: I733f2e00abef2c77dd77cfc194ec1b6a75cccc44
Signed-off-by: Shani Leviim <sleviim(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotsResource.java
1 file changed, 11 insertions(+), 11 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
Shani Leviim: Verified
--
To view, visit https://gerrit.ovirt.org/76059
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I733f2e00abef2c77dd77cfc194ec1b6a75cccc44
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shani Leviim <sleviim(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Shani Leviim <sleviim(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in ovirt-engine[ovirt-engine-4.1]: webadmin: Corrected validation for geo-rep
by Code Review
>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>:
Piotr Kliczewski has submitted this change and it was merged.
Change subject: webadmin: Corrected validation for geo-rep
......................................................................
webadmin: Corrected validation for geo-rep
AsciiName validation is not required for volume
as this is a volume entity selection
Change-Id: I640936d741456bc13977946272a0c3afddf6ced6
Bug-Url: https://bugzilla.redhat.com/1440071
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeGeoRepCreateModel.java
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
Denis Chaplygin: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Sahina Bose: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/75687
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I640936d741456bc13977946272a0c3afddf6ced6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in ovirt-engine[master]: packaging: engine-backup: Allow setting temp dir
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: engine-backup: Allow setting temp dir
......................................................................
packaging: engine-backup: Allow setting temp dir
Add an option --tmpdir=DIR to set the parent of the temporary directory
that's created. Defaults to $TMPDIR if set, otherwise to /tmp.
Change-Id: I13f07418329fd6347e3ec86f52438db220da393f
Bug-Url: https://bugzilla.redhat.com/1439332
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/bin/engine-backup.sh.in
M packaging/man/man8/engine-backup.8
2 files changed, 20 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/75589
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I13f07418329fd6347e3ec86f52438db220da393f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in ovirt-engine[master]: webadmin: Use type inference in StorageDRListModel
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Use type inference in StorageDRListModel
......................................................................
webadmin: Use type inference in StorageDRListModel
Change-Id: I196b75ff7438007d5f91eab5ea51ae81d64d034e
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDRListModel.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Sahina Bose: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76008
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I196b75ff7438007d5f91eab5ea51ae81d64d034e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years