May 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk[sdk_4.1]: Add example how to attach LUN disk to VM
by Code Review 19 May '17

19 May '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add example how to attach LUN disk to VM ...................................................................... Add example how to attach LUN disk to VM This example add an example how to add LUN disk to VM. Change-Id: Ifbb1e18249d4e02c2cd71c9671f27d34cba44104 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit e9e016abb3e3409d24f0076c27fa0ed17413ab8a) --- A sdk/examples/add_lun_disk_to_vm.py 1 file changed, 75 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77010 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbb1e18249d4e02c2cd71c9671f27d34cba44104 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Fill COPYPOSTFIELDS only for POST and PUT requests
by Code Review 19 May '17

19 May '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Fill COPYPOSTFIELDS only for POST and PUT requests ...................................................................... Fill COPYPOSTFIELDS only for POST and PUT requests HTTP pipelining is valid only for idempotent operations. Pycurl automatically disables pipelining if COPYPOSTFIELDS is set, even if pipelining is explicitly set. Change-Id: Ibb43f4a6ced9687efe54e61753fed357d9005651 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M sdk/lib/ovirtsdk4/__init__.py 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76768 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb43f4a6ced9687efe54e61753fed357d9005651 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: Revert "setup: deploy ovn provider's firewalld services"
by Code Review 19 May '17

19 May '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: Revert "setup: deploy ovn provider's firewalld services" ...................................................................... Revert "setup: deploy ovn provider's firewalld services" There seems to be a timing issue where setup tries to process the firewalld services before they're installed. This reverts commit 1470f74d9b1626cedd41920a85545c646a706116. Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> Change-Id: If5c89326503ae0728422de17508834fdced16ca0 --- M packaging/setup/ovirt_engine_setup/engine/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/network/ovirtproviderovn.py 2 files changed, 0 insertions(+), 50 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77005 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5c89326503ae0728422de17508834fdced16ca0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Add example how to attach LUN disk to VM
by Code Review 19 May '17

19 May '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add example how to attach LUN disk to VM ...................................................................... Add example how to attach LUN disk to VM This example add an example how to add LUN disk to VM. Change-Id: Ifbb1e18249d4e02c2cd71c9671f27d34cba44104 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- A sdk/examples/add_lun_disk_to_vm.py 1 file changed, 75 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbb1e18249d4e02c2cd71c9671f27d34cba44104 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add Error.code
by Code Review 19 May '17

19 May '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Add Error.code ...................................................................... Add Error.code This patch adds a new 'code' attribute to the Error class. For errors that are HTTP related, this will contain the HTTP response code. For example, if the method to retrieve a virtual machine fails because it doesn't exist, this will contain the value 404. The users of the SDK can use it like this: # Get the identifier of the virtual machine from some place, maybe # from a database that is out of sync with the engine: id = ... # Find the service that manages that virtual machine. Note that this # will always succeed, even if the virtual machine doesn't exist, as # the calls to the 'whatever_service' methods *do not* perform any # call to the server. vm_service = vms_service.vm_service(id) # Try to retrieve the virtual machine. This *does* send the request # to the server, hence it may fail if the virtual machine doesn't # exist. begin vm = vm_service.get rescue OvirtSDK4::Error => error if error.code == 404 # The virtual machine doesn't exist, handle it. ... else # Something else happened that we don't know how to handle. raise end end For errors that aren't HTTP related, the value of the new attribute will be 'nil'. Change-Id: I6e3fc71e17fa1726049ca1e49c8cc9e295c15b0c Bug-Url: https://bugzilla.redhat.com/1443420 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/lib/ovirtsdk4.rb M sdk/lib/ovirtsdk4/connection.rb A sdk/lib/ovirtsdk4/error.rb M sdk/spec/vm_service_spec.rb 4 files changed, 47 insertions(+), 1 deletion(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75665 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e3fc71e17fa1726049ca1e49c8cc9e295c15b0c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Boris Odnopozov <bodnopoz(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add example how to attach LUN disk to VM
by Code Review 19 May '17

19 May '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Add example how to attach LUN disk to VM ...................................................................... Add example how to attach LUN disk to VM This example add an example how to add LUN disk to VM. Change-Id: I8a0ca0f90e89c3a229941b48afae74f95d6eeec0 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- A sdk/examples/add_lun_disk_to_vm.rb 1 file changed, 67 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77006 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a0ca0f90e89c3a229941b48afae74f95d6eeec0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: update NGN host type
by Code Review 19 May '17

19 May '17

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: core: update NGN host type ...................................................................... core: update NGN host type Setting the host type to 1 (NGN) in case that the host pretty name starts with "Red Hat Virtualization Host" which means that it is a NGN host. Change-Id: I60203503ec4025e5c56459cefe02e2061e7cf2b9 Bug-Url: https://bugzilla.redhat.com/1445297 Signed-off-by: emesika <emesika(a)redhat.com> Signed-off-by: Martin Perina <mperina(a)redhat.com> --- A packaging/dbscripts/upgrade/04_01_0800_set_host_type_for_ngn_hosts.sql 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Eli Mesika: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76798 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60203503ec4025e5c56459cefe02e2061e7cf2b9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Eli Mesika Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: update NGN host type
by Code Review 19 May '17

19 May '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: core: update NGN host type ...................................................................... core: update NGN host type Setting the host type to 1 (NGN) in case that the host pretty name starts with "Red Hat Virtualization Host" which means that it is a NGN host. Change-Id: I60203503ec4025e5c56459cefe02e2061e7cf2b9 Bug-Url: https://bugzilla.redhat.com/1445297 Signed-off-by: emesika <emesika(a)redhat.com> --- A packaging/dbscripts/upgrade/04_02_0260_set_host_type_for_ngn_hosts.sql 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Eli Mesika: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/76796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60203503ec4025e5c56459cefe02e2061e7cf2b9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Eli Mesika Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Register OVF_STORE disk at the end of the transaction.
by Code Review 18 May '17

18 May '17

>From Maor Lipchuk <mlipchuk(a)redhat.com>: Maor Lipchuk has submitted this change and it was merged. Change subject: core: Register OVF_STORE disk at the end of the transaction. ...................................................................... core: Register OVF_STORE disk at the end of the transaction. It appears that in some of the postgresql server versions (9.2.18 for example) a dead lock might occur when attaching a storage domain that gets upgraded (For example from V3 to V4). the reason for this dead lock is that AttachStorageDomainToPoolCommand creates a new transaction and updates the format version of the storage domain. As part of this transaction it also calls RegisterDiskCommand to register the OVF_STORE disks of the storage doman, RegisterDiskCommand also opens a new transaction and tries to insert data into image_storage_domain_map table. Because the new thread in RegisterDiskCommand waits for the lock, which was aquired as part of the update format, to be freed, the engine encounters a DB dead lock. Therefore changing the order of the actions in the trnsaction so the register of the disks will be before the version update should avoid this deadlock. Change-Id: If06cf896c07077e52c71ad33daf1508b3b2c7c86 Bug-Url: https://bugzilla.redhat.com/1446878 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AttachStorageDomainToPoolCommand.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified Liron Aravot: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/76475 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If06cf896c07077e52c71ad33daf1508b3b2c7c86 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: setup: deploy ovn provider's firewalld services
by Code Review 18 May '17

18 May '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. Change subject: setup: deploy ovn provider's firewalld services ...................................................................... setup: deploy ovn provider's firewalld services During customization, if ovn is marked for installation, setup ovn provider's firewalld services. Change-Id: I3353f68413089ee45e210900e37321484f857e76 Bug-Id: https://bugzilla.redhat.com/1432354 Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/network/ovirtproviderovn.py 2 files changed, 50 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve Leon Goldberg: Verified -- To view, visit https://gerrit.ovirt.org/76825 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3353f68413089ee45e210900e37321484f857e76 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0