May 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.1]: core: handle 'migration failure due to maintenance' logging
by Code Review 18 May '17

18 May '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: handle 'migration failure due to maintenance' logging ...................................................................... core: handle 'migration failure due to maintenance' logging In case a vm migration is running due to vds in VDSStatus.PreparingForMaintenance status (i.e. vds moved to maintenance and caused a vm migration to start), then in case the migration failed, we need to check if there is a destination host existed or not. Before this fix, the audit log message in case of no destination vds left to re-run on, included an "UNKNOWN" destination vds name: "Migration failed while Host is in 'preparing for maintenance' state. Consider manual intervention: stopping/migrating Vms as Host's state will not turn to maintenance while VMs are still running on it.(VM: STAYING_ALIVE-8, Source: dell-r210ii-13, Destination: <UNKNOWN>)" In this patch we added a new message for omitting destination host if none exist after re-run trials. Change-Id: I74605aa7d37551169911e4a406dac094e65e0566 Bug-Url: https://bugzilla.redhat.com/1436397 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 3 files changed, 7 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Sharon Gratch: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/76966 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74605aa7d37551169911e4a406dac094e65e0566 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: frontend: fix ClassCastException in StorageModel
by Code Review 18 May '17

18 May '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: frontend: fix ClassCastException in StorageModel ...................................................................... frontend: fix ClassCastException in StorageModel StorageModel::updateDiscardAfterDelete used to set the Discard After Delete (DAD) entity to false if it's not a block storage domain. This caused DAD's entity changed event to be raised, which should happen only for block domains. This patch removes the redundant call to setEntity on DAD, as it's already being set to false when switching back to a block domain. Change-Id: Ie31f4e195569b2ce931f82d856e364e274825349 Bug-Url: https://bugzilla.redhat.com/1451246 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/76958 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie31f4e195569b2ce931f82d856e364e274825349 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-imageio: Add Fedora 26 build
by Code Review 18 May '17

18 May '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. Change subject: ovirt-imageio: Add Fedora 26 build ...................................................................... ovirt-imageio: Add Fedora 26 build We would like to detect regression quickly by testing and making it easy to install the package on Fedora 26. Change-Id: Idc7ba5e5239d6627cdd18e23a0263dc5f689e6d2 Signed-off-by: Nir Soffer <nsoffer(a)redhat.com> --- M jobs/confs/projects/ovirt-imageio/ovirt-imageio.yaml 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved; Ready for merge Barak Korren: Verified; Looks good to me; Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76806 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc7ba5e5239d6627cdd18e23a0263dc5f689e6d2 Gerrit-PatchSet: 4 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in jenkins[master]: ovirt-imageio: Remove unneeded excludes
by Code Review 18 May '17

18 May '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. Change subject: ovirt-imageio: Remove unneeded excludes ...................................................................... ovirt-imageio: Remove unneeded excludes The build-artifacts job inherit the excludes from the base job, no need to repeat them. Change-Id: I6a78b44a2657685fe665e23567ebe727cee97950 Signed-off-by: Nir Soffer <nsoffer(a)redhat.com> --- M jobs/confs/projects/ovirt-imageio/ovirt-imageio.yaml 1 file changed, 0 insertions(+), 9 deletions(-) Approvals: Sandro Bonazzola: Looks good to me Barak Korren: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76858 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a78b44a2657685fe665e23567ebe727cee97950 Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ReduceSD - fail when no md devices info
by Code Review 18 May '17

18 May '17

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: core: ReduceSD - fail when no md devices info ...................................................................... core: ReduceSD - fail when no md devices info In some user envs the metadata for a block sd was resotored in a way preventing vdsm to determine the vg metadata device of the domain. As we don't support that configuration - we'd like to prevent devices from being reduced from the domain in that case. This patch changes the reduce command to verify that the metadata devices are present before allowing to reduce a device from the domain. Change-Id: Ib4274f3f4a106f1be083bd36dcbe182acc5fe348 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ReduceSANStorageDomainDevicesCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 3 files changed, 11 insertions(+), 0 deletions(-) Approvals: Liron Aravot: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/76607 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4274f3f4a106f1be083bd36dcbe182acc5fe348 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CreateAllSnapshotsFromVmParameters#disks
by Code Review 17 May '17

17 May '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: CreateAllSnapshotsFromVmParameters#disks ...................................................................... core: CreateAllSnapshotsFromVmParameters#disks Changed disks to a Set<Guid> instead of List<DiskImage>. While creating a snapshot, the only use for the 'disks' parameter is for taking the disk IDs. Therefore, constructing a set of disk guids is more reasonable. Also, by using guids instead of disk images, checking if a disk parameter for snapshot is a direct lun would be easier. In addition, as a part of the patch, the method 'diskImagesNotExist()' was moved to: org.ovirt.engine.core.bll.validator.storage.DiskExistenceValidator and a new test scenario was created for it. Change-Id: I4b6b6cb38cb28bd42a2a0d81f0ab2d5a2750bddc Signed-off-by: Shani Leviim <sleviim(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/dr/GlusterStorageSyncCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateVmDisksCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskExistenceValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskImagesValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskExistenceValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskImagesValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateAllSnapshotsFromVmParameters.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotsResource.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SnapshotModel.java 11 files changed, 178 insertions(+), 85 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Shani Leviim: Verified -- To view, visit https://gerrit.ovirt.org/76382 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b6b6cb38cb28bd42a2a0d81f0ab2d5a2750bddc Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shani Leviim <sleviim(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Shani Leviim <sleviim(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: Makefile: Adjust path for execution via rpm install
by Code Review 17 May '17

17 May '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: Makefile: Adjust path for execution via rpm install ...................................................................... Makefile: Adjust path for execution via rpm install Make sure we follow commit 377e0575 Change-Id: If04b651d17b7b83033509436a1a59a8dfc290951 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/Makefile.am 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76957 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If04b651d17b7b83033509436a1a59a8dfc290951 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: handle 'migration failure due to maintenance' logging
by Code Review 17 May '17

17 May '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: handle 'migration failure due to maintenance' logging ...................................................................... core: handle 'migration failure due to maintenance' logging In case a vm migration is running due to vds in VDSStatus.PreparingForMaintenance status (i.e. vds moved to maintenance and caused a vm migration to start), then in case the migration failed, we need to check if there is a destination host existed or not. Before this fix, the audit log message in case of no destination vds left to re-run on, included an "UNKNOWN" destination vds name: "Migration failed while Host is in 'preparing for maintenance' state. Consider manual intervention: stopping/migrating Vms as Host's state will not turn to maintenance while VMs are still running on it.(VM: STAYING_ALIVE-8, Source: dell-r210ii-13, Destination: <UNKNOWN>)" In this patch we added a new message for omitting destination host if none exist after re-run trials. Change-Id: I74605aa7d37551169911e4a406dac094e65e0566 Bug-Url: https://bugzilla.redhat.com/1436397 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 3 files changed, 7 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Sharon Gratch: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/76868 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74605aa7d37551169911e4a406dac094e65e0566 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: spec: add requirements for the analyzer
by Code Review 17 May '17

17 May '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: spec: add requirements for the analyzer ...................................................................... spec: add requirements for the analyzer Use requirements from edd76f0 to right subpackage. Change-Id: I51e2c39e1f06f571e3ecff142dffb3369c6e8e61 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M ovirt-log-collector.spec.in 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76955 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51e2c39e1f06f571e3ecff142dffb3369c6e8e61 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: Makefile.am: use raw rpmbuild cmd
by Code Review 17 May '17

17 May '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: Makefile.am: use raw rpmbuild cmd ...................................................................... Makefile.am: use raw rpmbuild cmd We don't need macro/var for rpmbuild cmd. It won't change in a near future. Change-Id: I9d23c0f828308e2d3593668ed24a224797ddfa08 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M Makefile.am 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76954 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d23c0f828308e2d3593668ed24a224797ddfa08 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0