Change in ovirt-engine[master]: engine: Remove spare injection in GlusterAuditLogUtil
by Code Review
>From Sahina Bose <sabose(a)redhat.com>:
Sahina Bose has submitted this change and it was merged.
Change subject: engine: Remove spare injection in GlusterAuditLogUtil
......................................................................
engine: Remove spare injection in GlusterAuditLogUtil
Since the attributes to be logged already known at event creation time,
there is no need to used the injection-support implementation of the
AuditLogable for logging the event.
Change-Id: Ic6b235060dfb2c34bc4afaf9c38942d0965a2e9d
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterAuditLogUtil.java
1 file changed, 8 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Sahina Bose: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76524
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6b235060dfb2c34bc4afaf9c38942d0965a2e9d
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: engine: Remove spare injection in Gluster flows
by Code Review
>From Sahina Bose <sabose(a)redhat.com>:
Sahina Bose has submitted this change and it was merged.
Change subject: engine: Remove spare injection in Gluster flows
......................................................................
engine: Remove spare injection in Gluster flows
Since we can obtain most of the properties required to log an event for
gluster various flows, we can use the AuditLogableImpl which is
'lighter' entity and doesn't require injection + access to the DB for
the various properties.
Change-Id: I80a0322a435efae1e0951b52b02ffb37dcac66ac
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterGeoRepSyncJob.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookSyncJob.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterServiceSyncJob.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSnapshotScheduleJob.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSnapshotSyncJob.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StorageDeviceSyncJob.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/tasks/GlusterTaskUtils.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterAuditLogUtil.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterUtil.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterHookSyncJobTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterServiceSyncJobTest.java
14 files changed, 116 insertions(+), 79 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Sahina Bose: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76527
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I80a0322a435efae1e0951b52b02ffb37dcac66ac
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: engine: Remove spare injection in InitGlusterCommandHelper
by Code Review
>From Sahina Bose <sabose(a)redhat.com>:
Sahina Bose has submitted this change and it was merged.
Change subject: engine: Remove spare injection in InitGlusterCommandHelper
......................................................................
engine: Remove spare injection in InitGlusterCommandHelper
Since all of the data to be logged is already present at the creation
of the audit-log entity, there is no need to inject any beans to the
AuditLogableBase and it can be replaced with a leaner and more
efficient implementation of the AuditLogable.
Change-Id: I911e375c03478b88e4da78cd4acca1d6de854505
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitGlusterCommandHelper.java
1 file changed, 19 insertions(+), 12 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Sahina Bose: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76525
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I911e375c03478b88e4da78cd4acca1d6de854505
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: engine: Remove spare injection in GlusterSyncJob
by Code Review
>From Sahina Bose <sabose(a)redhat.com>:
Sahina Bose has submitted this change and it was merged.
Change subject: engine: Remove spare injection in GlusterSyncJob
......................................................................
engine: Remove spare injection in GlusterSyncJob
Since all of the data to be logged is already present at the creation
of the audit-log entity, there is no need to inject any beans to the
AuditLogableBase and it can be replaced with a leaner and more
efficient implementation of the AuditLogable.
In addition, the same method to create event in gluster flows can be
reused, therefore introducing and reusing GlusterEventFactory.
Change-Id: I67e7ed9fd59c0bdf168c66ad70e8755a062ecd56
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitGlusterCommandHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterEventFactory.java
3 files changed, 28 insertions(+), 20 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Sahina Bose: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76526
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I67e7ed9fd59c0bdf168c66ad70e8755a062ecd56
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: core: fix the adjustment of ha vms at restore time
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: core: fix the adjustment of ha vms at restore time
......................................................................
core: fix the adjustment of ha vms at restore time
When restoring a backup of the database, the adjustment of highly-available
VMs should also clear the run_on_vds and migrating_to_vds fields.
Change-Id: Ib4f7715ec97459efdf25023b91320ed50851ffe9
Bug-Url: https://bugzilla.redhat.com/1441322
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M packaging/bin/engine-backup.sh.in
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Lev Veyde: Looks good to me, but someone else must approve
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/76866
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib4f7715ec97459efdf25023b91320ed50851ffe9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: core: rename OpenStack specific network provider validation
by Code Review
>From Alona Kaplan <alkaplan(a)redhat.com>:
Alona Kaplan has submitted this change and it was merged.
Change subject: core: rename OpenStack specific network provider validation
......................................................................
core: rename OpenStack specific network provider validation
Include the term "Openstack" in symbols of network provider validation,
which are specific to the OpenStack Neutron provider.
This prepares the validation of external network providers, which are
not a OpenStack Neutron provider.
Change-Id: I9db546e51507c11c1b1f93c5d8c9fff3a50780b1
Signed-off-by: Dominik Holler <dholler(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/AddVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpdateVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/NetworkProviderValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/provider/NetworkProviderValidatorTest.java
5 files changed, 11 insertions(+), 8 deletions(-)
Approvals:
Marcin Mirecki: Looks good to me, but someone else must approve
Dominik Holler: Verified
Martin Mucha: Looks good to me, but someone else must approve
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/76496
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9db546e51507c11c1b1f93c5d8c9fff3a50780b1
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: core: one should not be able to deassign defaultRole from mg...
by Code Review
>From Tomas Jelinek <tjelinek(a)redhat.com>:
Tomas Jelinek has submitted this change and it was merged.
Change subject: core: one should not be able to deassign defaultRole from mgmt network
......................................................................
core: one should not be able to deassign defaultRole from mgmt network
In networks->cluster->ManageNetwork you can assign/deassign network
role for this single network. You should be able to assign/deassign
default route role for any network, but only assign for mgmt network,
because when you deassign default route role from network, it will be
assigned back to mgmt network, which would therefore look as
errorneous when done on mgmt network.
Change-Id: I99064854fc596ddc75663c3819d6ea9fe558d217
Bug-Url: https://bugzilla.redhat.com/1443412
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Martin Mucha: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/76978
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I99064854fc596ddc75663c3819d6ea9fe558d217
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[ovirt-engine-3.6]: core: Adding pretty name to OS version format
by Code Review
>From Oved Ourfali <oourfali(a)redhat.com>:
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Adding pretty name to OS version format
......................................................................
core: Adding pretty name to OS version format
This patch adds pretty_name to vds_dynamic table and to the data access
layer.
This field is filled by the VDSM and sent to the engine's VdsBroker
which persist it to the database.
The pretty name is a friendly representation of the OS release/version
and is displayed as a separate field in the UI Host->General->Software
sub tab and is also available from the API when getting the host
information.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1446182
Change-Id: I0b1cc2fa4f9e351eae1b855670b3ffe505a2c618
Signed-off-by: emesika <emesika(a)redhat.com>
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDaoImpl.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralSoftwareView.java
M packaging/dbscripts/create_views.sql
A packaging/dbscripts/upgrade/03_06_02190_add_vds_dynamic_pretty_name.sql
M packaging/dbscripts/upgrade/post_upgrade/0010_add_object_column_white_list_table.sql
M packaging/dbscripts/vds_sp.sql
14 files changed, 66 insertions(+), 7 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Eli Mesika: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/76290
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0b1cc2fa4f9e351eae1b855670b3ffe505a2c618
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in jenkins[master]: OST manual job: Create vm images
by Code Review
>From Eyal Edri <eedri(a)redhat.com>:
Eyal Edri has submitted this change and it was merged.
Change subject: OST manual job: Create vm images
......................................................................
OST manual job: Create vm images
Added the option to choose if images of the vms should
be created.
Change-Id: Ib115bfcb5ee0a857d64b43af163d3044018c656f
Signed-off-by: gbenhaim <galbh2(a)gmail.com>
---
M jobs/confs/projects/ovirt/system-tests.yaml
M jobs/confs/yaml/builders/system_tests_builders.yaml
2 files changed, 13 insertions(+), 0 deletions(-)
Approvals:
Gal Ben Haim: Verified; Ready for review
Eyal Edri: Ready for merge
Daniel Belenky: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/76555
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib115bfcb5ee0a857d64b43af163d3044018c656f
Gerrit-PatchSet: 4
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Gal Ben Haim <galbh2(a)gmail.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gal Ben Haim <galbh2(a)gmail.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
7 years, 7 months
Change in ovirt-engine[master]: core: extend default MAC range to 1024 addresses
by Code Review
>From Eli Mesika <emesika(a)redhat.com>:
Eli Mesika has submitted this change and it was merged.
Change subject: core: extend default MAC range to 1024 addresses
......................................................................
core: extend default MAC range to 1024 addresses
This patch extends the default MAC range to 1024 addresses.
This will be affective only to new installations.
Change-Id: I666e505d4d7617cf49b465a07d28e136ca261aca
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1451272
Signed-off-by: emesika <emesika(a)redhat.com>
---
M packaging/dbscripts/data/00220_insert_mac_pool_ranges.sql
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Eli Mesika: Verified; Looks good to me, approved
Martin Mucha: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/76881
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I666e505d4d7617cf49b465a07d28e136ca261aca
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Michael Burman <mburman(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months