Change in ovirt-engine[master]: core: RemoveStoragePoolCommandTest - shared code/test cases
by Code Review
>From Liron Aravot <laravot(a)redhat.com>:
Liron Aravot has submitted this change and it was merged.
Change subject: core: RemoveStoragePoolCommandTest - shared code/test cases
......................................................................
core: RemoveStoragePoolCommandTest - shared code/test cases
1. Using shared code to test the different domain statuses.
2. Making the tests generic and undependent in newly added domain statuses.
Change-Id: I5fe253b8c53a7c5ba3aa4364a03f17218488470f
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/RemoveStoragePoolCommandTest.java
1 file changed, 23 insertions(+), 90 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/76529
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5fe253b8c53a7c5ba3aa4364a03f17218488470f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: core: fix free space validation when performing merge
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: fix free space validation when performing merge
......................................................................
core: fix free space validation when performing merge
When performing a merge operation on snapshot consisting
of multiple disks on the same storage domain, the operation
will fail because of IllegalStateException caused by duplicate
key, because a separate entry is created for each disk and because
they are on the same storage domain, the map will have the same
key for multiple entries.
This is solved by mapping a storage domain (guid) to a list of
SubchainInfo instead, this way all subchains from the same domain
will be under the same entry.
Change-Id: Ie60744140d84f979732e352559d49a1c1cfbf143
Bug-Url: https://bugzilla.redhat.com/1450866
Signed-off-by: Benny Zlotnik <bzlotnik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/MultipleStorageDomainsValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainValidator.java
2 files changed, 18 insertions(+), 11 deletions(-)
Approvals:
Benny Zlotnik: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Ala Hino: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/76854
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie60744140d84f979732e352559d49a1c1cfbf143
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine-sdk[sdk_4.1]: Add Error.fault
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Add Error.fault
......................................................................
Add Error.fault
Currently when a fault is returned by the server the information that it
contains is used to generate an exception message, and then this
discarded. This patch changes the SDK so that the fault object is copied
to the 'Error.fault' attribute instead of discarded.
Change-Id: I2f8aac14214737824b8b51fac56d9a8657b299dd
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1450986
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 5c74d78c0b2351a796fd9bb19f5e7fe4386aa9d2)
---
M sdk/lib/ovirtsdk4/__init__.py
M sdk/lib/ovirtsdk4/service.py
M sdk/tests/test_vm_service.py
3 files changed, 48 insertions(+), 2 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/76936
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f8aac14214737824b8b51fac56d9a8657b299dd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine-sdk[sdk_4.1]: Add Error.code
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Add Error.code
......................................................................
Add Error.code
This patch adds a new 'code' attribute to the Error class.
For errors that are HTTP related, this will contain the HTTP response
code. For example, if the method to retrieve a virtual machine fails
because it doesn't exist, this will contain the value 404. The users of
the SDK can use it like this:
# Get the identifier of the virtual machine from some place, maybe
# from a database that is out of sync with the engine:
id = ...
# Find the service that manages that virtual machine. Note that this
# will always succeed, even if the virtual machine doesn't exist, as
# the calls to the 'whatever_service' methods *do not* perform any
# call to the server.
vm_service = vms_service.vm_service(id)
# Try to retrieve the virtual machine. This *does* send the request
# to the server, hence it may fail if the virtual machine doesn't
# exist.
try:
vm = vm_service.get()
except Error as error:
if error.code == 404:
# The virtual machine doesn't exist, handle it.
...
else:
# Something else happened that we don't know how to handle.
raise
For errors that aren't HTTP related, the value of the new attribute will
be 'None'.
Change-Id: Ic0ba8ab3e72c573f332990724ea042600f1fab39
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1450986
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit cbdbdb6638cc2eee76747a0dfcf52ed7cf09fce7)
---
M sdk/lib/ovirtsdk4/__init__.py
M sdk/lib/ovirtsdk4/service.py
M sdk/tests/test_vm_service.py
3 files changed, 27 insertions(+), 2 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/76935
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic0ba8ab3e72c573f332990724ea042600f1fab39
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine-sdk[master]: Add Error.fault
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Add Error.fault
......................................................................
Add Error.fault
Currently when a fault is returned by the server the information that it
contains is used to generate an exception message, and then this
discarded. This patch changes the SDK so that the fault object is copied
to the 'Error.fault' attribute instead of discarded.
Change-Id: I2f8aac14214737824b8b51fac56d9a8657b299dd
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1450986
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M sdk/lib/ovirtsdk4/__init__.py
M sdk/lib/ovirtsdk4/service.py
M sdk/tests/test_vm_service.py
3 files changed, 48 insertions(+), 2 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/76923
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f8aac14214737824b8b51fac56d9a8657b299dd
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine-sdk[master]: Add Error.code
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Add Error.code
......................................................................
Add Error.code
This patch adds a new 'code' attribute to the Error class.
For errors that are HTTP related, this will contain the HTTP response
code. For example, if the method to retrieve a virtual machine fails
because it doesn't exist, this will contain the value 404. The users of
the SDK can use it like this:
# Get the identifier of the virtual machine from some place, maybe
# from a database that is out of sync with the engine:
id = ...
# Find the service that manages that virtual machine. Note that this
# will always succeed, even if the virtual machine doesn't exist, as
# the calls to the 'whatever_service' methods *do not* perform any
# call to the server.
vm_service = vms_service.vm_service(id)
# Try to retrieve the virtual machine. This *does* send the request
# to the server, hence it may fail if the virtual machine doesn't
# exist.
try:
vm = vm_service.get()
except Error as error:
if error.code == 404:
# The virtual machine doesn't exist, handle it.
...
else:
# Something else happened that we don't know how to handle.
raise
For errors that aren't HTTP related, the value of the new attribute will
be 'None'.
Change-Id: Ic0ba8ab3e72c573f332990724ea042600f1fab39
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1450986
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M sdk/lib/ovirtsdk4/__init__.py
M sdk/lib/ovirtsdk4/service.py
M sdk/tests/test_vm_service.py
3 files changed, 27 insertions(+), 2 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/76921
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic0ba8ab3e72c573f332990724ea042600f1fab39
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: webadmin: SpiceNativeImpl curly braces
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: webadmin: SpiceNativeImpl curly braces
......................................................................
webadmin: SpiceNativeImpl curly braces
Remove redundant curly braces in a single statements lambda that just
make reading the code less comfortable.
Change-Id: I973a6519086e2f18a5cbda2c03a2a3bc723b08d6
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceNativeImpl.java
1 file changed, 6 insertions(+), 5 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Arik Hadas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/76915
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I973a6519086e2f18a5cbda2c03a2a3bc723b08d6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: webadmin: SpiceNativeImpl type inference
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: webadmin: SpiceNativeImpl type inference
......................................................................
webadmin: SpiceNativeImpl type inference
Change-Id: Ia566aa59b9dde06aa787cd345c404bc75469869b
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceNativeImpl.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Arik Hadas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/76916
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia566aa59b9dde06aa787cd345c404bc75469869b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: engine: Remove redundant modifiers
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Remove redundant modifiers
......................................................................
engine: Remove redundant modifiers
Change-Id: I1f9199691f5ee6a920e6a3f90d69c3f9f4413de4
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RenamedEntityInfoProvider.java
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Moti Asayag: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/76918
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1f9199691f5ee6a920e6a3f90d69c3f9f4413de4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[ovirt-engine-4.1]: core: validate usb unmanaged devices in runVmCommand
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: validate usb unmanaged devices in runVmCommand
......................................................................
core: validate usb unmanaged devices in runVmCommand
In case the Usb policy is set to DISABLED for an "old" VM (<= 3.6)
with an old USB configuration (i.e. more then one USB unmanaged controllers)
and that VM is restarted/rerun/rebooted in engine 4.1:
an error is thrown with host=UNKNOWN (null) since it is thrown in
runVmCommand->initVm()->updateVmDevicesOnRun() phase while there is still
no host scheduled for this VM.
This scenario is unique since no manual VM configuration update validation is
involved and the user won't know about that prior to restrating/re-running an old VM in
new engine.
To fix that we add the old USB configuration validation to
runVmCommand()->validate() method instead of catching it later on in
initVM() method.
Change-Id: I8876a17d90f5a70bc7bc05814875cbbb40601be3
Bug-Url: https://bugzilla.redhat.com/1435579
Signed-off-by: Sharon Gratch <sgratch(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
8 files changed, 41 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Sharon Gratch: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76913
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8876a17d90f5a70bc7bc05814875cbbb40601be3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months