Change in ovirt-engine[master]: core: GlusterAuditLogUtil streams
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: GlusterAuditLogUtil streams
......................................................................
core: GlusterAuditLogUtil streams
Use Java 8 streams instead of for loops in GlusterAuditLogUtil
Change-Id: Ib14fa96ab1d4baccb166f17ded83b31ee0b62259
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterAuditLogUtil.java
1 file changed, 1 insertion(+), 4 deletions(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76341
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib14fa96ab1d4baccb166f17ded83b31ee0b62259
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: core: fix smartcard in the generated domain xml
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: fix smartcard in the generated domain xml
......................................................................
core: fix smartcard in the generated domain xml
Add the missing 'mode' and 'type' attributes.
Change-Id: Id14415f11f5866f93839e3232d6f67989cf864be
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Looks good to me, but someone else must approve
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76666
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id14415f11f5866f93839e3232d6f67989cf864be
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: packaging: change provider instance to use ssl and authentic...
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: change provider instance to use ssl and authentication
......................................................................
packaging: change provider instance to use ssl and authentication
Provider url for default provider should use https.
Auth url should also be provided.
Change-Id: I62712c08a36b31e7aa04bbfe624f7b2eb2600900
Bug-Url: https://bugzilla.redhat.com/1436154
Signed-off-by: Marcin Mirecki<mmirecki(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/network/ovirtproviderovn.py
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Marcin Mirecki: Verified
Jenkins CI: Passed CI tests
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/76584
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I62712c08a36b31e7aa04bbfe624f7b2eb2600900
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: packaging: adding name to ovn config values tuple
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: adding name to ovn config values tuple
......................................................................
packaging: adding name to ovn config values tuple
Change-Id: I521d11c50d0f8d2d9d22e1b3537415844fe4688a
Signed-off-by: Marcin Mirecki<mmirecki(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1436154
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/network/ovirtproviderovn.py
1 file changed, 13 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Marcin Mirecki: Verified
Jenkins CI: Passed CI tests
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/76615
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I521d11c50d0f8d2d9d22e1b3537415844fe4688a
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-host-deploy[ovirt-host-deploy-1.6]: metrics: Prevent errors on failed collectd/fluentd installation
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: metrics: Prevent errors on failed collectd/fluentd installation
......................................................................
metrics: Prevent errors on failed collectd/fluentd installation
host-deploy already emitted only a warning, but otopi emits an error,
unless we ask it to ignore errors. These errors cause the engine to
emit:
Failed to install Host ${VdsName}. ${Message}
which is confusing.
Change-Id: Iec26b55ec8a04ce01a7ca6d27d20a75a248f50eb
Bug-Url: https://bugzilla.redhat.com/1443508
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
(cherry picked from commit facb469ddfad8609ef90dd49da328832eb423dc0)
---
M src/plugins/ovirt-host-deploy/collectd/packages.py
M src/plugins/ovirt-host-deploy/fluentd/packages.py
2 files changed, 16 insertions(+), 20 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/76676
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iec26b55ec8a04ce01a7ca6d27d20a75a248f50eb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: ovirt-host-deploy-1.6
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
7 years, 7 months
Change in ovirt-host-deploy[master]: metrics: Prevent errors on failed collectd/fluentd installation
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: metrics: Prevent errors on failed collectd/fluentd installation
......................................................................
metrics: Prevent errors on failed collectd/fluentd installation
host-deploy already emitted only a warning, but otopi emits an error,
unless we ask it to ignore errors. These errors cause the engine to
emit:
Failed to install Host ${VdsName}. ${Message}
which is confusing.
Change-Id: Iec26b55ec8a04ce01a7ca6d27d20a75a248f50eb
Bug-Url: https://bugzilla.redhat.com/1443508
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M src/plugins/ovirt-host-deploy/collectd/packages.py
M src/plugins/ovirt-host-deploy/fluentd/packages.py
2 files changed, 16 insertions(+), 20 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/76570
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iec26b55ec8a04ce01a7ca6d27d20a75a248f50eb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: frontend: Improve DontPrune aspect code
by Code Review
>From Vojtech Szocs <vszocs(a)redhat.com>:
Vojtech Szocs has submitted this change and it was merged.
Change subject: frontend: Improve DontPrune aspect code
......................................................................
frontend: Improve DontPrune aspect code
- added some comments to explain the details
- use Java 8 stream API to reduce code complexity
Note: in aop.xml file, we're configuring AOP weaver to apply
aspects not only to the code we want to advise (3rd party GWT
class ControlFlowAnalyzer) but also to the aspect Java class
itself (DontPrune). Without this, the build fails, so I guess
this is needed simply to ensure the aspect's Java class gets
properly loaded by AspectJ AOP weaver.
Change-Id: I14e84d3193cfcc49582d3cf85e5140be8e364eb0
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/gwt-aop/src/main/java/org/ovirt/engine/ui/gwtaop/DontPrune.java
M frontend/webadmin/modules/gwt-aop/src/main/resources/META-INF/aop.xml
2 files changed, 31 insertions(+), 29 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
Greg Sheremeta: Looks good to me, approved
Vojtech Szocs: Verified
--
To view, visit https://gerrit.ovirt.org/76438
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I14e84d3193cfcc49582d3cf85e5140be8e364eb0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: compat: Fix Maven module name
by Code Review
>From Vojtech Szocs <vszocs(a)redhat.com>:
Vojtech Szocs has submitted this change and it was merged.
Change subject: compat: Fix Maven module name
......................................................................
compat: Fix Maven module name
Change-Id: I28d407fa60eeeaf5efaccafed0e5a42b3d5ba5be
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M backend/manager/modules/compat/pom.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Vojtech Szocs: Verified
--
To view, visit https://gerrit.ovirt.org/76434
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I28d407fa60eeeaf5efaccafed0e5a42b3d5ba5be
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: frontend: Avoid stubbing via subclassing
by Code Review
>From Vojtech Szocs <vszocs(a)redhat.com>:
Vojtech Szocs has submitted this change and it was merged.
Change subject: frontend: Avoid stubbing via subclassing
......................................................................
frontend: Avoid stubbing via subclassing
Change-Id: I62d402befc66c42b85a1552b7cfe7fd9f8024efc
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/AbstractGwtDynamicHostPageServletTest.java
1 file changed, 11 insertions(+), 12 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Vojtech Szocs: Verified
--
To view, visit https://gerrit.ovirt.org/76433
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I62d402befc66c42b85a1552b7cfe7fd9f8024efc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: core: fix controllers in the generated domain xml
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: fix controllers in the generated domain xml
......................................................................
core: fix controllers in the generated domain xml
Change-Id: Ib0a03209595be9cf68ed65041c00dd8436ecdef0
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java
1 file changed, 3 insertions(+), 5 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Looks good to me, but someone else must approve
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76665
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib0a03209595be9cf68ed65041c00dd8436ecdef0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months