Change in ovirt-engine[master]: engine: Initial size in copy template disk flow
by Code Review
>From Liron Aravot <laravot(a)redhat.com>:
Liron Aravot has submitted this change and it was merged.
Change subject: engine: Initial size in copy template disk flow
......................................................................
engine: Initial size in copy template disk flow
Fix done in c556b3b1acf4c5 (engine: Initial size in copy template disk
flow) was wrongly reverted in dcf953e7334 (Revert "backend: refactoring:
Migrate ImagesHandler to CDI").
This patch revert to the original fix.
Change-Id: I1e4217f35049a7fec655ab1787c7401b47f8fcf1
Bug-Url: https://bugzilla.redhat.com/1438691
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandlerTest.java
2 files changed, 44 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Freddy Rolland: Verified
Liron Aravot: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76229
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1e4217f35049a7fec655ab1787c7401b47f8fcf1
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: engine: Make disk events creation explicit
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Make disk events creation explicit
......................................................................
engine: Make disk events creation explicit
Instead of passing various created hashmap for method to create events,
the creation of event can be explicit and using the common event api of
adding custom values.
Change-Id: I278708bb22bcc33dc51c819e206ebfe9dcb63768
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/MetadataDiskDescriptionHandler.java
1 file changed, 15 insertions(+), 20 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Moti Asayag: Verified
--
To view, visit https://gerrit.ovirt.org/76539
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I278708bb22bcc33dc51c819e206ebfe9dcb63768
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: core: Add missing @Override annotations
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: core: Add missing @Override annotations
......................................................................
core: Add missing @Override annotations
Since AuditLogable was extracted from AuditLogableBase, the implemented
methods should be marked with @Override
Change-Id: I5133abadea0948a9cc8728db77fc40f1a55d61ef
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java
1 file changed, 65 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, but someone else must approve
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76562
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5133abadea0948a9cc8728db77fc40f1a55d61ef
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: engine: Reduce method visibility to private
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Reduce method visibility to private
......................................................................
engine: Reduce method visibility to private
The modified method is used internally in AuditLogableBase
therefore its visibility can be reduced.
Change-Id: I1da454fd835cc2f14c09450b4abc3a5303cd6143
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
Moti Asayag: Verified
--
To view, visit https://gerrit.ovirt.org/76561
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1da454fd835cc2f14c09450b4abc3a5303cd6143
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: benchmarks: Benchmarks various engine API usages
by Code Review
>From Roy Golan <rgolan(a)redhat.com>:
Roy Golan has submitted this change and it was merged.
Change subject: benchmarks: Benchmarks various engine API usages
......................................................................
benchmarks: Benchmarks various engine API usages
This is an experimental benchmark to measure API requests
to a running engine using a ovirt's java sdk.
Motivation:
Trying to measure throughput and average time of:
- Commands
- Queries
Example benchmarks:
- get api/vms
- get api/hosts
- add external api/events
Additional 'benefits':
using JMH will cause stress on your system, first for warm-ups and later
during measurement - Make sure the benchmarks is a REAL world scenario
as much as possible.
Change-Id: Ibcb8d3e504df7ad3d8fb180c0d8aaa0efce05ff4
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/microbenchmarks/pom.xml
A backend/manager/modules/microbenchmarks/src/main/java/org/ovirt/engine/benchmarks/RestInvocationBenchmark.java
2 files changed, 84 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Roy Golan: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76226
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibcb8d3e504df7ad3d8fb180c0d8aaa0efce05ff4
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: core: Remove events from the cache without sync
by Code Review
>From Roy Golan <rgolan(a)redhat.com>:
Roy Golan has submitted this change and it was merged.
Change subject: core: Remove events from the cache without sync
......................................................................
core: Remove events from the cache without sync
Remove an item from the cache supports atomic #computeIfPresent which is
essentially the same as #remove
Change-Id: Ia2bbb2553cb63970079e9f64cae432f5b1f95dd0
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/EventFloodRegulator.java
1 file changed, 1 insertion(+), 7 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Roy Golan: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76445
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia2bbb2553cb63970079e9f64cae432f5b1f95dd0
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: core: Avoid sync on inserting into infinispan
by Code Review
>From Roy Golan <rgolan(a)redhat.com>:
Roy Golan has submitted this change and it was merged.
Change subject: core: Avoid sync on inserting into infinispan
......................................................................
core: Avoid sync on inserting into infinispan
Motivation:
According to change d2bc14d6d21cb7e02f976d88aa83d3aa47ab1709, Anti-flood
usage of infinispan used to suffer from 'putIfAbsent' bug in
infinispan Cache, that made inserted records inserted without lifespan.
Change:
Since this behavior doesn't seem to exist I'm reverting it and removing
the need to synchronize and use again
putIfAbsent(key, val, lifespan, unit) // seem to work as expected
Result:
Verified using tons of concurrent login using REST API and making sure
the log in log is inserted only every 5 seconds:
User admin@internal-authz logged in // seeing this evert 5 seconds
even though there are multiple logins per second
Change-Id: Iaa2f1ac32a1abe7483239108266c78736d953ad1
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/EventFloodRegulator.java
1 file changed, 7 insertions(+), 12 deletions(-)
Approvals:
Eli Mesika: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Roy Golan: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76267
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa2f1ac32a1abe7483239108266c78736d953ad1
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: async-command: Remove setting parent command
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: async-command: Remove setting parent command
......................................................................
async-command: Remove setting parent command
If setting the RunAsyncActionCommand as the parent of the command being
executed (original command), the original command "endAction" method
isn't invoked, leaving it not completed.
This change is valid for commands that could be run asynchronously.
Change-Id: Iae4abd65206e4422f1758d8a258c8d36d265f192
Bug-Url: https://bugzilla.redhat.com/1447050
Signed-off-by: Ala Hino <ahino(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunAsyncActionCommand.java
1 file changed, 2 insertions(+), 8 deletions(-)
Approvals:
Ravi Nori: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Freddy Rolland: Looks good to me, but someone else must approve
Ala Hino: Verified
Liron Aravot: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/76249
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iae4abd65206e4422f1758d8a258c8d36d265f192
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: core: NPE in addStep method of Step
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: NPE in addStep method of Step
......................................................................
core: NPE in addStep method of Step
In some cases when running from compensation, task creation fails
with NPE on addStep method of Step.
In this patch when loading steps in JobRepositoryImpl, the steps list is not
set if the list is null.
Change-Id: Icd895174bfc48ca1087d53328cffa2b0b6191fca
Bug-Url: https://bugzilla.redhat.com/1415691
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryImpl.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Ravi Nori: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Freddy Rolland: Verified
--
To view, visit https://gerrit.ovirt.org/76551
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icd895174bfc48ca1087d53328cffa2b0b6191fca
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: core: TryBackToCinderSnapshotCommand#getCinderBroker
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: TryBackToCinderSnapshotCommand#getCinderBroker
......................................................................
core: TryBackToCinderSnapshotCommand#getCinderBroker
TryBackToCinderSnapshotCommand's implementation of getCinderBroker()
is exactly identical to the implementation it overrides from
StorageHandlingCommandBase.
As such, it is redundant, and should be removed.
Change-Id: I62e670c091e381141528d22d644c0560b1594aa3
Related-To: https://bugzilla.redhat.com/1448793
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/TryBackToCinderSnapshotCommand.java
1 file changed, 0 insertions(+), 9 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/76571
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I62e670c091e381141528d22d644c0560b1594aa3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months