May 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Avoid injection in AsyncTaskManager
by Code Review 07 May '17

07 May '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: Avoid injection in AsyncTaskManager ...................................................................... engine: Avoid injection in AsyncTaskManager Since all of the data to be logged is already present at the creating of the audit-log entity, there is no need to inject any beans to the AuditLogableBase and it can be replaced with a leaner and more efficient implementation of the AuditLogable. Change-Id: I3fe02a5a595d6a8de6a4da4b6b21bc753da6117f Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Roy Golan: Looks good to me, but someone else must approve Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/76273 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3fe02a5a595d6a8de6a4da4b6b21bc753da6117f Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Avoid auditlog injection in ResourceManager
by Code Review 07 May '17

07 May '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: Avoid auditlog injection in ResourceManager ...................................................................... engine: Avoid auditlog injection in ResourceManager Since all of the data to be logged is already present at the creating of the audit-log entity, there is no need to inject any beans to the AuditLogableBase and it can be replaced with a leaner and more efficient implementation of the AuditLogable. Change-Id: Ied55cd8d889d8d68b594fd661a72689631a1ae62 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/76274 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied55cd8d889d8d68b594fd661a72689631a1ae62 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Remove spare injection in VmInfoBuildUtils
by Code Review 07 May '17

07 May '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: Remove spare injection in VmInfoBuildUtils ...................................................................... engine: Remove spare injection in VmInfoBuildUtils Since all of the data required for logging an event inside VmInfoBuildUtils is already present, we can skip the injection and auto data populating and set the exact data which is required for logging the event. Change-Id: I27545dcf4a1edee91bd85aa261a9dff8226af09e Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtils.java 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/76281 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27545dcf4a1edee91bd85aa261a9dff8226af09e Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Pull CompatibilityVersion to AuditLogable
by Code Review 07 May '17

07 May '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: core: Pull CompatibilityVersion to AuditLogable ...................................................................... core: Pull CompatibilityVersion to AuditLogable The CompatibilityVersion can is common to both AuditLogable implementation and can be used with the injected instance of it or without it. In order to support it reuse, it has to be pulled to the interface level. Change-Id: Ic1effc62f93cded12b1c90b5f6343357b4c92d93 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogable.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableImpl.java 3 files changed, 15 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/76280 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1effc62f93cded12b1c90b5f6343357b4c92d93 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Remove spare injection in VdsDeploy
by Code Review 07 May '17

07 May '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: Remove spare injection in VdsDeploy ...................................................................... engine: Remove spare injection in VdsDeploy The information relevant for logging the event is available when creating the event. Injection can be avoided in this context. Change-Id: Iaf0abff02f7b553264acc8f834c3ce07bdaf6d16 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeploy.java 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Jenkins CI: Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/76536 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf0abff02f7b553264acc8f834c3ce07bdaf6d16 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Remove spare injection in FenceAgentExecutor
by Code Review 07 May '17

07 May '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: Remove spare injection in FenceAgentExecutor ...................................................................... engine: Remove spare injection in FenceAgentExecutor Since all of the data to be logged is already present at the creation of the audit-log entity, there is no need to inject any beans to the AuditLogableBase and it can be replaced with a leaner and more efficient implementation of the AuditLogable. Change-Id: I2150b6f5df99cc9d8926f0bc737218ee1b72bc6b Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/FenceAgentExecutor.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/pm/FenceAgentExecutorTest.java 2 files changed, 7 insertions(+), 7 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Jenkins CI: Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/76277 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2150b6f5df99cc9d8926f0bc737218ee1b72bc6b Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Remove spare injection in SingleAgentFenceActionExec...
by Code Review 07 May '17

07 May '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: Remove spare injection in SingleAgentFenceActionExecutor ...................................................................... engine: Remove spare injection in SingleAgentFenceActionExecutor Since all of the data to be logged is already present at the creation of the audit-log entity, there is no need to inject any beans to the AuditLogableBase and it can be replaced with a leaner and more efficient implementation of the AuditLogable. Change-Id: I110e121f84d46e3ac9719a7b225684580eff9528 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/SingleAgentFenceActionExecutor.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Jenkins CI: Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/76278 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I110e121f84d46e3ac9719a7b225684580eff9528 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Avoid injection of AuditLog in SetVdsStatusVDSCommand
by Code Review 07 May '17

07 May '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: Avoid injection of AuditLog in SetVdsStatusVDSCommand ...................................................................... engine: Avoid injection of AuditLog in SetVdsStatusVDSCommand Since all of the data to be logged is already present at the creating of the audit-log entity, there is no need to inject any beans to the AuditLogableBase and it can be replaced with a leaner and more efficient implementation of the AuditLogable. Change-Id: Ifb61f8ee7e4c6df75b138ca5d02dabf2479b6572 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/SetVdsStatusVDSCommand.java 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/76275 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb61f8ee7e4c6df75b138ca5d02dabf2479b6572 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Remove spare injection in VdsBrokerCommand
by Code Review 07 May '17

07 May '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: Remove spare injection in VdsBrokerCommand ...................................................................... engine: Remove spare injection in VdsBrokerCommand There is no need to inject any bean in order to log that specific event. Change-Id: I3a7e6b0d80806e28b104ec90f88de64c2b5a41be Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerCommand.java 1 file changed, 8 insertions(+), 7 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/76534 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a7e6b0d80806e28b104ec90f88de64c2b5a41be Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Remove spare injection in UpdateVdsCommand
by Code Review 07 May '17

07 May '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: Remove spare injection in UpdateVdsCommand ...................................................................... engine: Remove spare injection in UpdateVdsCommand Same event logging can be done without injcetion and redundant DB access. Change-Id: Iac3dc4c68882873d244e7c5ad0ea82d573ae8bfe Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpdateVdsCommand.java 1 file changed, 6 insertions(+), 5 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Jenkins CI: Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/76533 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac3dc4c68882873d244e7c5ad0ea82d573ae8bfe Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0