June 2017 - Engine-commits - oVirt List Archives

Change in jenkins[master]: upstream re-basing capability
by Code Review 06 Jun '17

06 Jun '17

>From Gil Shinar <gshinar(a)redhat.com>: Gil Shinar has submitted this change and it was merged. Change subject: upstream re-basing capability ...................................................................... upstream re-basing capability https://ovirt-jira.atlassian.net/browse/OVIRT-1348 Adds the capability of "rebasing" prerequisite/upstream repositories on top of current one. That way one won't need to have duplications in two repositories. Whenever one wants to work on the current repo, the rebasing will take place and copy all the files he needs in order to work. Change-Id: Id0505ee9380b01edde8cfdaf5c624823d572958e Signed-off-by: Gil Shinar <gshinar(a)redhat.com> --- A jobs/confs/python-scripts/upstream-source-collector.py M jobs/confs/yaml/builders/standard.yaml A jobs/confs/yaml/builders/upstream_source_collector.yaml 3 files changed, 190 insertions(+), 0 deletions(-) Approvals: Gil Shinar: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75831 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0505ee9380b01edde8cfdaf5c624823d572958e Gerrit-PatchSet: 48 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in ovirt-engine-sdk-ruby[master]: [maven-release-plugin] prepare for next development iteration
by Code Review 06 Jun '17

06 Jun '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: [maven-release-plugin] prepare for next development iteration ...................................................................... [maven-release-plugin] prepare for next development iteration Change-Id: Ie01e1ba2ffa2af7f5850378589bc3852d5eec8a6 --- M generator/pom.xml M pom.xml M sdk/pom.xml 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/77848 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie01e1ba2ffa2af7f5850378589bc3852d5eec8a6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Update CHANGES.adoc for release 4.2.0-alpha1
by Code Review 06 Jun '17

06 Jun '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Update CHANGES.adoc for release 4.2.0-alpha1 ...................................................................... Update CHANGES.adoc for release 4.2.0-alpha1 This patch updates the CHANGES.adoc file, documenting the relevant changes in release 4.2.0-alpha1. Change-Id: Idf87e7885663e028e58f919088fed19afe9154fc Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/CHANGES.adoc 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/77846 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf87e7885663e028e58f919088fed19afe9154fc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: [maven-release-plugin] prepare release 4.2.0.alpha1
by Code Review 06 Jun '17

06 Jun '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: [maven-release-plugin] prepare release 4.2.0.alpha1 ...................................................................... [maven-release-plugin] prepare release 4.2.0.alpha1 Change-Id: Ib60a401e16a9bb635bccd03bca0c6333261e49a4 --- M generator/pom.xml M pom.xml M sdk/pom.xml 3 files changed, 7 insertions(+), 16 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/77847 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib60a401e16a9bb635bccd03bca0c6333261e49a4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Sync CHANGES.adoc with 4.1 branch
by Code Review 06 Jun '17

06 Jun '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Sync CHANGES.adoc with 4.1 branch ...................................................................... Sync CHANGES.adoc with 4.1 branch This patch adds to the CHANGES.adoc file the updates that have been done to the 4.1 branch, in preparation for the first release of version 4.2. Change-Id: Ia2eb733c1e09c69347f34dcfe39e8b7b90e4844c Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/CHANGES.adoc 1 file changed, 144 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/77841 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia2eb733c1e09c69347f34dcfe39e8b7b90e4844c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.1]: Fix the token re-new process
by Code Review 06 Jun '17

06 Jun '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Fix the token re-new process ...................................................................... Fix the token re-new process Commit cd0adb4774f7c4bcfcd14a1d09504ddce795fd06 has introduced locking in order to be able to work with multiple threads. At the same time this fix cause a regression in re-new token process. This patch fixes that. Change-Id: Idc3ba951eed42d22dcdcf21a559e239b7042238a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1434830 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit 432468a9cf84eaf194cb8fde8377e573d617848b) --- M sdk/lib/ovirtsdk4/__init__.py 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77835 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc3ba951eed42d22dcdcf21a559e239b7042238a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Fix the token re-new process
by Code Review 06 Jun '17

06 Jun '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Fix the token re-new process ...................................................................... Fix the token re-new process Commit cd0adb4774f7c4bcfcd14a1d09504ddce795fd06 has introduced locking in order to be able to work with multiple threads. At the same time this fix cause a regression in re-new token process. This patch fixes that. Change-Id: Idc3ba951eed42d22dcdcf21a559e239b7042238a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1434830 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M sdk/lib/ovirtsdk4/__init__.py 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77824 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc3ba951eed42d22dcdcf21a559e239b7042238a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.1]: Improve README.adoc
by Code Review 05 Jun '17

05 Jun '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Improve README.adoc ...................................................................... Improve README.adoc This patch improves the SDK usage introduction included in the README.adoc file. Change-Id: I3632c71981ac4638a36cbe0cde4ac0832d6e7615 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 11fa094708da9d769b0a513526f4f9eb4befcd89) --- M sdk/README.adoc 1 file changed, 659 insertions(+), 30 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77828 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3632c71981ac4638a36cbe0cde4ac0832d6e7615 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.1 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Improve README.adoc
by Code Review 05 Jun '17

05 Jun '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Improve README.adoc ...................................................................... Improve README.adoc This patch improves the SDK usage introduction included in the README.adoc file. Change-Id: I3632c71981ac4638a36cbe0cde4ac0832d6e7615 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/README.adoc 1 file changed, 659 insertions(+), 30 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/77636 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3632c71981ac4638a36cbe0cde4ac0832d6e7615 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Boris Odnopozov <bodnopoz(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.1]: Actions can return HTTP 201 and 202 response code
by Code Review 05 Jun '17

05 Jun '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Actions can return HTTP 201 and 202 response code ...................................................................... Actions can return HTTP 201 and 202 response code The API actions can return HTTP reponse codes 201 and 202, this patch ensure we handle those codes. Change-Id: I9fe1fef7b42a36f8af03fa346db8ac78819df020 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit 3c32f5e870b4ad2da28f814055bbc4001cf20400) --- M sdk/lib/ovirtsdk4/service.rb 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77772 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fe1fef7b42a36f8af03fa346db8ac78819df020 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.1 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: BaseListModelSuggestBox type inference
by Code Review 05 Jun '17

05 Jun '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: BaseListModelSuggestBox type inference ...................................................................... webadmin: BaseListModelSuggestBox type inference Change-Id: Ia6580f34266b52d09adaaae94c2b34f52c5320e1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseListModelSuggestBox.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/77755 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6580f34266b52d09adaaae94c2b34f52c5320e1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Enum recognition for SQL serialization
by Code Review 05 Jun '17

05 Jun '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: Enum recognition for SQL serialization ...................................................................... core: Enum recognition for SQL serialization Previously an enum instance was recognized by `.getClass().isEnum()` which doesn't work for instance with instance specific methods. Recognition changed to `instanceof Enum`. Change-Id: If5b5a1eeaeab721eb5a42e3556cc0e3a4b7574ba Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/CustomMapSqlParameterSource.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/76204 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5b5a1eeaeab721eb5a42e3556cc0e3a4b7574ba Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Correct audit log when running a stateless VM
by Code Review 05 Jun '17

05 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Correct audit log when running a stateless VM ...................................................................... core: Correct audit log when running a stateless VM Added a condition to RunVmCommand.getAuditLogTypeValue() to display correct message in the audit log when running a VM as stateless. Change-Id: I49c78fa5cd4f58ef8f5767ca383ccc48ae4e1f86 Bug-Url: https://bugzilla.redhat.com/1411075 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java 2 files changed, 16 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/77800 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49c78fa5cd4f58ef8f5767ca383ccc48ae4e1f86 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: make sure the VM is ran with the correct rng device
by Code Review 05 Jun '17

05 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: make sure the VM is ran with the correct rng device ...................................................................... core: make sure the VM is ran with the correct rng device Two changes done: - on run, make sure the correct rng source is used - the RngUtils.validate() is changed to not to take the change in versions into account since if the snapshot without memory is restored, the compatibility does not change but the rng source does. In a followup patch also the unused effectiveVersion will be removed. The specific bug fixed in this patch is that in version 4.0 the random source was "/dev/random" while in 4.1 it was "/dev/urandom" so the rng source needs to be reconfigured. Change-Id: If232da469fa6db9a20ed62eb6298a7d0a53064d8 Bug-Url: https://bugzilla.redhat.com/1446640 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/RngDeviceUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/RngUtils.java 4 files changed, 36 insertions(+), 8 deletions(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/77796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If232da469fa6db9a20ed62eb6298a7d0a53064d8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: scheduler: VmAffinityWeightPolicyUnit prefers hosts with pin...
by Code Review 05 Jun '17

05 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: scheduler: VmAffinityWeightPolicyUnit prefers hosts with pinned VMs ...................................................................... scheduler: VmAffinityWeightPolicyUnit prefers hosts with pinned VMs If the scheduled VM is in a positive affinity group with a pinned VM, the policy unit will prefer to choose the host with the pinned VM. Change-Id: I297fbd6feadfdfbfcaf4bd9bd310c11b6d79ab81 Bug-Url: https://bugzilla.redhat.com/1421771 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/VmAffinityFilterPolicyUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/VmAffinityPolicyUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/VmAffinityWeightPolicyUnit.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/VmAffinityWeightPolicyUnitTest.java 4 files changed, 78 insertions(+), 35 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/77393 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I297fbd6feadfdfbfcaf4bd9bd310c11b6d79ab81 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: scheduler: Refactor VM affinity policy units and add tests
by Code Review 05 Jun '17

05 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: scheduler: Refactor VM affinity policy units and add tests ...................................................................... scheduler: Refactor VM affinity policy units and add tests Additionally, weight policy unit considers also nonenforcing affinity groups. Change-Id: Ief956fa3af97f57c03c5a37c83e22725ebb84666 Bug-Url: https://bugzilla.redhat.com/1421771 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/VmAffinityFilterPolicyUnit.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/VmAffinityPolicyUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/VmAffinityWeightPolicyUnit.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/VmAffinityFilterPolicyUnitTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/VmAffinityPolicyUnitTestBase.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/VmAffinityWeightPolicyUnitTest.java 6 files changed, 484 insertions(+), 158 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/77392 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief956fa3af97f57c03c5a37c83e22725ebb84666 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Affinity enforcer checks VMs on all hosts in a group
by Code Review 05 Jun '17

05 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Affinity enforcer checks VMs on all hosts in a group ...................................................................... core: Affinity enforcer checks VMs on all hosts in a group Previously affinity enforcer tried to migrate VMs only from a single chosen host. Now, if no VM can be migrated from one host, it tries another. Change-Id: I0b0e8f027707dc577785050d0b5c796c334ffe71 Bug-Url: https://bugzilla.redhat.com/1421771 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcer.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcerTest.java 2 files changed, 75 insertions(+), 99 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/77390 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b0e8f027707dc577785050d0b5c796c334ffe71 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Nonmigratable VMs are ignored by affinity rules enforcer
by Code Review 05 Jun '17

05 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Nonmigratable VMs are ignored by affinity rules enforcer ...................................................................... core: Nonmigratable VMs are ignored by affinity rules enforcer If a positive affinity rule contains a nonmigratable VM, no VMs running on the same host are chosen for migration. This means that VMs will not migrate away from the pinned VMs or oscillate between two hosts containing pinned VMs. Change-Id: I5553a30575859666d1c3c192811c157a30476b38 Bug-Url: https://bugzilla.redhat.com/1421771 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcer.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcerTest.java 2 files changed, 50 insertions(+), 6 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/77391 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5553a30575859666d1c3c192811c157a30476b38 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[master]: Retrieve storage domain stats only for one domain
by Code Review 05 Jun '17

05 Jun '17

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. Change subject: Retrieve storage domain stats only for one domain ...................................................................... Retrieve storage domain stats only for one domain Change-Id: Ifdfd33cf795c37172c431b68c6922cdabac75c98 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M ovirt-hosted-engine-ha.spec.in M ovirt_hosted_engine_ha/agent/hosted_engine.py M ovirt_hosted_engine_ha/lib/upgrade.py 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/77625 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifdfd33cf795c37172c431b68c6922cdabac75c98 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[master]: Check logging level instead of calling VDSM and discarding r...
by Code Review 05 Jun '17

05 Jun '17

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. Change subject: Check logging level instead of calling VDSM and discarding result ...................................................................... Check logging level instead of calling VDSM and discarding result Change-Id: Ibf1fcadd628d40bc1cfa94a1c461297e9f78d57e Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/upgrade.py 1 file changed, 11 insertions(+), 8 deletions(-) Approvals: Denis Chaplygin: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/77626 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf1fcadd628d40bc1cfa94a1c461297e9f78d57e Gerrit-PatchSet: 7 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: inventory: check for vms with VirtIO serial console in <= 3.5
by Code Review 05 Jun '17

05 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: inventory: check for vms with VirtIO serial console in <= 3.5 ...................................................................... inventory: check for vms with VirtIO serial console in <= 3.5 VMs with VirtIO serial console enabled in cluster levels 3.5 and below cannot be later live migrated to 3.6 hosts (on RHEL7). Change-Id: I50e493c7b2d849dc8a1588629f21bedf4bf832d7 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/Makefile.am M src/inventory_report/produceReport/pre-upgrade-checks M src/inventory_report/produceReport/produceReport.sh A src/inventory_report/produceReport/sqls/vms_with_cluster_lower_3_6_with_virtio_serial_console.sql 4 files changed, 71 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77726 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50e493c7b2d849dc8a1588629f21bedf4bf832d7 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[v2.1.z]: monitors: Send multiple ping packets and penalize based on n...
by Code Review 05 Jun '17

05 Jun '17

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. Change subject: monitors: Send multiple ping packets and penalize based on number of lost ...................................................................... monitors: Send multiple ping packets and penalize based on number of lost Change-Id: I59d8d69dd88f4adbdc9322642cfec9332b6f59e7 Bug-Url:https://bugzilla.redhat.com/1449333 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/hosted_engine.py M ovirt_hosted_engine_ha/agent/states.py M ovirt_hosted_engine_ha/broker/submonitors/ping.py 3 files changed, 33 insertions(+), 12 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/77806 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59d8d69dd88f4adbdc9322642cfec9332b6f59e7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: v2.1.z Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[master]: monitors: Send multiple ping packets and penalize based on n...
by Code Review 05 Jun '17

05 Jun '17

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. Change subject: monitors: Send multiple ping packets and penalize based on number of lost ...................................................................... monitors: Send multiple ping packets and penalize based on number of lost Change-Id: I59d8d69dd88f4adbdc9322642cfec9332b6f59e7 Bug-Url:https://bugzilla.redhat.com/1449333 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/hosted_engine.py M ovirt_hosted_engine_ha/agent/states.py M ovirt_hosted_engine_ha/broker/submonitors/ping.py 3 files changed, 33 insertions(+), 12 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/77558 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59d8d69dd88f4adbdc9322642cfec9332b6f59e7 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: filter unmanaged devices from payload
by Code Review 05 Jun '17

05 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: filter unmanaged devices from payload ...................................................................... core: filter unmanaged devices from payload Change-Id: I3795295e6c5f6d32f8f90249962a83d0092f804b Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmPayloadQuery.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77769 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3795295e6c5f6d32f8f90249962a83d0092f804b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: legacy usb fix
by Code Review 05 Jun '17

05 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: legacy usb fix ...................................................................... core: legacy usb fix Apparently having unmanaged usb controller along with the managed controllers we add, might result in conflicting addresses. Therefore, in this patch we remove existing controllers before adding new ones. Change-Id: Ic1c6236024cd30be5f8cc8822fb295bf84429000 Bug-Url: https://bugzilla.redhat.com/1443078 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/77782 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1c6236024cd30be5f8cc8822fb295bf84429000 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[master]: packaging: spec: fix repolib handling
by Code Review 05 Jun '17

05 Jun '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: fix repolib handling ...................................................................... packaging: spec: fix repolib handling fixed repolib creation even when building with maven. Previously it worked only while building without maven. Change-Id: I2aeb9702aa41c7c94eb763dd5efc829a79c3e852 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M otopi.spec.in 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77783 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2aeb9702aa41c7c94eb763dd5efc829a79c3e852 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: spec: update dependencies
by Code Review 05 Jun '17

05 Jun '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: update dependencies ...................................................................... packaging: spec: update dependencies Re-aligned dependencies for 4.2 Change-Id: I7be1d4c7f089e704e6310932a31e6b875710eeb6 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-hosted-engine-setup.spec.in 1 file changed, 6 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77786 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7be1d4c7f089e704e6310932a31e6b875710eeb6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Use ID from params for the locks in AmendImageGroupVol...
by Code Review 05 Jun '17

05 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Use ID from params for the locks in AmendImageGroupVolumesCommand ...................................................................... core: Use ID from params for the locks in AmendImageGroupVolumesCommand Use the disk ID from the parameters to create the shared locks map instead of fetching the disk from the database just to use its ID Change-Id: Ia7255f3cfd7bfd38d3f8f50d76690b3976888583 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/AmendImageGroupVolumesCommand.java 1 file changed, 3 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/77668 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7255f3cfd7bfd38d3f8f50d76690b3976888583 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Method reference in AmendImageGroupVolumesCommand
by Code Review 05 Jun '17

05 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Method reference in AmendImageGroupVolumesCommand ...................................................................... core: Method reference in AmendImageGroupVolumesCommand Replace Lambda call in method reference for cleaner code Change-Id: Ic46586b3b3b067fd1788f87e20990a67eb36077c Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/AmendImageGroupVolumesCommand.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/77661 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic46586b3b3b067fd1788f87e20990a67eb36077c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AmendImageGroupVolumesCommand streams
by Code Review 05 Jun '17

05 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: AmendImageGroupVolumesCommand streams ...................................................................... core: AmendImageGroupVolumesCommand streams Change-Id: I2aceb7f9a6fb11d1aaf7456aec950bfa9443733c Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/AmendImageGroupVolumesCommand.java 1 file changed, 4 insertions(+), 11 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/77660 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2aceb7f9a6fb11d1aaf7456aec950bfa9443733c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Add a test to AmendImageGroupVolumesCommandTest
by Code Review 05 Jun '17

05 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Add a test to AmendImageGroupVolumesCommandTest ...................................................................... core: Add a test to AmendImageGroupVolumesCommandTest Change-Id: Ie3cceb145fc3c40ca79d7485cf686463aa0d55c8 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/AmendImageGroupVolumesCommandTest.java 1 file changed, 173 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Maor Lipchuk: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/77659 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3cceb145fc3c40ca79d7485cf686463aa0d55c8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: make sure the VM is ran with the correct rng device
by Code Review 05 Jun '17

05 Jun '17

>From Tomas Jelinek <tjelinek(a)redhat.com>: Tomas Jelinek has submitted this change and it was merged. Change subject: core: make sure the VM is ran with the correct rng device ...................................................................... core: make sure the VM is ran with the correct rng device Two changes done: - on run, make sure the correct rng source is used - the RngUtils.validate() is changed to not to take the change in versions into account since if the snapshot without memory is restored, the compatibility does not change but the rng source does. In a followup patch also the unused effectiveVersion will be removed. The specific bug fixed in this patch is that in version 4.0 the random source was "/dev/random" while in 4.1 it was "/dev/urandom" so the rng source needs to be reconfigured. Change-Id: If232da469fa6db9a20ed62eb6298a7d0a53064d8 Bug-Url: https://bugzilla.redhat.com/1446640 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/RngDeviceUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/RngUtils.java 4 files changed, 40 insertions(+), 12 deletions(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/77548 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If232da469fa6db9a20ed62eb6298a7d0a53064d8 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ShellLikeConfdTest streams
by Code Review 05 Jun '17

05 Jun '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: ShellLikeConfdTest streams ...................................................................... core: ShellLikeConfdTest streams Use Java 8 streams to improve the code's cleanliness and performance. Change-Id: I325118b6c91617ad4e3f251357a9b6578150c3f5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/config/ShellLikeConfdTest.java 1 file changed, 3 insertions(+), 11 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/77781 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I325118b6c91617ad4e3f251357a9b6578150c3f5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: engine: Reset gluster uuid on reinstall
by Code Review 05 Jun '17

05 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: engine: Reset gluster uuid on reinstall ...................................................................... engine: Reset gluster uuid on reinstall If gluster UUID is detected as changed during a reinstall, update this in the database Bug-Url: https://bugzilla.redhat.com/1431529 Change-Id: If48f17a10fde6ccba98085c9d3568b3bb10f4369 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitGlusterCommandHelper.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Denis Chaplygin: Looks good to me, but someone else must approve Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Sahina Bose: Verified -- To view, visit https://gerrit.ovirt.org/77698 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If48f17a10fde6ccba98085c9d3568b3bb10f4369 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: legacy usb fix
by Code Review 05 Jun '17

05 Jun '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: legacy usb fix ...................................................................... core: legacy usb fix Apparently having unmanaged usb controller along with the managed controllers we add, might result in conflicting addresses. Therefore, in this patch we remove existing controllers before adding new ones. Change-Id: Ic1c6236024cd30be5f8cc8822fb295bf84429000 Bug-Url: https://bugzilla.redhat.com/1443078 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/77666 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1c6236024cd30be5f8cc8822fb295bf84429000 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Actions can return HTTP 201 and 202 response code
by Code Review 05 Jun '17

05 Jun '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Actions can return HTTP 201 and 202 response code ...................................................................... Actions can return HTTP 201 and 202 response code The API actions can return HTTP reponse codes 201 and 202, this patch ensure we handle those codes. Change-Id: I9fe1fef7b42a36f8af03fa346db8ac78819df020 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M sdk/lib/ovirtsdk4/service.rb 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ondra Machacek: Verified Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76721 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fe1fef7b42a36f8af03fa346db8ac78819df020 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Correct audit log when running a stateless VM
by Code Review 04 Jun '17

04 Jun '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: Correct audit log when running a stateless VM ...................................................................... core: Correct audit log when running a stateless VM Added a condition to RunVmCommand.getAuditLogTypeValue() to display correct message in the audit log when running a VM as stateless. Change-Id: I49c78fa5cd4f58ef8f5767ca383ccc48ae4e1f86 Bug-Url: https://bugzilla.redhat.com/1411075 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java 2 files changed, 16 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/77460 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49c78fa5cd4f58ef8f5767ca383ccc48ae4e1f86 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Use ExternalTrustStoreInitializer
by Code Review 04 Jun '17

04 Jun '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. Change subject: engine: Use ExternalTrustStoreInitializer ...................................................................... engine: Use ExternalTrustStoreInitializer Use ExternalTrustStoreInitializer to create the keystore in CustomizedRESTEasyConnector. This avoids to reimplement the opening of the ExternalTrustStore. Change-Id: I1cb26f7472047fbc338b03122f2d03be451cfb84 Signed-off-by: Dominik Holler <dholler(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/CustomizedRESTEasyConnector.java 1 file changed, 3 insertions(+), 8 deletions(-) Approvals: Dominik Holler: Verified Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/77151 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1cb26f7472047fbc338b03122f2d03be451cfb84 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Search by Vms: next_run_config_exists
by Code Review 04 Jun '17

04 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Search by Vms: next_run_config_exists ...................................................................... core: Search by Vms: next_run_config_exists Added ability to search VMs with NEXT_RUN snapshot waiting to be applied on VM shutdown. The query will look like: Vms: next_run_config_exists = true Change-Id: Ia821c070e88ef879b730f43fa9c87c349ce4a6ff Bug-Url: https://bugzilla.redhat.com/1432912 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/77761 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia821c070e88ef879b730f43fa9c87c349ce4a6ff Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: VncNativeImpl curly braces
by Code Review 04 Jun '17

04 Jun '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: VncNativeImpl curly braces ...................................................................... webadmin: VncNativeImpl curly braces Remove redundant curly braces in a single statements lambda that just make reading the code less comfortable. Change-Id: I6466569ebcfd7a4674cdd04747ab04186f4cb839 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/VncNativeImpl.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/77715 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6466569ebcfd7a4674cdd04747ab04186f4cb839 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: VncNativeImpl type inference
by Code Review 04 Jun '17

04 Jun '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: VncNativeImpl type inference ...................................................................... webadmin: VncNativeImpl type inference Change-Id: I591cee56140fee9b14f679f554e5f09836b756a7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/VncNativeImpl.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/77714 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I591cee56140fee9b14f679f554e5f09836b756a7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: minor refactoring in devices querying
by Code Review 04 Jun '17

04 Jun '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: minor refactoring in devices querying ...................................................................... core: minor refactoring in devices querying Introduce a new query that gets the device type as VmDeviceType rather than String - it is a bit safer and makes the callers a bit more concise. Change-Id: I000cbb582101a6ebf1a34b9e9128d0e98631a78f Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmVersionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/HostDeviceManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDaoImpl.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilderImpl.java 10 files changed, 33 insertions(+), 24 deletions(-) Approvals: Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/77753 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I000cbb582101a6ebf1a34b9e9128d0e98631a78f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove unused hudson profile from pom.xml
by Code Review 04 Jun '17

04 Jun '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused hudson profile from pom.xml ...................................................................... core: Remove unused hudson profile from pom.xml Change-Id: Ifb7d4eb925d5a3fc894f527f07e87d9391df86aa Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M pom.xml 1 file changed, 0 insertions(+), 52 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Sandro Bonazzola: Looks good to me, but someone else must approve Martin Peřina: Looks good to me, but someone else must approve Eyal Edri: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/77496 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb7d4eb925d5a3fc894f527f07e87d9391df86aa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: VDSParametersBase type inference
by Code Review 04 Jun '17

04 Jun '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: VDSParametersBase type inference ...................................................................... core: VDSParametersBase type inference Change-Id: I9c8e200172f0b53a4593d50502c58b9d79639341 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSParametersBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/77561 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c8e200172f0b53a4593d50502c58b9d79639341 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove VDSParameterBase#runAsync
by Code Review 04 Jun '17

04 Jun '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove VDSParameterBase#runAsync ...................................................................... core: Remove VDSParameterBase#runAsync The runAsync member is never updated nor used, and can safely be removed. After removing that member, the no-arg constructor has no content, so it too can be removed, leaving it to Java to implicitly generate it. Change-Id: I1cab8883fec93bdaf96229c0979738cbf08ae9dc Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSParametersBase.java 1 file changed, 1 insertion(+), 14 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/77562 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1cab8883fec93bdaf96229c0979738cbf08ae9dc Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Rename 'diskImagesNotExist'
by Code Review 04 Jun '17

04 Jun '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: Rename 'diskImagesNotExist' ...................................................................... core: Rename 'diskImagesNotExist' Changed name from 'diskImagesNotExist' to 'disksNotExist' Change-Id: Iaa0dc0030a575e762c65f9c6bab721a4ea67da9c Signed-off-by: Shani Leviim <sleviim(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskExistenceValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskExistenceValidatorTest.java 4 files changed, 6 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Shani Leviim: Verified -- To view, visit https://gerrit.ovirt.org/77225 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa0dc0030a575e762c65f9c6bab721a4ea67da9c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shani Leviim <sleviim(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shani Leviim <sleviim(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: Revert "webadmin, userportal: Upgrade GWT to 2.8.1"
by Code Review 02 Jun '17

02 Jun '17

>From Alexander Wels <awels(a)redhat.com>: Alexander Wels has submitted this change and it was merged. Change subject: Revert "webadmin,userportal: Upgrade GWT to 2.8.1" ...................................................................... Revert "webadmin,userportal: Upgrade GWT to 2.8.1" This reverts commit c4be0cb9e9b72cc4fdbc6091154b225155138deb. Excluding Java source comment changes. Change-Id: Ie4ea852404a13704e1014bb75367a47cfbc6c6ca Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/section/main/presenter/OptionsPopupPresenterWidget.java M pom.xml 2 files changed, 5 insertions(+), 3 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/77719 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4ea852404a13704e1014bb75367a47cfbc6c6ca Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: inventory: Use IN instead of in for SQL cmds
by Code Review 02 Jun '17

02 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: inventory: Use IN instead of in for SQL cmds ...................................................................... inventory: Use IN instead of in for SQL cmds Change-Id: I08563cc0a882156ce2f9f1b54beaa44c0937c0f1 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/sqls/table_check_if_vds_groups_and_cluster_coexist.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/77722 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08563cc0a882156ce2f9f1b54beaa44c0937c0f1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: inventory: Add external link to CheckMixedRhelVersions option
by Code Review 02 Jun '17

02 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: inventory: Add external link to CheckMixedRhelVersions option ...................................................................... inventory: Add external link to CheckMixedRhelVersions option Change-Id: Ie493ba666d278300082f543952fa8365c540ad33 --- M src/inventory_report/produceReport/pre-upgrade-checks 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77694 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie493ba666d278300082f543952fa8365c540ad33 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Donald Berry <dberry(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: inventory: Check for Linux VMs with incorrect timezone
by Code Review 02 Jun '17

02 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: inventory: Check for Linux VMs with incorrect timezone ...................................................................... inventory: Check for Linux VMs with incorrect timezone Display a message if any Linux VM contain incorrect timezone. Change-Id: I0ae2d61f37636a17984c8a6d4c99e37c6787eeae Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/Makefile.am M src/inventory_report/produceReport/pre-upgrade-checks M src/inventory_report/produceReport/produceReport.sh A src/inventory_report/produceReport/sqls/vms_query_linux_and_others_vms_with_incorrect_timezone.sql 4 files changed, 182 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77692 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ae2d61f37636a17984c8a6d4c99e37c6787eeae Gerrit-PatchSet: 3 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Donald Berry <dberry(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0